René's URL Explorer Experiment


Title: quic/blob: dead code for fin? · Issue #64767 · nodejs/node · GitHub

Open Graph Title: quic/blob: dead code for fin? · Issue #64767 · nodejs/node

X Title: quic/blob: dead code for fin? · Issue #64767 · nodejs/node

Description: @jasnell can you have a look at node/lib/internal/blob.js Line 628 in 54a5095 // If the wakeup was triggered by FIN (EndReadable), the DataQueue I mean the if (fin) continue; I think it does not nothing, as the whole fin stuff. So it eit...

Open Graph Description: @jasnell can you have a look at node/lib/internal/blob.js Line 628 in 54a5095 // If the wakeup was triggered by FIN (EndReadable), the DataQueue I mean the if (fin) continue; I think it does not no...

X Description: @jasnell can you have a look at node/lib/internal/blob.js Line 628 in 54a5095 // If the wakeup was triggered by FIN (EndReadable), the DataQueue I mean the if (fin) continue; I think it does not no...

Opengraph URL: https://github.com/nodejs/node/issues/64767

X: @github

direct link

Domain: github.com

Hey, it has json ld scripts: 
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"quic/blob: dead code for fin?","articleBody":"@jasnell can you have a look at https://github.com/nodejs/node/blob/54a50957643f02b5918d7d26afbb855b5ee59a68/lib/internal/blob.js#L628\nI mean the \n```\nif (fin) continue;\n```\nI think it does not nothing, as the whole fin stuff.\nSo it either an artifact, that is now obsolete, that should be removed or something that is important and is just broken.\nDo you remember what it was?\n@pimterry may be you also have a look.","author":{"url":"https://github.com/martenrichter","@type":"Person","name":"martenrichter"},"datePublished":"2026-07-26T20:11:12Z","url":"https://github.com/nodejs/node/issues/64767"}
react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6c961e42-bb33-54c7-4b4d-06ddadcb30ef
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id805E:1463F:33BF68:4334BA:6AED1DAE
html-safe-nonce038cce9dd785e3bd3a302d3a161d502e95887db4d705c79c8258cb973198bd4f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDVFOjE0NjNGOjMzQkY2ODo0MzM0QkE6NkFFRDFEQUUiLCJ2aXNpdG9yX2lkIjoiNDg3OTQzNjk2MTUxMzU0NTEzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9fec3f6ac1e32b738b448c32765097351a43cc49f517e2b038b7008415f0c984
hovercard-subject-tagissue:4982331010
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/64767/issue_layout
twitter:imagehttps://opengraph.githubassets.com/11f5f7f0327e05d8bb24b7077a55a8ecaf13c96baff720b856ef736bab472790/nodejs/node/issues/64767
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/11f5f7f0327e05d8bb24b7077a55a8ecaf13c96baff720b856ef736bab472790/nodejs/node/issues/64767
og:image:alt@jasnell can you have a look at node/lib/internal/blob.js Line 628 in 54a5095 // If the wakeup was triggered by FIN (EndReadable), the DataQueue I mean the if (fin) continue; I think it does not no...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemartenrichter
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/64767#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F64767
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F64767
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/64767
Reloadhttps://github.com/nodejs/node/issues/64767
Reloadhttps://github.com/nodejs/node/issues/64767
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/64767
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/64767
quic/blob: dead code for fin?https://github.com/nodejs/node/issues/64767#top
quicIssues and PRs related to the QUIC transport implementation.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22quic%22
https://github.com/martenrichter
martenrichterhttps://github.com/martenrichter
on Jul 26, 2026https://github.com/nodejs/node/issues/64767#issue-4982331010
@jasnellhttps://github.com/jasnell
node/lib/internal/blob.jshttps://github.com/nodejs/node/blob/54a50957643f02b5918d7d26afbb855b5ee59a68/lib/internal/blob.js#L628
54a5095https://github.com/nodejs/node/commit/54a50957643f02b5918d7d26afbb855b5ee59a68
@pimterryhttps://github.com/pimterry
https://github.com/pimterry
pimterryhttps://github.com/pimterry
on Jul 30, 2026https://github.com/nodejs/node/issues/64767#issuecomment-5131139773
jasnellhttps://github.com/jasnell
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
on Aug 8, 2026https://github.com/nodejs/node/issues/64767#event-29160183751
jasnellhttps://github.com/jasnell
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
on Aug 8, 2026https://github.com/nodejs/node/issues/64767
https://github.com/jasnell
jasnellhttps://github.com/jasnell
on Aug 8, 2026https://github.com/nodejs/node/issues/64767#issuecomment-5227552144
trivikrhttps://github.com/trivikr
quicIssues and PRs related to the QUIC transport implementation.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22quic%22
on Aug 13, 2026https://github.com/nodejs/node/issues/64767#event-29413714297
https://github.com/trivenay
trivenayhttps://github.com/trivenay
on Aug 15, 2026https://github.com/nodejs/node/issues/64767#issuecomment-5304760681
#65315https://github.com/nodejs/node/pull/65315
trivenayhttps://github.com/trivenay
on Aug 16, 2026https://github.com/nodejs/node/issues/64767#event-29519528168
quic: remove unused fin flag from blob reader wakeuphttps://github.com/trivenay/node/commit/9cbb5e4a6b352809912a5d41d28bf82747f00249
9cbb5e4https://github.com/trivenay/node/commit/9cbb5e4a6b352809912a5d41d28bf82747f00249
trivenayhttps://github.com/trivenay
on Aug 28, 2026https://github.com/nodejs/node/issues/64767#event-30173659723
quic: remove unused fin flag from blob reader wakeuphttps://github.com/trivenay/node/commit/ebbaec76b5c0a52ed1b6d9460df71dc7180d1b4f
ebbaec7https://github.com/trivenay/node/commit/ebbaec76b5c0a52ed1b6d9460df71dc7180d1b4f
quic: remove unused fin flag from blob reader wakeuphttps://github.com/trivenay/node/commit/2ebf33d02baf95d4713123eef0b050cc9aa716a9
2ebf33dhttps://github.com/trivenay/node/commit/2ebf33d02baf95d4713123eef0b050cc9aa716a9
nodejs-github-bothttps://github.com/nodejs-github-bot
on Aug 30, 2026https://github.com/nodejs/node/issues/64767#event-30235230460
quic: remove unused fin flag from blob reader wakeuphttps://github.com/nodejs/node/commit/f63bffdde03054bbe5744cb6d866ef70380e9799
f63bffdhttps://github.com/nodejs/node/commit/f63bffdde03054bbe5744cb6d866ef70380e9799
https://github.com/trivenay
trivenayhttps://github.com/trivenay
on Aug 31, 2026https://github.com/nodejs/node/issues/64767#issuecomment-5480289038
#65315https://github.com/nodejs/node/pull/65315
aduh95https://github.com/aduh95
on Sep 3, 2026https://github.com/nodejs/node/issues/64767#event-30485765556
quic: remove unused fin flag from blob reader wakeuphttps://github.com/nodejs/node/commit/1db96e7c3082b595e05a52d86e509bd20a8c8e7f
1db96e7https://github.com/nodejs/node/commit/1db96e7c3082b595e05a52d86e509bd20a8c8e7f
martenrichterhttps://github.com/martenrichter
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 12, 2026https://github.com/nodejs/node/issues/64767#event-31023627268
github-project-automationhttps://github.com/apps/github-project-automation
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
on Sep 12, 2026https://github.com/nodejs/node/issues/64767
aduh95https://github.com/aduh95
on Sep 15, 2026https://github.com/nodejs/node/issues/64767#event-31161514274
quic: remove unused fin flag from blob reader wakeuphttps://github.com/nodejs/node/commit/fce1b6a482bcba2618b3d64e4d7fa609177d4131
fce1b6ahttps://github.com/nodejs/node/commit/fce1b6a482bcba2618b3d64e4d7fa609177d4131
quic: remove unused fin flag from blob reader wakeuphttps://github.com/nodejs/node/commit/024bef25eb72815f8a0917294c28745b150873a4
024bef2https://github.com/nodejs/node/commit/024bef25eb72815f8a0917294c28745b150873a4
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/64767
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/64767
quicIssues and PRs related to the QUIC transport implementation.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22quic%22
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.