Title: stream/iter: Writer methods do not consistently validate options.signal · Issue #64384 · nodejs/node · GitHub
Open Graph Title: stream/iter: Writer methods do not consistently validate options.signal · Issue #64384 · nodejs/node
X Title: stream/iter: Writer methods do not consistently validate options.signal · Issue #64384 · nodejs/node
Description: Version main Platform macOS 26.5.2 Subsystem stream What steps will reproduce the bug? import { Writable } from 'node:stream'; import { broadcast, fromWritable, push, } from 'node:stream/iter'; const badOptions = { signal: 'not an AbortS...
Open Graph Description: Version main Platform macOS 26.5.2 Subsystem stream What steps will reproduce the bug? import { Writable } from 'node:stream'; import { broadcast, fromWritable, push, } from 'node:stream/iter'; con...
X Description: Version main Platform macOS 26.5.2 Subsystem stream What steps will reproduce the bug? import { Writable } from 'node:stream'; import { broadcast, fromWritable, push, } from 'node:strea...
Opengraph URL: https://github.com/nodejs/node/issues/64384
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"stream/iter: Writer methods do not consistently validate options.signal","articleBody":"### Version\n\nmain\n\n### Platform\n\n```text\nmacOS 26.5.2\n```\n\n### Subsystem\n\nstream\n\n### What steps will reproduce the bug?\n\n```js\nimport { Writable } from 'node:stream';\nimport {\n broadcast,\n fromWritable,\n push,\n} from 'node:stream/iter';\n\nconst badOptions = { signal: 'not an AbortSignal' };\n\nconst classicWritable = new Writable({\n write(chunk, encoding, callback) {\n callback();\n },\n});\n\nconst cases = [\n ['push().writer.write()', () =\u003e push().writer.write('x', badOptions)],\n ['push().writer.writev()', () =\u003e push().writer.writev(['x'], badOptions)],\n ['push().writer.end()', () =\u003e push().writer.end(badOptions)],\n\n ['broadcast().writer.write()', () =\u003e broadcast().writer.write('x', badOptions)],\n ['broadcast().writer.writev()', () =\u003e broadcast().writer.writev(['x'], badOptions)],\n ['broadcast().writer.end()', () =\u003e broadcast().writer.end(badOptions)],\n\n ['fromWritable().write()', () =\u003e fromWritable(classicWritable).write('x', badOptions)],\n ['fromWritable().writev()', () =\u003e fromWritable(classicWritable).writev(['x'], badOptions)],\n ['fromWritable().end()', () =\u003e fromWritable(classicWritable).end(badOptions)],\n];\n\nfor (const [name, run] of cases) {\n try {\n const result = run();\n if (result?.then) {\n await result;\n }\n console.log(`${name}: resolved`);\n } catch (err) {\n console.log(`${name}: ${err.code ?? err.name}: ${err.message}`);\n }\n}\n```\n\n### How often does it reproduce? Is there a required condition?\n\nAlways\n\n### What is the expected behavior? Why is that the expected behavior?\n\n```console\npush().writer.write(): ERR_INVALID_ARG_TYPE: ...\npush().writer.writev(): ERR_INVALID_ARG_TYPE: ...\npush().writer.end(): ERR_INVALID_ARG_TYPE: ...\nbroadcast().writer.write(): ERR_INVALID_ARG_TYPE: ...\nbroadcast().writer.writev(): ERR_INVALID_ARG_TYPE: ...\nbroadcast().writer.end(): ERR_INVALID_ARG_TYPE: ...\nfromWritable().write(): ERR_INVALID_ARG_TYPE: ...\nfromWritable().writev(): ERR_INVALID_ARG_TYPE: ...\nfromWritable().end(): ERR_INVALID_ARG_TYPE: ...\n```\n\nA proper invalid-argument TypeError for `options.signal`, ideally Node’s usual `ERR_INVALID_ARG_TYPE`, because the spec defines `WriteOptions.signal` as an `AbortSignal`.\n\n### What do you see instead?\n\n```console\npush().writer.write(): TypeError: signal?.throwIfAborted is not a function\npush().writer.writev(): TypeError: signal?.throwIfAborted is not a function\npush().writer.end(): resolved\nbroadcast().writer.write(): TypeError: signal?.throwIfAborted is not a function\nbroadcast().writer.writev(): TypeError: signal?.throwIfAborted is not a function\nbroadcast().writer.end(): resolved\nfromWritable().write(): resolved\nfromWritable().writev(): resolved\nfromWritable().end(): resolved\n```\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/trivikr","@type":"Person","name":"trivikr"},"datePublished":"2026-07-09T05:02:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/64384/node/issues/64384"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9dd78bce-e3b9-5e8a-e053-1494791714a2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CAD4:19F67D:17C4ACD:21EDD33:6A6358E9 |
| html-safe-nonce | 74e229c7fca91f33b428940e9890a20370d005064d9e35a876a8983d82882f07 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUQ0OjE5RjY3RDoxN0M0QUNEOjIxRUREMzM6NkE2MzU4RTkiLCJ2aXNpdG9yX2lkIjoiNzQ4OTI2ODQ0ODczNDk1OTg1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 585dce13c19ddf6950d0a2e02e2f69509187924572e62b6e2fc87cba91271278 |
| hovercard-subject-tag | issue:4843341714 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/64384/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0931863a35041aa064a51dfbc1843d20240dd42bae725c0dee73f0b2ca7cf78d/nodejs/node/issues/64384 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0931863a35041aa064a51dfbc1843d20240dd42bae725c0dee73f0b2ca7cf78d/nodejs/node/issues/64384 |
| og:image:alt | Version main Platform macOS 26.5.2 Subsystem stream What steps will reproduce the bug? import { Writable } from 'node:stream'; import { broadcast, fromWritable, push, } from 'node:stream/iter'; con... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trivikr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 59e55daad7174ca59d63c6974d58276ccb5477442e550bebb3c035e1bef11c94 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 990295d92a4cc7b63fbbd83a046217cd7d77d49c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width