Title: Add a check to not allow `addTrailers` on an already ended http reply · Issue #62809 · nodejs/node · GitHub
Open Graph Title: Add a check to not allow `addTrailers` on an already ended http reply · Issue #62809 · nodejs/node
X Title: Add a check to not allow `addTrailers` on an already ended http reply · Issue #62809 · nodejs/node
Description: setHeader / setHeaders have a protection against a mistake: node/lib/_http_outgoing.js Lines 645 to 648 in adeb14a OutgoingMessage.prototype.setHeader = function setHeader(name, value) { if (this._header) { throw new ERR_HTTP_HEADERS_SEN...
Open Graph Description: setHeader / setHeaders have a protection against a mistake: node/lib/_http_outgoing.js Lines 645 to 648 in adeb14a OutgoingMessage.prototype.setHeader = function setHeader(name, value) { if (this._...
X Description: setHeader / setHeaders have a protection against a mistake: node/lib/_http_outgoing.js Lines 645 to 648 in adeb14a OutgoingMessage.prototype.setHeader = function setHeader(name, value) { if (this._...
Opengraph URL: https://github.com/nodejs/node/issues/62809
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add a check to not allow `addTrailers` on an already ended http reply","articleBody":"`setHeader` / `setHeaders` have a protection against a mistake:\n\nhttps://github.com/nodejs/node/blob/adeb14a3fdcf19647bff5cf6c964f7c80f3257f9/lib/_http_outgoing.js#L645-L648\n\nhttps://github.com/nodejs/node/blob/adeb14a3fdcf19647bff5cf6c964f7c80f3257f9/lib/_http_outgoing.js#L660-L663\n\n`addTrailers` doesn't, and just assigns to `._trailers` _even if the response is already ended/sent.\n\nhttps://github.com/nodejs/node/blob/adeb14a3fdcf19647bff5cf6c964f7c80f3257f9/lib/_http_outgoing.js#L984-L986\n\nNote: adding this check would be a semver-major change.\n\nE.g. `fastify` incorrectly attempts to do this under some conditions due to a logic mistake.","author":{"url":"https://github.com/ChALkeR","@type":"Person","name":"ChALkeR"},"datePublished":"2026-04-19T00:31:38Z","url":"https://github.com/nodejs/node/issues/62809"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d50bee76-ce16-41f2-5a28-44b7d9e81b46 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 82CA:2614DC:8F322:C38F1:6AED32E8 |
| html-safe-nonce | 838f376df30fe2c6df4d373785c46ecff0b22b21f2031317cc8901ee339ae2b0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkNBOjI2MTREQzo4RjMyMjpDMzhGMTo2QUVEMzJFOCIsInZpc2l0b3JfaWQiOiI5MTU0ODYxMTIxMjI5NjMyMjMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d4bda0000411ced8e007c91ee0e3289d825df0f1d5e8f67ccaea9d79df07b539 |
| hovercard-subject-tag | issue:4289568840 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/62809/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0c71bf8e4962010c745d0c25cc9cd1486b883a20efbb657da59a4a6373181ece/nodejs/node/issues/62809 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0c71bf8e4962010c745d0c25cc9cd1486b883a20efbb657da59a4a6373181ece/nodejs/node/issues/62809 |
| og:image:alt | setHeader / setHeaders have a protection against a mistake: node/lib/_http_outgoing.js Lines 645 to 648 in adeb14a OutgoingMessage.prototype.setHeader = function setHeader(name, value) { if (this._... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ChALkeR |
| hostname | github.com |
| expected-hostname | github.com |
| None | e51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ebb7b901cc154ecc179a44f266fcf69f343b30 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width