Title: http: regression in Upgrade header handling · Issue #627 · nodejs/node · GitHub
Open Graph Title: http: regression in Upgrade header handling · Issue #627 · nodejs/node
X Title: http: regression in Upgrade header handling · Issue #627 · nodejs/node
Description: 'use strict'; var assert = require('assert'); var http = require('http'); var net = require('net'); var seenUpgrade = 0; process.on('exit', function() { assert.equal(seenUpgrade, 1); }); http.createServer(assert.fail).listen(0, '127.0.0....
Open Graph Description: 'use strict'; var assert = require('assert'); var http = require('http'); var net = require('net'); var seenUpgrade = 0; process.on('exit', function() { assert.equal(seenUpgrade, 1); }); http.creat...
X Description: 'use strict'; var assert = require('assert'); var http = require('http'); var net = require('net'); var seenUpgrade = 0; process.on('exit', function() { asse...
Opengraph URL: https://github.com/nodejs/node/issues/627
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"http: regression in Upgrade header handling","articleBody":"``` javascript\n'use strict';\n\nvar assert = require('assert');\nvar http = require('http');\nvar net = require('net');\n\nvar seenUpgrade = 0;\nprocess.on('exit', function() { assert.equal(seenUpgrade, 1); });\n\nhttp.createServer(assert.fail).listen(0, '127.0.0.1', function() {\n this.on('upgrade', function(req, conn, head) {\n seenUpgrade += 1;\n conn.destroy();\n this.close();\n });\n var options = { host: this.address().address, port: this.address().port };\n net.connect(options, function() {\n this.write('GET / HTTP/1.1\\r\\n' +\n 'Upgrade: Yes, please.\\r\\n' +\n '\\r\\n');\n });\n});\n```\n\nWorks with joyent/node@v0.11.16 but fails with iojs@5843ae8. The request callback is called and the 'upgrade' event doesn't fire. I'll bisect.\n","author":{"url":"https://github.com/bnoordhuis","@type":"Person","name":"bnoordhuis"},"datePublished":"2015-01-27T21:29:50.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/627/node/issues/627"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:002674a2-da48-81db-23c6-8662fb9c91b8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CA90:186324:3BBE73:4F0F4C:6A529349 |
| html-safe-nonce | 85d4af6a7b9207bbfc8c07ce3f9db55f47c224ac6d5497412caff0ff624434b5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTkwOjE4NjMyNDozQkJFNzM6NEYwRjRDOjZBNTI5MzQ5IiwidmlzaXRvcl9pZCI6IjQ2NTg1MjE2NTUwMjY1NTM2NzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 586966411f681cabf5ea82c91a0d5359c39ee1298cf043eaca59869804bb1a43 |
| hovercard-subject-tag | issue:55677175 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/627/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a8d970af17a98d218482a2a4c07cf05a2c06fda829b1b56d58bb9382f6cabd98/nodejs/node/issues/627 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a8d970af17a98d218482a2a4c07cf05a2c06fda829b1b56d58bb9382f6cabd98/nodejs/node/issues/627 |
| og:image:alt | 'use strict'; var assert = require('assert'); var http = require('http'); var net = require('net'); var seenUpgrade = 0; process.on('exit', function() { assert.equal(seenUpgrade, 1); }); http.creat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bnoordhuis |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width