René's URL Explorer Experiment


Title: `make test-only` should not depend on doc-kit · Issue #62385 · nodejs/node · GitHub

Open Graph Title: `make test-only` should not depend on doc-kit · Issue #62385 · nodejs/node

X Title: `make test-only` should not depend on doc-kit · Issue #62385 · nodejs/node

Description: I noticed this from nodejs/doc-kit#691 which was introduced by #57343 and this does not look right make test-only is for functional tests. It's not for contributing or CI testing, but for embedders or distributors to verify the Node.js b...

Open Graph Description: I noticed this from nodejs/doc-kit#691 which was introduced by #57343 and this does not look right make test-only is for functional tests. It's not for contributing or CI testing, but for embedders...

X Description: I noticed this from nodejs/doc-kit#691 which was introduced by #57343 and this does not look right make test-only is for functional tests. It's not for contributing or CI testing, but for embed...

Opengraph URL: https://github.com/nodejs/node/issues/62385

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`make test-only` should not depend on doc-kit","articleBody":"I noticed this from https://github.com/nodejs/doc-kit/pull/691 which was introduced by https://github.com/nodejs/node/pull/57343 and this does not look right\n\n1. `make test-only` is for *functional* tests. It's not for contributing or CI testing, but for embedders or distributors to verify the Node.js binary they build is functioning correctly. It should not run any code building the docs into a website or the having to support monolithic dependency as that's irrelevant for the goal.\n2. `make test-only` should not require internet installs. Again it's only for people verifying the binary, you could just be scp-ing a tarball into a build server that does not necessarily have the permission to download from npm registry - and it'd be a pain having to work around it just so that you can test the Node.js binary works correctly, and do not care about the doc building at all.\n3. As `make test-only` is functional tests, it's what should be run on experimental platforms to verify the binary works correctly on a platform that's not yet well supported. `doc-kit` depends on e.g. prebuilt addons/wasm that would make it unnecessarily difficult for no good reason, as can be seen from https://github.com/nodejs/doc-kit/pull/691\n\nFrom a glance I think we should move https://github.com/nodejs/doc-kit/blob/main/src/generators/addon-verify/index.mjs back into core and replace it with a simple script with regexes that extract the artifacts. Unless there are other non-doc tests that depend on doc-kit - as far as I can tell the addon doc building is the only dependency, but it's an overkill having to e.g. run the minifier/highlighter (??!!) to extract the addons for testing. We can simply leave explicit markers in the markdown to deterministically know how the artifacts should be extracted, having to parse markdown and guess where they are based on headings is already hacky and brittle for this.","author":{"url":"https://github.com/joyeecheung","@type":"Person","name":"joyeecheung"},"datePublished":"2026-03-22T02:25:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/62385/node/issues/62385"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:dc94f313-074d-dfe8-2d10-d6bd83e01d8d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC698:264214:25F23B:36D18A:6A4D0A59
html-safe-noncec6a3d37a4b22e2f4f436be4234240004205794fc6a91b6575a2f61369002fe90
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjk4OjI2NDIxNDoyNUYyM0I6MzZEMThBOjZBNEQwQTU5IiwidmlzaXRvcl9pZCI6IjY5MTY3OTI4MjQ3ODUzNDEwMTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc34f7f271b3ca0b331d6ab7fd3d5adc6b37c5e8463e5226c73589e24f92ced61
hovercard-subject-tagissue:4114440490
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/62385/issue_layout
twitter:imagehttps://opengraph.githubassets.com/12dfd2254da02b0bd2be4fbe97c14d8d537570b0badfb15613029f3c887bad7d/nodejs/node/issues/62385
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/12dfd2254da02b0bd2be4fbe97c14d8d537570b0badfb15613029f3c887bad7d/nodejs/node/issues/62385
og:image:altI noticed this from nodejs/doc-kit#691 which was introduced by #57343 and this does not look right make test-only is for functional tests. It's not for contributing or CI testing, but for embedders...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb70bd3c4b2bec429781b65419e912c66e2d5581
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/issues/62385#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F62385
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F62385
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/62385
Reloadhttps://github.com/nodejs/node/issues/62385
Reloadhttps://github.com/nodejs/node/issues/62385
Please reload this pagehttps://github.com/nodejs/node/issues/62385
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/issues/62385
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 958 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
#62388https://github.com/nodejs/node/pull/62388
make test-only should not depend on doc-kithttps://github.com/nodejs/node/issues/62385#top
#62388https://github.com/nodejs/node/pull/62388
buildIssues and PRs related to build files or the CI.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22build%22
docIssues and PRs related to the documentations.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22doc%22
testIssues and PRs related to the tests.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22test%22
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
on Mar 22, 2026https://github.com/nodejs/node/issues/62385#issue-4114440490
nodejs/doc-kit#691https://github.com/nodejs/doc-kit/pull/691
#57343https://github.com/nodejs/node/pull/57343
fix: disable wasm highlighter on riscv64 doc-kit#691https://github.com/nodejs/doc-kit/pull/691
https://github.com/nodejs/doc-kit/blob/main/src/generators/addon-verify/index.mjshttps://github.com/nodejs/doc-kit/blob/main/src/generators/addon-verify/index.mjs
buildIssues and PRs related to build files or the CI.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22build%22
docIssues and PRs related to the documentations.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22doc%22
testIssues and PRs related to the tests.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22test%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.