René's URL Explorer Experiment


Title: `enabledHooksExist()` doesn't work as intended · Issue #61019 · nodejs/node · GitHub

Open Graph Title: `enabledHooksExist()` doesn't work as intended · Issue #61019 · nodejs/node

X Title: `enabledHooksExist()` doesn't work as intended · Issue #61019 · nodejs/node

Description: I took a look at enabledHooksExist(), but as discussed in #59873 (comment) and #60913, it seems to not work as intended at the moment: Following the suggestion to use enabledHooksExist(), I spent quite some time on it and gave that a try...

Open Graph Description: I took a look at enabledHooksExist(), but as discussed in #59873 (comment) and #60913, it seems to not work as intended at the moment: Following the suggestion to use enabledHooksExist(), I spent q...

X Description: I took a look at enabledHooksExist(), but as discussed in #59873 (comment) and #60913, it seems to not work as intended at the moment: Following the suggestion to use enabledHooksExist(), I spent q...

Opengraph URL: https://github.com/nodejs/node/issues/61019

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`enabledHooksExist()` doesn't work as intended","articleBody":"I took a look at `enabledHooksExist()`, but as discussed in https://github.com/nodejs/node/pull/59873#issuecomment-3304866589 and https://github.com/nodejs/node/pull/60913, it seems to not work as intended at the moment:\r\n\r\n\u003e Following the suggestion to use enabledHooksExist(), I spent quite some time on it and gave that a try—but found that it consistently returned true, even when no async hooks were active. So, I reverted to using getHookArrays()[0].length \u003e 0, as it provides a more accurate reflection of the current hook state.\r\n\r\n---\r\n\r\n`enabledHooksExist()` checks `async_hook_fields[kCheck] \u003e 0`, but `kCheck` is intentionally set to `1` at Node.js startup, even when no user async hooks have been registered:\r\n\r\nFrom env.cc (L1763):\r\n\r\nhttps://github.com/nodejs/node/blob/e28656a6172c35d88a472e33894a11f0e9f98eee/src/env.cc#L1748-L1763\r\n\r\nThis means `enabledHooksExist()` **always** returns `true`, regardless of whether any `AsyncHook` instances have actually been created and enabled by user code.\r\n\r\n---\r\n\r\nThis behavior dates back to PR #15454 it seems, but even after going through that discussion, I don't really understand the reasoning behind it and the TODO that says we should revert this for LTS releases. I feel like `fields_[kCheck]` should instead be set to `0` during initialization.\r\n\r\nShould we just change that or add a new helper function that would essentially do `AsyncContextFrame.current() != null || getHookArrays()[0].length \u003e 0`?","author":{"url":"https://github.com/gurgunday","@type":"Person","name":"gurgunday"},"datePublished":"2025-12-10T21:46:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/61019/node/issues/61019"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0134260e-6b13-b8c3-e73e-99612d75b1f9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8C04:39C3C2:C7C4159:CD819A0:6A4C4E3F
html-safe-nonce103d6b9ceaf855b5e79baa8e946637bd194a25293136982c8dc7a955f5a79489
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzA0OjM5QzNDMjpDN0M0MTU5OkNEODE5QTA6NkE0QzRFM0YiLCJ2aXNpdG9yX2lkIjoiMTM2NzQ2NzU1MjQ2MDc4NzI2MyIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9
visitor-hmace4eb2a63cd7c51baa51ba0b978e053b436057383617d610430d84fbc5e6a2fea
hovercard-subject-tagissue:3716886106
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/61019/issue_layout
twitter:imagehttps://opengraph.githubassets.com/649ae0537d3d48fef3a3916bf8998c58ecbc8447bffb857aa8a02131aa76ae06/nodejs/node/issues/61019
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/649ae0537d3d48fef3a3916bf8998c58ecbc8447bffb857aa8a02131aa76ae06/nodejs/node/issues/61019
og:image:altI took a look at enabledHooksExist(), but as discussed in #59873 (comment) and #60913, it seems to not work as intended at the moment: Following the suggestion to use enabledHooksExist(), I spent q...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegurgunday
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release65d78903193f110d7a9d1f8587c6dc3cb911aae0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/issues/61019#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F61019
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F61019
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/61019
Reloadhttps://github.com/nodejs/node/issues/61019
Reloadhttps://github.com/nodejs/node/issues/61019
Please reload this pagehttps://github.com/nodejs/node/issues/61019
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/issues/61019
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 967 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
#61054https://github.com/nodejs/node/pull/61054
enabledHooksExist() doesn't work as intendedhttps://github.com/nodejs/node/issues/61019#top
#61054https://github.com/nodejs/node/pull/61054
async_hooksIssues and PRs related to the async hooks subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22async_hooks%22
async_local_storageAsyncLocalStoragehttps://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22async_local_storage%22
https://github.com/gurgunday
gurgundayhttps://github.com/gurgunday
on Dec 10, 2025https://github.com/nodejs/node/issues/61019#issue-3716886106
#59873 (comment)https://github.com/nodejs/node/pull/59873#issuecomment-3304866589
#60913https://github.com/nodejs/node/pull/60913
node/src/env.cchttps://github.com/nodejs/node/blob/e28656a6172c35d88a472e33894a11f0e9f98eee/src/env.cc#L1748-L1763
e28656ahttps://github.com/nodejs/node/commit/e28656a6172c35d88a472e33894a11f0e9f98eee
#15454https://github.com/nodejs/node/pull/15454
async_hooksIssues and PRs related to the async hooks subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22async_hooks%22
async_local_storageAsyncLocalStoragehttps://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22async_local_storage%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.