Title: Update `assert.deepStrictEqual` docs to mention `.constructor` property · Issue #60239 · nodejs/node · GitHub
Open Graph Title: Update `assert.deepStrictEqual` docs to mention `.constructor` property · Issue #60239 · nodejs/node
X Title: Update `assert.deepStrictEqual` docs to mention `.constructor` property · Issue #60239 · nodejs/node
Description: Affected URL(s) https://nodejs.org/docs/latest-v24.x/api/assert.html#comparison-details_1 Description of the problem I’ve been running into an bug in my code where assert.deepStrictEqual(a, b) was throwing unexpectedly. To make a long st...
Open Graph Description: Affected URL(s) https://nodejs.org/docs/latest-v24.x/api/assert.html#comparison-details_1 Description of the problem I’ve been running into an bug in my code where assert.deepStrictEqual(a, b) was ...
X Description: Affected URL(s) https://nodejs.org/docs/latest-v24.x/api/assert.html#comparison-details_1 Description of the problem I’ve been running into an bug in my code where assert.deepStrictEqual(a, b) was ...
Opengraph URL: https://github.com/nodejs/node/issues/60239
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Update `assert.deepStrictEqual` docs to mention `.constructor` property","articleBody":"### Affected URL(s)\n\nhttps://nodejs.org/docs/latest-v24.x/api/assert.html#comparison-details_1\n\n### Description of the problem\n\nI’ve been running into an bug in my code where `assert.deepStrictEqual(a, b)` was throwing unexpectedly.\n\nTo make a long story short, `a` and `b` were instances of a derived class that returned a `new Proxy` object in its constructor. The handler for this proxy set a new `Function.prototype.bind` call on *any* function object from the target, but this accidentally caught the `target.constructor` property in the line of fire — the intent was to only rebind instance methods. Basically, `a` and `b` shared the same prototype, but had unequal `.constructor` properties due to the incorrect binding.\n\nThe docs for `assert.deepStrictEqual` say that only the [[Prototype]] and enumerable own properties are checked, so I was scratching my head trying to track down the bug, meticulously checking my code against the docs point by point. Only by stepping through the Node.JS source code did I see [where `.constructor` is accessed](https://github.com/nodejs/node/blob/v22.20.0/lib/internal/util/comparisons.js#L269). Then I found the new docs for [`util.isDeepStrictEqual`](https://nodejs.org/docs/latest-v24.x/api/util.html#utilisdeepstrictequalval1-val2-options), which in v24 has been updated to mention explicitly that constructors are checked. This would’ve been good to know!\n\nSo this issue is a request to update the `assert.deepStrictEqual` docs by adding a bullet point stating how object constructors are included in the comparison algorithm. Thank you!","author":{"url":"https://github.com/chharvey","@type":"Person","name":"chharvey"},"datePublished":"2025-10-13T02:14:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/60239/node/issues/60239"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a172b5e9-6830-c84e-ceb2-1aaaaac17f90 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 84FE:4D576:F839DC:15F541D:6A4CB1FA |
| html-safe-nonce | d85d71b12b35cf219d5f447d97f77e0be8fd8b13f016da98b8f9ebbcb128a3f3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEZFOjRENTc2OkY4MzlEQzoxNUY1NDFEOjZBNENCMUZBIiwidmlzaXRvcl9pZCI6IjM3MjU4Njg4MzIzODk5MDI4NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1349dc5306d396c9c41754211ba2d170f0201a39848e9e0e261dd11071f65129 |
| hovercard-subject-tag | issue:3508230841 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/60239/issue_layout |
| twitter:image | https://opengraph.githubassets.com/05923fa4a1ebff35d4e6bff27ad17b4d257d3304a119a408af8bb8256a93756a/nodejs/node/issues/60239 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/05923fa4a1ebff35d4e6bff27ad17b4d257d3304a119a408af8bb8256a93756a/nodejs/node/issues/60239 |
| og:image:alt | Affected URL(s) https://nodejs.org/docs/latest-v24.x/api/assert.html#comparison-details_1 Description of the problem I’ve been running into an bug in my code where assert.deepStrictEqual(a, b) was ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chharvey |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ae90d426644ca15e89bacceb72e51f4e9dbf85f7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width