René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Async hook stack corruption with --unhandled-rejections=strict","articleBody":"### Version\n\nv24.3.0 (Other versions are also affected. See below.)\n\n### Platform\n\n```text\nDarwin hood.local 24.6.0 Darwin Kernel Version 24.6.0: Mon Jul 14 11:30:29 PDT 2025; root:xnu-11417.140.69~1/RELEASE_ARM64_T6000 arm64\n\nAlso reported on Windows 11.\n```\n\n### Subsystem\n\n_No response_\n\n### What steps will reproduce the bug?\n\nFirst, install jasmine@5.11.0. Then create runner.js as follows:\n\n```\nconst Jasmine = require(\"jasmine\");\nconst fs = require(\"fs\");\n\n(async () =\u003e {\n  const runner = new Jasmine();\n\n  runner.addSpecFile(\"./crash.spec.js\");\n\n  runner.addReporter({\n    suiteDone: async () =\u003e {\n      console.log(\"\\nAbout to crash!\");\n      await fs.promises.readFile(\"./package.json\");\n    },\n  });\n\n  await runner.execute();\n})();\n```\n\nAnd create crash.spec.js as follows:\n\n```\ndescribe('a suite that crashes NodeJS', () =\u003e {\n  it('throws twice', async () =\u003e {\n        await new Promise((resolve, reject) =\u003e {\n            setTimeout(() =\u003e {\n                reject(new Error('foo'));\n            }, 0);\n        }).foo();\n    });\n});\n```\n\nFinally, run `node --unhandled-rejections=strict runner.js`.\n\nI tried and failed to reduce this down to a simple code snippet with no dependencies. The user who reported it to me [stated that it took them two days to reproduce it to this point](https://github.com/jasmine/jasmine/issues/2076). \n\n### How often does it reproduce? Is there a required condition?\n\nReproduces 100% of the time with (at least) 20.19.0, 22.14.0, 24.0.0, and 24.3.0. It's also been reported on \u003e= 22.3.0. Does not reproduce with 20.0.0 or 22.0.0.\n\n### What is the expected behavior? Why is that the expected behavior?\n\nNode should not crash. The script should run to completion and produce output like the following:\n\n```\nRandomized with seed 36538\nStarted\nF\nAbout to crash!\n\n\nFailures:\n1) a suite that crashes NodeJS throws twice\n  Message:\n    TypeError: (intermediate value).foo is not a function\n  Stack:\n        at UserContext.\u003canonymous\u003e (/Users/steve/Downloads/no-zip/crash.spec.js:7:12)\n        at \u003cJasmine\u003e\n\nSuite error: top suite\n  Message:\n    Uncaught exception: Error: foo\n  Stack:\n        at Timeout._onTimeout (/Users/steve/Downloads/no-zip/crash.spec.js:5:24)\n        at listOnTimeout (node:internal/timers:573:17)\n        at process.processTimers (node:internal/timers:514:7)\n  Message:\n    Unhandled promise rejection: Error: foo\n  Stack:\n        at Timeout._onTimeout (/Users/steve/Downloads/no-zip/crash.spec.js:5:24)\n        at listOnTimeout (node:internal/timers:573:17)\n        at process.processTimers (node:internal/timers:514:7)\n\n1 spec, 3 failures\nFinished in 0.007 seconds\nRandomized with seed 36538 (jasmine --random=true --seed=36538)\n```\n\n### What do you see instead?\n\n```\nRandomized with seed 66384\nStarted\nF\nAbout to crash!\n\n  #  node[9176]: void node::AsyncHooks::push_async_context(double, double, Local\u003cObject\u003e) at ../src/env.cc:130\n  #  Assertion failed: (trigger_async_id) \u003e= (-1)\n\n----- Native stack trace -----\n\n 1: 0x10019f040 node::Assert(node::AssertionInfo const\u0026) [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n 2: 0x102236be0 node::AsyncHooks::push_async_context(double, double, v8::Local\u003cv8::Object\u003e) (.cold.2) [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n 3: 0x1000dc85c node::AsyncHooks::grow_async_ids_stack() [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n 4: 0x100098cb4 node::InternalCallbackScope::InternalCallbackScope(node::Environment*, v8::Local\u003cv8::Object\u003e, node::async_context const\u0026, int, v8::Local\u003cv8::Value\u003e) [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n 5: 0x100098da0 node::InternalCallbackScope::InternalCallbackScope(node::AsyncWrap*, int) [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n 6: 0x100196cd4 node::fs::FSReqPromise\u003cnode::AliasedBufferBase\u003cdouble, v8::Float64Array\u003e\u003e::Resolve(v8::Local\u003cv8::Value\u003e) [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n 7: 0x1001a5850 node::fs::AfterStat(uv_fs_s*) [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n 8: 0x1001973a8 node::MakeLibuvRequestCallback\u003cuv_fs_s, void (*)(uv_fs_s*)\u003e::Wrapper(uv_fs_s*) [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n 9: 0x100fd12c4 uv__work_done [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n10: 0x100fd4ff4 uv__async_io [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n11: 0x100fe938c uv__io_poll [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n12: 0x100fd555c uv_run [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n13: 0x100099a98 node::SpinEventLoopInternal(node::Environment*) [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n14: 0x1001eb704 node::NodeMainInstance::Run() [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n15: 0x100159474 node::Start(int, char**) [/Users/steve/.nvm/versions/node/v24.3.0/bin/node]\n16: 0x19fc1ab98 start [/usr/lib/dyld]\nzsh: abort      node --unhandled-rejections=strict runner.js\n```\n\n### Additional information\n\nIf I replace ` await fs.promises.readFile(\"./package.json\");` with `await new Promise(resolve =\u003e setTimeout(resolve));` in runner.js, I sometimes get an early exit instead of a crash. It's easiest to see that if you patch `node_modules/jasmine/lib/jasmine.js` as follows:\n\n```diff\n@@ -239,7 +239,7 @@\n       this.addMatchingSpecFiles(files);\n     }\n \n-    const prematureExitHandler = new ExitHandler(() =\u003e this.exit(4));\n+    const prematureExitHandler = new ExitHandler(() =\u003e console.error('premature exit!'));\n     prematureExitHandler.install();\n     let overallResult;\n```","author":{"url":"https://github.com/sgravrock","@type":"Person","name":"sgravrock"},"datePublished":"2025-09-27T18:18:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/60034/node/issues/60034"}