René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"fs: `opendirSync()` leaks directory handle on error","articleBody":"### Version\n\nv25.0.0-pre\n\n### Platform\n\n```text\nLinux tumba 6.15.3-gentoo-yuran #1 SMP Sat Jun 21 21:02:19 +08 2025 x86_64 Intel(R) Core(TM)2 Quad CPU Q8200 @ 2.33GHz GenuineIntel GNU/Linux\n```\n\n### Subsystem\n\nfs\n\n### What steps will reproduce the bug?\n\n`test.mjs` script:\n```mjs\nimport fs from 'node:fs';\n{\n  let dir;\n  try {\n    dir = fs.opendirSync(import.meta.dirname, { bufferSize: Infinity });\n    console.log('successfully got', dir);\n  } catch(e) {\n    console.log('dir is:', dir, 'error is:', e);\n  } finally {\n    dir?.closeSync();\n  }\n}\nglobalThis.gc();\nsetImmediate(() =\u003e {});\n```\nRun it with expose GC flag:\n```console\n$ node --expose-gc test.mjs\n```\n\n### How often does it reproduce? Is there a required condition?\n\nAlways, assuming GC runs.\n\n### What is the expected behavior? Why is that the expected behavior?\n\nThe \"successfully got\" should not be printed.\nThe catched error must be `ERR_OUT_OF_RANGE` because of bad `bufferSize`.\nThe `dir` should be either:\n- An instance of `fs.Dir` that we can `closeSync()` gracefully\n- `undefined` assuming `opendirSync` internally did cleanup\n\n**And most importantly, this code must not emit any warnings.**\n\n### What do you see instead?\n\n```js\ndir is: undefined error is: RangeError [ERR_OUT_OF_RANGE]: The value of \"options.bufferSize\" is out of range. It must be an integer. Received Infinity\n    at new Dir (node:internal/fs/dir:61:5)\n    at Object.opendirSync (node:internal/fs/dir:351:10)\n    at file:///tmp/test.mjs:5:14\n    at ModuleJob.run (node:internal/modules/esm/module_job:372:25)\n    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:665:26)\n    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:99:5) {\n  code: 'ERR_OUT_OF_RANGE'\n}\n(node:8286) Warning: Closing directory handle on garbage collection\n(Use `node --trace-warnings ...` to show where the warning was created)\n```\nWhich means: `dir` stays `undefined` so we can not do anything about it, but the internal directory handle remains open until GC hunts it down.\n\n### Additional information\n\nI haven't checked if `fsPromises.opendir` nor `fs.opendir` have similar problem but most likely they do.\n\nI think this can be fixed on JS side, the patch is WIP.","author":{"url":"https://github.com/LiviaMedeiros","@type":"Person","name":"LiviaMedeiros"},"datePublished":"2025-06-26T21:06:30.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/58854/node/issues/58854"}