René's URL Explorer Experiment


Title: File descriptor 0 might not get closed when used in file stream · Issue #57905 · nodejs/node · GitHub

Open Graph Title: File descriptor 0 might not get closed when used in file stream · Issue #57905 · nodejs/node

X Title: File descriptor 0 might not get closed when used in file stream · Issue #57905 · nodejs/node

Description: Just from reading the code it seems the file descriptor 0 is not closed for streams. node/lib/internal/fs/streams.js Lines 117 to 127 in e61937b function close(stream, err, cb) { if (!stream.fd) { cb(err); } else if (stream.flush) { stre...

Open Graph Description: Just from reading the code it seems the file descriptor 0 is not closed for streams. node/lib/internal/fs/streams.js Lines 117 to 127 in e61937b function close(stream, err, cb) { if (!stream.fd) { ...

X Description: Just from reading the code it seems the file descriptor 0 is not closed for streams. node/lib/internal/fs/streams.js Lines 117 to 127 in e61937b function close(stream, err, cb) { if (!stream.fd) { ...

Opengraph URL: https://github.com/nodejs/node/issues/57905

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"File descriptor 0 might not get closed when used in file stream","articleBody":"Just from reading the code it seems the file descriptor `0` is not closed for streams.\n\nhttps://github.com/nodejs/node/blob/e61937b82cbaec758cceeb08876dd51f976b23c2/lib/internal/fs/streams.js#L117-L127\n\nI have not run any tests to confirm that, but the check in code `if (!stream.fd)` looks rather clear and does not work for fd `0`. The `_close` function actually sets `null`, so more null-like check should be there:\n\nhttps://github.com/nodejs/node/blob/e61937b82cbaec758cceeb08876dd51f976b23c2/lib/internal/fs/streams.js#L129-L134\n","author":{"url":"https://github.com/oldium","@type":"Person","name":"oldium"},"datePublished":"2025-04-16T22:46:44Z","url":"https://github.com/nodejs/node/issues/57905"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:bf1934cd-9c50-4124-aedd-ce228ae87764
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC266:3CE69D:45864B:5A13F2:6AED246F
html-safe-noncedd48a340b704a4125acb731ce8ba100092972e427ea16d0c99915a1f55030d44
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjY2OjNDRTY5RDo0NTg2NEI6NUExM0YyOjZBRUQyNDZGIiwidmlzaXRvcl9pZCI6IjE3NjYwMDY3NTQ4MDIyMTM5OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac806f2ba3c89d90c1c2d8d3e9868e9ddc788d949e8846548c8271c35ddf0fef01
hovercard-subject-tagissue:3000918528
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/57905/issue_layout
twitter:imagehttps://opengraph.githubassets.com/31af0be7fc618aaa9caf22e1d605b8e42b9dd0421589de59bf4b73d0d24d2676/nodejs/node/issues/57905
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/31af0be7fc618aaa9caf22e1d605b8e42b9dd0421589de59bf4b73d0d24d2676/nodejs/node/issues/57905
og:image:altJust from reading the code it seems the file descriptor 0 is not closed for streams. node/lib/internal/fs/streams.js Lines 117 to 127 in e61937b function close(stream, err, cb) { if (!stream.fd) { ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameoldium
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/57905#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F57905
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F57905
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/57905
Reloadhttps://github.com/nodejs/node/issues/57905
Reloadhttps://github.com/nodejs/node/issues/57905
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/57905
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/57905
#66131https://github.com/nodejs/node/pull/66131
File descriptor 0 might not get closed when used in file streamhttps://github.com/nodejs/node/issues/57905#top
#66131https://github.com/nodejs/node/pull/66131
fsIssues and PRs related to file-system APIs and the fs module.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22fs%22
https://github.com/oldium
oldiumhttps://github.com/oldium
on Apr 16, 2025https://github.com/nodejs/node/issues/57905#issue-3000918528
node/lib/internal/fs/streams.jshttps://github.com/nodejs/node/blob/e61937b82cbaec758cceeb08876dd51f976b23c2/lib/internal/fs/streams.js#L117-L127
e61937bhttps://github.com/nodejs/node/commit/e61937b82cbaec758cceeb08876dd51f976b23c2
node/lib/internal/fs/streams.jshttps://github.com/nodejs/node/blob/e61937b82cbaec758cceeb08876dd51f976b23c2/lib/internal/fs/streams.js#L129-L134
e61937bhttps://github.com/nodejs/node/commit/e61937b82cbaec758cceeb08876dd51f976b23c2
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
on Apr 20, 2026https://github.com/nodejs/node/issues/57905#issuecomment-4277372492
GitHub Actionshttps://help.github.com/en/actions
github-actionshttps://github.com/apps/github-actions
staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stale%22
on Apr 20, 2026https://github.com/nodejs/node/issues/57905#event-24659037873
https://github.com/oldium
oldiumhttps://github.com/oldium
on Apr 20, 2026https://github.com/nodejs/node/issues/57905#issuecomment-4282142056
github-actionshttps://github.com/apps/github-actions
staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stale%22
on Apr 21, 2026https://github.com/nodejs/node/issues/57905#event-24700717155
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
on Jul 20, 2026https://github.com/nodejs/node/issues/57905#issuecomment-5019626872
GitHub Actionshttps://help.github.com/en/actions
github-actionshttps://github.com/apps/github-actions
staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stale%22
on Jul 20, 2026https://github.com/nodejs/node/issues/57905#event-28198589601
https://github.com/oldium
oldiumhttps://github.com/oldium
on Jul 20, 2026https://github.com/nodejs/node/issues/57905#issuecomment-5026482516
github-actionshttps://github.com/apps/github-actions
staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stale%22
on Jul 21, 2026https://github.com/nodejs/node/issues/57905#event-28243840257
jakecastellihttps://github.com/jakecastelli
fsIssues and PRs related to file-system APIs and the fs module.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22fs%22
on Sep 11, 2026https://github.com/nodejs/node/issues/57905#event-30951686133
nodejs-github-bothttps://github.com/nodejs-github-bot
on Sep 22, 2026https://github.com/nodejs/node/issues/57905#event-31588586921
fs: close file streams with fd 0https://github.com/nodejs/node/commit/36dd044cfdb20487951a83b75a3341af3025ca17
36dd044https://github.com/nodejs/node/commit/36dd044cfdb20487951a83b75a3341af3025ca17
nodejs-github-bothttps://github.com/nodejs-github-bot
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#66131https://github.com/nodejs/node/pull/66131
on Sep 22, 2026https://github.com/nodejs/node/issues/57905#event-31588587048
aduh95https://github.com/aduh95
on Sep 27, 2026https://github.com/nodejs/node/issues/57905#event-31936989824
fs: close file streams with fd 0https://github.com/nodejs/node/commit/e7d5352fa6cc52826507cf195f066587052f62f3
e7d5352https://github.com/nodejs/node/commit/e7d5352fa6cc52826507cf195f066587052f62f3
aduh95https://github.com/aduh95
on Oct 23, 2026https://github.com/nodejs/node/issues/57905#event-34094340595
fs: close file streams with fd 0https://github.com/nodejs/node/commit/70788df7d8a799d861444a656ea7dba56ba3274a
70788dfhttps://github.com/nodejs/node/commit/70788df7d8a799d861444a656ea7dba56ba3274a
fs: close file streams with fd 0https://github.com/nodejs/node/commit/ed673e145e941b001f21508f904be72f23f5d08a
ed673e1https://github.com/nodejs/node/commit/ed673e145e941b001f21508f904be72f23f5d08a
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/57905
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/57905
fsIssues and PRs related to file-system APIs and the fs module.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22fs%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.