René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"require(esm) always feeds full filepaths to customization hooks but require.resolve doesn't","articleBody":"### Version\n\nv23.7.0\n\n### Platform\n\n```text\nDarwin X-MacBook-Pro.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64\n```\n\n### Subsystem\n\nmodule\n\n### What steps will reproduce the bug?\n\nCreate a customization hook that intercepts `resolve` and log out the arguments while making some CJS with the patched require from being loaded via ESM; notice that randomly even though it is not possible to resolve to `file:` you get a file specifier (added some CJS hooks to show better explanation [note _load called differently in non-requirable ESM CJS]):\n\n```cjs\nconst Module = require('module');\n\n// Save the original loader so we can call it later.\nconst originalLoad = Module._load;\nconst originalResolveFilename = Module._resolveFilename;\n\nModule._resolveFilename = function(request, parent) {\n  console.log({_resolveFilename:{request,parent}})\n  return 'foo'\n  return originalResolveFilename.apply(this, arguments);\n};\nModule._load = function(request, parent, isMain) {\nconsole.log({_load:{request,parent,isMain}})\n  const exported = originalLoad.apply(this, arguments);\n  return exported;\n};\n\nlet id = 1\nModule.registerHooks({\n    resolve(specifier, context, nextResolve) {\n        console.dir({resolve:{specifier,context}}, {depth:null})\n        if (specifier.startsWith('file:')) {\n            debugger;\n        }\n        return {\n            url: `sea:${id++}`,\n            shortCircuit: true\n        }\n        return nextResolve(specifier, context)\n    },\n    load(url, context, nextLoad) {\n        console.dir({load:{url,context}}, {depth:null})\n        return {\n            source: `\n                if (module.id.endsWith(2)) throw Error('bail');\n                let dep = \"sea:bare/${String(url).slice(4)}\"\n                try {\n                    require(dep);\n                } catch (error) {\n                 // NOTE: this gives a different path to load!\n                    console.log('FAILED TO REQUIRE', dep, require.resolve(dep))\n                }\n            `,\n            format: 'commonjs',\n            shortCircuit: true\n        }\n    }\n})\nimport('bare')\n```\n\n\n### How often does it reproduce? Is there a required condition?\n\neverytime\n\n### What is the expected behavior? Why is that the expected behavior?\n\nCJS (either by default or hooked _resolveFilename resolves to a non-file [e.g. `foo`]) and then that value is passed into the loader hooks\n\n### What do you see instead?\n\n1. IDEAL: don't need to hook into _resolveFilename to make resolution work; (removing the above monkey patch to _resolveFilename still causes failure)\n2. [unify logic of](https://github.com/nodejs/node/blame/main/lib/internal/modules/esm/translators.js#L137-L156) so that instrumentation can properly deduce how to respond\n    i. due to personal preference I'd suggest if they differ to respect the altered form rather than trying to change it into a file.\n    ii. There is some odd logic around WASM and JSON that doesn't match either.\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/bmeck","@type":"Person","name":"bmeck"},"datePublished":"2025-02-18T16:21:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/57125/node/issues/57125"}