Title: tools: `make jslint` crashes with out of memory error · Issue #5595 · nodejs/node · GitHub
Open Graph Title: tools: `make jslint` crashes with out of memory error · Issue #5595 · nodejs/node
X Title: tools: `make jslint` crashes with out of memory error · Issue #5595 · nodejs/node
Description: Version: master Platform: n/a Subsystem: tools I think it may have something to do with the number of files being linted? For example, I have benchmark/tmp filled as a result of running the benchmark/module/module-loader.js benchmark, wh...
Open Graph Description: Version: master Platform: n/a Subsystem: tools I think it may have something to do with the number of files being linted? For example, I have benchmark/tmp filled as a result of running the benchma...
X Description: Version: master Platform: n/a Subsystem: tools I think it may have something to do with the number of files being linted? For example, I have benchmark/tmp filled as a result of running the benchma...
Opengraph URL: https://github.com/nodejs/node/issues/5595
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"tools: `make jslint` crashes with out of memory error","articleBody":"- **Version**: master\n- **Platform**: n/a\n- **Subsystem**: `tools`\n\nI _think_ it may have something to do with the number of files being linted? For example, I have `benchmark/tmp` filled as a result of running the `benchmark/module/module-loader.js` benchmark, which by default generates 50,000 module directories.\n\nIf I remove the `benchmark/tmp` directory, everything works fine and `make jslint` doesn't crash.\n\nWithout looking, my guess is that it has to do with `eslint` buffering the linting results for display at the very end. If my hunch is correct, perhaps it should be tweaked so that linting results are streamed instead of buffered?\n\nFWIW here is the output from the crash:\n\n```\n./node tools/eslint/bin/eslint.js benchmark lib src test tools/doc \\\n tools/eslint-rules --rulesdir tools/eslint-rules\n\n\u003c--- Last few GCs ---\u003e\n\n 125210 ms: Mark-sweep 607.6 (1434.4) -\u003e 605.8 (1434.4) MB, 296.3 / 0 ms [allocation failure] [GC in old space requested].\n 125506 ms: Mark-sweep 605.8 (1434.4) -\u003e 605.6 (1434.4) MB, 295.9 / 0 ms [allocation failure] [GC in old space requested].\n 125812 ms: Mark-sweep 605.6 (1434.4) -\u003e 605.6 (1434.4) MB, 306.3 / 0 ms [last resort gc].\n 126117 ms: Mark-sweep 605.6 (1434.4) -\u003e 605.0 (1434.4) MB, 305.1 / 0 ms [last resort gc].\n\n\n\u003c--- JS stacktrace ---\u003e\n\n==== JS stack trace =========================================\n\nSecurity context: 0x1bfd6dac1ec1 \u003cJS Object\u003e\n 2: readBlockMapping(aka readBlockMapping) [/home/mscdex/git/node/tools/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:1003] [pc=0x2ece2d80ebee] (this=0x1bfd6da04189 \u003cundefined\u003e,state=0x2ab553c22ee9 \u003ca State with map 0x150b17bf0431\u003e,nodeIndent=2,flowIndent=1)\n 3: composeNode(aka composeNode) [/home/mscdex/git/node/tools/eslint/node_modules/js-yaml/lib/js-yaml/loader.js:~1251] [pc=0x2ec...\n\nFATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory\nMakefile:584: recipe for target 'jslint' failed\nmake: *** [jslint] Aborted (core dumped)\n```\n","author":{"url":"https://github.com/mscdex","@type":"Person","name":"mscdex"},"datePublished":"2016-03-08T04:32:55.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/5595/node/issues/5595"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d19d0834-311d-f305-f9c8-f2f416774394 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C60A:35EA72:12F9FFE:1A12796:6A4DE3C7 |
| html-safe-nonce | a570ccf23d4a0a198a546f3f7d52bbbb801068a9bbb21f5239ac21ff78aa35f9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjBBOjM1RUE3MjoxMkY5RkZFOjFBMTI3OTY6NkE0REUzQzciLCJ2aXNpdG9yX2lkIjoiODk2NzY5OTA0ODM2NTM1NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d1cdac3f8c80cb9c192dc4575617b9b7898e4fe662735dccb0b0876b807f5cff |
| hovercard-subject-tag | issue:139177835 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/5595/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3e07e9b2505a21557b07a306ff7840d4d5769e25e9afc165a6c58edabe9880c0/nodejs/node/issues/5595 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3e07e9b2505a21557b07a306ff7840d4d5769e25e9afc165a6c58edabe9880c0/nodejs/node/issues/5595 |
| og:image:alt | Version: master Platform: n/a Subsystem: tools I think it may have something to do with the number of files being linted? For example, I have benchmark/tmp filled as a result of running the benchma... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mscdex |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width