René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"resolve hook is not run for require","articleBody":"### Version\r\n\r\n23.0.0\r\n\r\n### Platform\r\n\r\n```text\r\nLinux hooks 6.8.0-47-generic #47~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Oct  2 16:16:55 UTC 2 x86_64 x86_64 x86_64 GNU/Linux\r\n```\r\n\r\n\r\n### Subsystem\r\n\r\ncustomization hooks\r\n\r\n### What steps will reproduce the bug?\r\n\r\nSet up a [module resolution hook](https://nodejs.org/docs/latest-v22.x/api/module.html#resolvespecifier-context-nextresolve) that replaces the core `fs` import with `fake.js`. Then try to import and require `fs`, respectively. When importing, `fs` is replaced as expected. When requiring, the hook is never run.\r\n\r\n**For the setup:**\r\n\r\n_register.js:_\r\n```\r\nimport { register } from 'node:module';\r\nregister('./hook.js', import.meta.url);\r\n```\r\n\r\n_hook.js:_\r\n```\r\nimport { fileURLToPath } from 'node:url';\r\nimport { dirname, join } from 'node:path';\r\n\r\nexport async function resolve(specifier, context, nextResolve) {\t\r\n\tconst path = fileURLToPath(import.meta.url);\r\n\tconst dir = dirname(path);\r\n\t\r\n\tif (/fs/.test(specifier)) specifier = join(dir, 'fake.js');\r\n\r\n\treturn nextResolve(specifier, context);\r\n};\r\n```\r\n\r\n_fake.js:_\r\n```\r\nexport function readFileSync() { return 'foo'; }\r\n```\r\n\r\n**Now we're ready for the money part:**\r\n\r\n_index.js_\r\n```\r\nimport  {readFileSync} from 'fs';\r\nimport { fileURLToPath } from 'node:url';\r\n\r\nconsole.log(readFileSync(fileURLToPath(import.meta.url), 'utf8')); // 'foo'\r\n```\r\n\r\n_index.cjs:_\r\n```\r\nconst readFileSync = require('fs').readFileSync;\r\n\r\nconsole.log(readFileSync(__filename, 'utf8')); // Prints out the source file\r\n```\r\n\r\nNB: `type` is set to `module` in `package.json`.\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nCan be reliably reproduced every time.\r\n\r\n### What is the expected behavior? Why is that the expected behavior?\r\n\r\nResolve hook should be run even for `require`, and replace `fs` with `fake.js`. The output should be `foo`. \r\n\r\nI am basing this expectation off of the documentation (emphasis mine):\r\n\r\n[`module#resolve`](https://nodejs.org/docs/latest-v22.x/api/module.html#resolvespecifier-context-nextresolve)\r\n\u003e The resolve hook chain is responsible for telling Node.js where to find and how to cache a given import statement or expression, **or require call**.\r\n\r\n[section \"enabling\"](https://nodejs.org/docs/latest-v22.x/api/module.html#enabling):\r\n\u003e my-app.js can also be CommonJS. Customization hooks will run for any modules that it references via import **(and optionally require)**.\r\n\r\n### What do you see instead?\r\n\r\n`node --import=./register.js index.js` produces `foo`, as expected.\r\n\r\n`node --import=./register.js index.cjs` prints out the source file - bad. Annotating the resolve hook with a `console.log` statement shows it is never run.\r\n\r\n### Additional information\r\n\r\nI have asked about this on [Stack Overflow](https://stackoverflow.com/questions/79122415/resolve-hook-not-run-for-require) but not received any answers.","author":{"url":"https://github.com/BadIdeaException","@type":"Person","name":"BadIdeaException"},"datePublished":"2024-11-16T12:29:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/55878/node/issues/55878"}