René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"detect-module: confusing error when parsing a CommonJS module with top-level `await`","articleBody":"Porting from https://github.com/nodejs/TSC/issues/1445#issuecomment-2388678002:\r\n\r\n`index.js`:\r\n\r\n```js\r\nconst {\r\n    getPort,\r\n    checkPort,\r\n    getRandomPort,\r\n    waitForPort,\r\n} = require(\"get-port-please\")\r\n\r\nconst port = await getPort()\r\n```\r\n\r\nGetting this:\r\n\r\n```\r\nRestarting 'index.js'\r\n(node:15356) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///C:/Users/Babak/Documents/Code/c12/index.js is not specified and it doesn't parse as CommonJS.\r\nReparsing as ES module because module syntax was detected. This incurs a performance overhead.\r\nTo eliminate this warning, add \"type\": \"module\" to C:\\Users\\Babak\\Documents\\Code\\c12\\package.json.\r\n(Use `node --trace-warnings ...` to show where the warning was created)\r\nfile:///C:/Users/Babak/Documents/Code/c12/index.js:7\r\n} = require(\"get-port-please\")\r\n    ^\r\n\r\nReferenceError: require is not defined in ES module scope, you can use import instead\r\n    at file:///C:/Users/Babak/Documents/Code/c12/index.js:7:5\r\n    at ModuleJob.run (node:internal/modules/esm/module_job:262:25)\r\n    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:483:26)\r\n\r\nNode.js v22.9.0\r\nFailed running 'index.js'\r\n```\r\n\r\nWith this `package.json`:\r\n\r\n```json\r\n{\r\n    \"dependencies\": {\r\n        \"express\": \"4.21.0\",\r\n        \"get-port-please\": \"3.1.2\"\r\n    },\r\n    \"devDependencies\": {\r\n        \"@types/express\": \"5.0.0\"\r\n    }\r\n}\r\n```\r\n\r\nLOL. (`await` 😈).\r\n\r\n_Originally posted by @babakfp in https://github.com/nodejs/TSC/issues/1445#issuecomment-2388678002_\r\n\r\n\u003chr\u003e\r\n\r\nSo basically, this module fails to parse as _either_ CommonJS or as ESM, and we show the ESM parsing error message. Perhaps we should show both, or show a special message for the common use case of using top-level `await` in a CommonJS module.","author":{"url":"https://github.com/GeoffreyBooth","@type":"Person","name":"GeoffreyBooth"},"datePublished":"2024-11-08T10:59:49.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/55776/node/issues/55776"}