René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Custom DNS lookup failing on Node 20+, works on Node 18","articleBody":"### Version\r\n\r\n20.16.0\r\n\r\n### Platform\r\n\r\n```text\r\nMicrosoft Windows NT 10.0.22621.0\r\nx64\r\n```\r\n\r\n\r\n### Subsystem\r\n\r\n_No response_\r\n\r\n### What steps will reproduce the bug?\r\n```js\r\nconst dns = require('dns');\r\nconst https = require('https');\r\n\r\n// Custom DNS resolution for github.com\r\nconst customDNSLookup = (hostname, options, callback) =\u003e {\r\n    if (hostname === 'github.com') {\r\n        // Using one of GitHub's IPs as an example\r\n        return callback(null, '20.205.243.166', 4);\r\n    } else {\r\n        return dns.lookup(hostname, options, callback);\r\n    }\r\n};\r\n\r\n// Make a test request using native https\r\nasync function testConnection() {\r\n    const options = {\r\n        hostname: 'github.com',\r\n        path: '/',\r\n        method: 'GET',\r\n        headers: {\r\n            'Host': 'github.com'\r\n        },\r\n        agent: new https.Agent({\r\n            rejectUnauthorized: false,\r\n            lookup: customDNSLookup\r\n        })\r\n    };\r\n\r\n    return new Promise((resolve, reject) =\u003e {\r\n        const req = https.request(options, (res) =\u003e {\r\n            console.log('Successfully connected to GitHub');\r\n            console.log('Using IP:', '20.205.243.166');\r\n            console.log('Status:', res.statusCode);\r\n            resolve(res);\r\n        });\r\n\r\n        req.on('error', (error) =\u003e {\r\n            console.error('Error:', error.message);\r\n            reject(error);\r\n        });\r\n\r\n        req.end();\r\n    });\r\n}\r\n\r\ntestConnection();\r\n```\r\n\r\nJust run this `node repro.js`\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nYou can repro it on node `v20+` it works on node `v18`\r\n\r\n### What is the expected behavior? Why is that the expected behavior?\r\n\r\n```\r\nSuccessfully connected to GitHub\r\nUsing IP: 20.205.243.166\r\nStatus: 200\r\n```\r\nThis is the expected behavior because we have defined a custom lookup method to resolve to this IP\r\n\r\n### What do you see instead?\r\n\r\n```\r\nError: Invalid IP address: undefined\r\nnode:internal/process/promises:391\r\n    triggerUncaughtException(err, true /* fromPromise */);\r\n    ^\r\n\r\nTypeError [ERR_INVALID_IP_ADDRESS]: Invalid IP address: undefined\r\n    at emitLookup (node:net:1465:17)\r\n    at customDNSLookup (C:\\Aivan\\PL\\repro.js:8:16)\r\n    at emitLookup (node:net:1414:5)\r\n    at defaultTriggerAsyncIdScope (node:internal/async_hooks:464:18)\r\n    at lookupAndConnectMultiple (node:net:1413:3)\r\n    at node:net:1359:7\r\n    at defaultTriggerAsyncIdScope (node:internal/async_hooks:464:18)\r\n    at lookupAndConnect (node:net:1358:5)\r\n    at Socket.connect (node:net:1255:5)\r\n    at Object.connect (node:_tls_wrap:1801:13) {\r\n  code: 'ERR_INVALID_IP_ADDRESS'\r\n}\r\n\r\nNode.js v20.16.0\r\n```\r\n\r\n### Additional information\r\n\r\nI am testing on the same machine, same code above. Just different nodejs\r\n","author":{"url":"https://github.com/geocine","@type":"Person","name":"geocine"},"datePublished":"2024-11-07T07:48:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/55762/node/issues/55762"}