René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Request signal isn't aborted after garbage collection","articleBody":"## Bug Description\r\n\r\nPassing a signal to Request() and aborting it does not cause the underlying request signal to be aborted after it's been garbage collected. This leads to issues where you want to listen on the request signal even after the request itself falls out of scope - e.g., the request is instantiated with an abort controller signal and downstream code is waiting for that signal to be aborted via `request.signal`.\r\n\r\n## Reproducible By\r\n\r\nRun the following using `node --expose-gc main.js`:\r\n\r\n```js\r\nconst ac = new AbortController();\r\n\r\nac.signal.addEventListener(\"abort\", () => {\r\n  console.log(\"ac signal aborted\");\r\n});\r\n\r\nconst request = new Request(\"https://google.ca\", { signal: ac.signal });\r\n\r\nrequest.signal.addEventListener(\"abort\", () => {\r\n  console.log(\"request signal aborted\");\r\n});\r\n\r\nsetTimeout(() => {\r\n  global.gc();\r\n  ac.abort();\r\n}, 0);\r\n```\r\n\r\n## Expected Behavior\r\n`ac signal aborted` **and** `request signal aborted` should be logged to the console.\r\n\r\nInstead, only `ac signal aborted` is logged.\r\n\r\n## Environment\r\n\r\nLatest node and undici. Tried it in some older versions as well.\r\n\r\n### Additional context\r\n\r\nA few folks are running into this while trying to close event stream requests in the remix web framework. The underlying requests are never closed because the signal doesn't get aborted.","author":{"url":"https://github.com/jvaill","@type":"Person","name":"jvaill"},"datePublished":"2024-09-25T21:48:01Z","url":"https://github.com/nodejs/node/issues/55428"}