René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Stream not destroyed when piped in Duplex.from() writable","articleBody":"### Version\n\nv22.9.0\n\n### Platform\n\n```text\nDarwin MBPM.local 24.0.0 Darwin Kernel Version 24.0.0: Mon Aug 12 20:52:31 PDT 2024; root:xnu-11215.1.10~2/RELEASE_ARM64_T6030 arm64\n```\n\n\n### Subsystem\n\nstream\n\n### What steps will reproduce the bug?\n\n```js\r\nconst { Duplex, Readable, pipeline } = require('node:stream')\r\n\r\npipeline(\r\n  Readable.from(\r\n    (async function* () {\r\n      try {\r\n        console.log('Readable stream started')\r\n        let i = 32\r\n        while (i-- > 0) {\r\n          yield Buffer.from('Hello, world!')\r\n          console.log('Readable stream resumed')\r\n        }\r\n        console.log('Readable stream ended')\r\n      } catch (err) {\r\n        console.log('Readable stream errored', err)\r\n      } finally {\r\n        console.log('Readable stream destroyed')\r\n      }\r\n    })(),\r\n    { objectMode: false, autoDestroy: true, highWaterMark: 1 }\r\n  ),\r\n  Duplex.from(async function (asyncGenerator) {\r\n    asyncGenerator.return()\r\n  }),\r\n  (err) => {\r\n    if (err) {\r\n      console.error('Pipeline failed', err)\r\n    } else {\r\n      console.log('Pipeline succeeded')\r\n    }\r\n  }\r\n)\r\n```\n\n### How often does it reproduce? Is there a required condition?\n\nAny code used as `Duplex.from(async function () {})` that does not fully consume the input will prevent the input stream to be properly disposed:\r\n\r\n```js\r\n  Duplex.from(async function (asyncGenerator) {\r\n    for await (const chunk of asyncGenerator) {\r\n      console.log('Writable stream received', chunk)\r\n      break\r\n    }\r\n  })\r\n```\r\n\r\n```js\r\n  Duplex.from(async function (asyncGenerator) {\r\n    asyncGenerator.retrun()\r\n  })\r\n```\r\n\r\n```js\r\n  Duplex.from(async function (asyncGenerator) {\r\n    // do nothing\r\n  })\r\n```\r\n\r\n\n\n### What is the expected behavior? Why is that the expected behavior?\n\nThe readable's destroy steps should be called.\n\n### What do you see instead?\n\nThe readable is not destroyed.\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/matthieusieben","@type":"Person","name":"matthieusieben"},"datePublished":"2024-09-23T09:39:29Z","url":"https://github.com/nodejs/node/issues/55077"}