Title: trace-atomics-wait doesn't propagate to workers when env is set · Issue #53374 · nodejs/node · GitHub
Open Graph Title: trace-atomics-wait doesn't propagate to workers when env is set · Issue #53374 · nodejs/node
X Title: trace-atomics-wait doesn't propagate to workers when env is set · Issue #53374 · nodejs/node
Description: Version 20.8.1 Platform Linux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr 3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Subsystem trace-atomics-wait What steps will reproduce the bug? You can reproduce this...
Open Graph Description: Version 20.8.1 Platform Linux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr 3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Subsystem trace-atomics-wait What steps will r...
X Description: Version 20.8.1 Platform Linux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr 3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Subsystem trace-atomics-wait What steps will r...
Opengraph URL: https://github.com/nodejs/node/issues/53374
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"trace-atomics-wait doesn't propagate to workers when env is set","articleBody":"### Version\n\n20.8.1\n\n### Platform\n\nLinux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr 3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux\n\n### Subsystem\n\ntrace-atomics-wait\n\n### What steps will reproduce the bug?\n\nYou can reproduce this by modifying one of the existent node tests.\r\n\r\nIf you edit `tests/parallel/test-trace-atomics-wait.js` in this repo with\r\n\r\n```diff\r\n-`, { eval: true, workerData: i32arr });\r\n+`, { eval: true, workerData: i32arr, env: process.env });\r\n```\r\n\r\nand then run \r\n\r\n```\r\nnode ./test/parallel/test-trace-atomics-wait.js\r\n```\r\n\r\nthe test will fail\n\n### How often does it reproduce? Is there a required condition?\n\nThis should reproduce 100% of the time -- you don't need to do anything special\n\n### What is the expected behavior? Why is that the expected behavior?\n\nAccording to https://nodejs.org/docs/latest-v20.x/api/worker_threads.html#new-workerfilename-options, the default value for a worker thread's env is process.env. Thus, not passing an environment and passing process.env as the environment should always produce the same behavior.\n\n### What do you see instead?\n\nWhen running in its original form, the test produces two profile files, as intended. When passing {env: process.env} into the worker invocation, however, it only produces one profile file.\n\n### Additional information\n\nThis may be a dup of https://github.com/nodejs/node/issues/52825, but given that it's a different flag, the fix might be slightly different, so I figured I should bring it to your attention","author":{"url":"https://github.com/orinatic","@type":"Person","name":"orinatic"},"datePublished":"2024-06-06T19:20:57Z","url":"https://github.com/nodejs/node/issues/53374"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d6dc8fed-b5e4-64ad-f72d-86b7840ca586 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E25A:1E2715:AB3AF8:DE8C42:6AED4213 |
| html-safe-nonce | 02cd1f05ea7b36470420454b6e481d41b6dab367b66ac216e0d6d73c12facda8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjVBOjFFMjcxNTpBQjNBRjg6REU4QzQyOjZBRUQ0MjEzIiwidmlzaXRvcl9pZCI6Ijk4NjA0MjU1MzU2OTQ2MDc1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 85c2050112ddf0dcd9547731ceee5c86b6a06832ff4d5e3aed869b6dc7185818 |
| hovercard-subject-tag | issue:2338999012 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/53374/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e0b41d03113fdf2b10567d0cb53a4e5db1e3912b3c95e0d1b9def980d890c0d3/nodejs/node/issues/53374 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e0b41d03113fdf2b10567d0cb53a4e5db1e3912b3c95e0d1b9def980d890c0d3/nodejs/node/issues/53374 |
| og:image:alt | Version 20.8.1 Platform Linux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr 3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Subsystem trace-atomics-wait What steps will r... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | orinatic |
| hostname | github.com |
| expected-hostname | github.com |
| None | 26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c629ad99c254d306375fc8354d04321c2c362236 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width