René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[REG 20.9-\u003e20.10] stream: Pipe is stopped after error on another pipe from the same source","articleBody":"### Version\r\n\r\n20.13.1\r\n\r\n### Platform\r\n\r\nMicrosoft Windows NT 10.0.19045.0 x64\r\n\r\n### Subsystem\r\n\r\nstream\r\n\r\n### What steps will reproduce the bug?\r\n\r\n```js\r\nimport assert from 'assert';\r\nimport stream from 'stream';\r\n\r\nclass SizeCounter extends stream.Writable {\r\n  constructor(name, fail) {\r\n    super();\r\n    this.totalSize = 0;\r\n    this.name = name;\r\n    this.fail = fail;\r\n  }\r\n\r\n  _write(chunk, _encoding, callback) {\r\n    this.totalSize += chunk.length;\r\n    console.log(this.name, this.totalSize);\r\n    if (this.fail)\r\n      return callback(new Error('You asked me to fail'));\r\n    return callback();\r\n  }\r\n\r\n  _final(callback) {\r\n    console.log(`${this.name} Total size: ${this.totalSize}`);\r\n    callback();\r\n  }\r\n}\r\n\r\nconst src = new stream.PassThrough();\r\nconst dst1 = new SizeCounter('1', true);\r\nconst dst2 = new SizeCounter('2', false);\r\n\r\nsrc.write(Buffer.alloc(20000));\r\nsrc.write(Buffer.alloc(20000));\r\nsrc.end();\r\n\r\ndst1.on('error', () =\u003e {\r\n  // uncomment as a workaround\r\n  // src.resume();\r\n});\r\n\r\nstream.finished(src, () =\u003e console.log('src ended'));\r\nstream.finished(dst1, (err) =\u003e console.log('dst1 ended', err?.message));\r\nstream.finished(dst2, (err) =\u003e console.log('dst2 ended', err?.message));\r\n\r\nsrc.pipe(dst1, { end: true });\r\nsrc.pipe(dst2, { end: true });\r\nsetImmediate(() =\u003e assert.strictEqual(dst2.totalSize, 40000));\r\n```\r\n\r\nOutput with 20.9.0:\r\n```\r\n1 20000\r\n2 20000\r\ndst1 ended You asked me to fail\r\n2 40000\r\n2 Total size: 40000\r\nsrc ended\r\ndst2 ended undefined\r\n```\r\n\r\nOutput with 20.10.0:\r\n```\r\n1 20000\r\n2 20000\r\ndst1 ended You asked me to fail\r\nnode:assert:125\r\n  throw new AssertionError(obj);\r\n  ^\r\n\r\nAssertionError [ERR_ASSERTION]: Expected values to be strictly equal:\r\n\r\n20000 !== 40000\r\n\r\n    at Immediate._onImmediate (file:///home/orgads/test/test.mjs:45:27)\r\n    at process.processImmediate (node:internal/timers:478:21) {\r\n  generatedMessage: true,\r\n  code: 'ERR_ASSERTION',\r\n  actual: 20000,\r\n  expected: 40000,\r\n  operator: 'strictEqual'\r\n}\r\n\r\nNode.js v20.10.0\r\n```\r\n\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nAlways\r\n\r\n### What is the expected behavior? Why is that the expected behavior?\r\n\r\nI expect the stream to keep draining (at least when it still has listeners to `data`).\r\n\r\n### What do you see instead?\r\n\r\nThe stream is paused.\r\n\r\n### Additional information\r\n\r\nBisected to #50014.\r\n\r\nRelated bug:\r\n- #51930","author":{"url":"https://github.com/orgads","@type":"Person","name":"orgads"},"datePublished":"2024-05-28T14:40:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/53185/node/issues/53185"}