René's URL Explorer Experiment


Title: Module Hooks cannot be registered from worker thread in 22.2.0+ · Issue #53182 · nodejs/node · GitHub

Open Graph Title: Module Hooks cannot be registered from worker thread in 22.2.0+ · Issue #53182 · nodejs/node

X Title: Module Hooks cannot be registered from worker thread in 22.2.0+ · Issue #53182 · nodejs/node

Description: Version v22.2.0 Platform Darwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64 Subsystem module What steps will reproduce the bug? Create the following fil...

Open Graph Description: Version v22.2.0 Platform Darwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64 Subsystem module What steps will rep...

X Description: Version v22.2.0 Platform Darwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64 Subsystem module What steps will rep...

Opengraph URL: https://github.com/nodejs/node/issues/53182

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Module Hooks cannot be registered from worker thread in 22.2.0+","articleBody":"### Version\r\n\r\nv22.2.0\r\n\r\n### Platform\r\n\r\nDarwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64\r\n\r\n### Subsystem\r\n\r\nmodule\r\n\r\n### What steps will reproduce the bug?\r\n\r\nCreate the following files:\r\n\r\n`index.js`\r\n```js\r\nconst { Worker } = require(\"worker_threads\");\r\n\r\nnew Worker(\"./lib/child.js\", {\r\n  execArgv: [\"--import\", \"./lib/register.js\"],\r\n});\r\n\r\n```\r\n\r\n`lib/register.js`\r\n\r\n```js\r\nconst { register } = require(\"node:module\");\r\nconst { pathToFileURL } = require(\"node:url\");\r\n\r\nregister(\"./hooks.mjs\", pathToFileURL(__filename));\r\n```\r\n\r\nThen execute: `node index.js`\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nAlways.\r\n\r\n### What is the expected behavior? Why is that the expected behavior?\r\n\r\nThe worker thread should start with the hooks register successfully.\r\n\r\n### What do you see instead?\r\n\r\nThe process hangs.\r\nRemoving the `register` call will solve the problem.\r\n\r\n### Additional information\r\n\r\nThis problem happens due to #52706, as already triaged in #53097.\r\n\r\nAn additional problem is that the suggested workaround forces people to use `node --import register.js` in order to solve the problem as the module thread is shared with Workers. \r\nWhile this is fine, there might be situation in which users cannot use `--import` (or `--require`). \r\nIn those situation I have observed the `register` call will successfully work for subsequent dynamic `import()` call but **NOT** for `require()` (unless I missed something obvious).\r\n\r\nI created https://github.com/ShogunPanda/hooks-repro to reproduce this.","author":{"url":"https://github.com/ShogunPanda","@type":"Person","name":"ShogunPanda"},"datePublished":"2024-05-28T08:29:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":21},"url":"https://github.com/53182/node/issues/53182"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:492aa252-55cd-b330-6e9d-2cbf68877376
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEA36:B008A:F6C9F2:152B2DA:6A4DD812
html-safe-nonceef7e3dc080d72ce33b269f5072357b9d8fff7be2cff934d6edb4b386c6c67f42
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTM2OkIwMDhBOkY2QzlGMjoxNTJCMkRBOjZBNEREODEyIiwidmlzaXRvcl9pZCI6IjI5NDc1ODM2MzE1Mjg5ODA2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac81304a942dcd74cc155ad47235421484754ffa29ec61ae5787ee6974452f4ad1
hovercard-subject-tagissue:2320452188
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/53182/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a716e9459cdc9e445b1f7d5c7ebe6dfd17cc6607c0616604277d0144cea3b307/nodejs/node/issues/53182
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a716e9459cdc9e445b1f7d5c7ebe6dfd17cc6607c0616604277d0144cea3b307/nodejs/node/issues/53182
og:image:altVersion v22.2.0 Platform Darwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64 Subsystem module What steps will rep...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameShogunPanda
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/issues/53182#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F53182
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F53182
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/53182
Reloadhttps://github.com/nodejs/node/issues/53182
Reloadhttps://github.com/nodejs/node/issues/53182
Please reload this pagehttps://github.com/nodejs/node/issues/53182
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/issues/53182
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Module Hooks cannot be registered from worker thread in 22.2.0+https://github.com/nodejs/node/issues/53182#top
loadersIssues and PRs related to ES module loadershttps://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22loaders%22
moduleIssues and PRs related to the module subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22module%22
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
on May 28, 2024https://github.com/nodejs/node/issues/53182#issue-2320452188
#52706https://github.com/nodejs/node/pull/52706
#53097https://github.com/nodejs/node/issues/53097
https://github.com/ShogunPanda/hooks-reprohttps://github.com/ShogunPanda/hooks-repro
loadersIssues and PRs related to ES module loadershttps://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22loaders%22
moduleIssues and PRs related to the module subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22module%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.