Title: Module Hooks cannot be registered from worker thread in 22.2.0+ · Issue #53182 · nodejs/node · GitHub
Open Graph Title: Module Hooks cannot be registered from worker thread in 22.2.0+ · Issue #53182 · nodejs/node
X Title: Module Hooks cannot be registered from worker thread in 22.2.0+ · Issue #53182 · nodejs/node
Description: Version v22.2.0 Platform Darwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64 Subsystem module What steps will reproduce the bug? Create the following fil...
Open Graph Description: Version v22.2.0 Platform Darwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64 Subsystem module What steps will rep...
X Description: Version v22.2.0 Platform Darwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64 Subsystem module What steps will rep...
Opengraph URL: https://github.com/nodejs/node/issues/53182
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Module Hooks cannot be registered from worker thread in 22.2.0+","articleBody":"### Version\r\n\r\nv22.2.0\r\n\r\n### Platform\r\n\r\nDarwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64\r\n\r\n### Subsystem\r\n\r\nmodule\r\n\r\n### What steps will reproduce the bug?\r\n\r\nCreate the following files:\r\n\r\n`index.js`\r\n```js\r\nconst { Worker } = require(\"worker_threads\");\r\n\r\nnew Worker(\"./lib/child.js\", {\r\n execArgv: [\"--import\", \"./lib/register.js\"],\r\n});\r\n\r\n```\r\n\r\n`lib/register.js`\r\n\r\n```js\r\nconst { register } = require(\"node:module\");\r\nconst { pathToFileURL } = require(\"node:url\");\r\n\r\nregister(\"./hooks.mjs\", pathToFileURL(__filename));\r\n```\r\n\r\nThen execute: `node index.js`\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nAlways.\r\n\r\n### What is the expected behavior? Why is that the expected behavior?\r\n\r\nThe worker thread should start with the hooks register successfully.\r\n\r\n### What do you see instead?\r\n\r\nThe process hangs.\r\nRemoving the `register` call will solve the problem.\r\n\r\n### Additional information\r\n\r\nThis problem happens due to #52706, as already triaged in #53097.\r\n\r\nAn additional problem is that the suggested workaround forces people to use `node --import register.js` in order to solve the problem as the module thread is shared with Workers. \r\nWhile this is fine, there might be situation in which users cannot use `--import` (or `--require`). \r\nIn those situation I have observed the `register` call will successfully work for subsequent dynamic `import()` call but **NOT** for `require()` (unless I missed something obvious).\r\n\r\nI created https://github.com/ShogunPanda/hooks-repro to reproduce this.","author":{"url":"https://github.com/ShogunPanda","@type":"Person","name":"ShogunPanda"},"datePublished":"2024-05-28T08:29:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":21},"url":"https://github.com/53182/node/issues/53182"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:492aa252-55cd-b330-6e9d-2cbf68877376 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EA36:B008A:F6C9F2:152B2DA:6A4DD812 |
| html-safe-nonce | ef7e3dc080d72ce33b269f5072357b9d8fff7be2cff934d6edb4b386c6c67f42 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTM2OkIwMDhBOkY2QzlGMjoxNTJCMkRBOjZBNEREODEyIiwidmlzaXRvcl9pZCI6IjI5NDc1ODM2MzE1Mjg5ODA2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 81304a942dcd74cc155ad47235421484754ffa29ec61ae5787ee6974452f4ad1 |
| hovercard-subject-tag | issue:2320452188 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/53182/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a716e9459cdc9e445b1f7d5c7ebe6dfd17cc6607c0616604277d0144cea3b307/nodejs/node/issues/53182 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a716e9459cdc9e445b1f7d5c7ebe6dfd17cc6607c0616604277d0144cea3b307/nodejs/node/issues/53182 |
| og:image:alt | Version v22.2.0 Platform Darwin panda.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64 Subsystem module What steps will rep... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ShogunPanda |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width