Title: possible mistaken commit in v20.x branch webstreams · Issue #53143 · nodejs/node · GitHub
Open Graph Title: possible mistaken commit in v20.x branch webstreams · Issue #53143 · nodejs/node
X Title: possible mistaken commit in v20.x branch webstreams · Issue #53143 · nodejs/node
Description: Version version 20.13.0 and higher Platform all Subsystem webstreams What steps will reproduce the bug? No response How often does it reproduce? Is there a required condition? No response What is the expected behavior? Why is that the ex...
Open Graph Description: Version version 20.13.0 and higher Platform all Subsystem webstreams What steps will reproduce the bug? No response How often does it reproduce? Is there a required condition? No response What is t...
X Description: Version version 20.13.0 and higher Platform all Subsystem webstreams What steps will reproduce the bug? No response How often does it reproduce? Is there a required condition? No response What is t...
Opengraph URL: https://github.com/nodejs/node/issues/53143
X: @github
Domain: github.com
IPv4 address: 140.82.114.4
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"possible mistaken commit in v20.x branch webstreams","articleBody":"### Version\n\nversion 20.13.0 and higher\n\n### Platform\n\nall\n\n### Subsystem\n\nwebstreams\n\n### What steps will reproduce the bug?\n\n_No response_\n\n### How often does it reproduce? Is there a required condition?\n\n_No response_\n\n### What is the expected behavior? Why is that the expected behavior?\n\n_No response_\n\n### What do you see instead?\n\nI was curious about the freshness of the webstreams code in v20 versus main, so I looked at the commit history of the following folder:\r\n\r\nhttps://github.com/nodejs/node/tree/main/lib/internal/webstreams\r\n\r\nI noticed something odd about the following commits:\r\n\r\nhttps://github.com/nodejs/node/commit/4d3923aabaa6d57dc9dc3c554434fa69410c3d55\r\nhttps://github.com/nodejs/node/commit/8e8245196af17b32ae417f3d3eb72ed6527c6872\r\nhttps://github.com/nodejs/node/commit/66556f53a7b36384bce305865c30ca43eaa0874b\r\n\r\nIt appears there was an initial fix attempt that had some problem, then a revert, and finally a correct fix. These three commits seem identical in main branch and v22.x branch, while v21.x branch includes three equivalent commits in the same chronological order on slightly different dates. However v20.x branch looks different.\r\n\r\nhttps://github.com/nodejs/node/tree/v20.x/lib/internal/webstreams\r\n\r\nIt appears the broken initial fix attempt never made it into v20.x branch in the first place. The first relevant commit seems to be the final correct fix. However a little over a month later, the older revert commit seems to have been applied over top of the correct fix. I'm guessing this was an accidental mistake?\r\n\r\nIf so, it looks like the mistaken revert modified a couple of test files, and also incorrectly removed a couple of \"port.unref();\" lines from the \"transfer.js\" file. If the commit notes listed in CHANGELOG_V20.md are correct, this presumably broken transfer.js file shipped in Node version 20.13.0, and is still broken in the current v20.14.0-proposal branch scheduled to ship this coming Tuesday 2024-05-28.\r\n\r\nhttps://github.com/nodejs/node/tree/v20.14.0-proposal/lib/internal/webstreams\r\n\r\nI don't know anything about the specifics of any of this stuff, so hopefully I'm not wasting someone's time by writing this. However it looks fishy enough to me that I thought it was worth reporting.\r\n\r\nThanks for your time.\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/Waldenesque","@type":"Person","name":"Waldenesque"},"datePublished":"2024-05-24T20:00:44Z","url":"https://github.com/nodejs/node/issues/53143"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:326bab1e-1aa5-9c57-2125-d98f19e89c37 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8E46:126B05:670C65:826ACD:6B03542B |
| html-safe-nonce | 7e04abbeea2ea8ddb6dd825f79de51816ac8f4f922f8b7e0dc01a00ac2abd972 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTQ2OjEyNkIwNTo2NzBDNjU6ODI2QUNEOjZCMDM1NDJCIiwidmlzaXRvcl9pZCI6Ijg0MjY1MTk2NzgxMTcxNzIyNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e7532b1d2138943b8a922c2471465f55aac5d68dd6166f41987cc9909f66da5a |
| hovercard-subject-tag | issue:2316173314 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/53143/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e74c5b3bb416cc8aac77623e343d5279e1888c4fe4c49e4f611712d0fab7307d/nodejs/node/issues/53143 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e74c5b3bb416cc8aac77623e343d5279e1888c4fe4c49e4f611712d0fab7307d/nodejs/node/issues/53143 |
| og:image:alt | Version version 20.13.0 and higher Platform all Subsystem webstreams What steps will reproduce the bug? No response How often does it reproduce? Is there a required condition? No response What is t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Waldenesque |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | max-age=0, private, must-revalidate |
Viewport: width=device-width