René's URL Explorer Experiment


Title: possible mistaken commit in v20.x branch webstreams · Issue #53143 · nodejs/node · GitHub

Open Graph Title: possible mistaken commit in v20.x branch webstreams · Issue #53143 · nodejs/node

X Title: possible mistaken commit in v20.x branch webstreams · Issue #53143 · nodejs/node

Description: Version version 20.13.0 and higher Platform all Subsystem webstreams What steps will reproduce the bug? No response How often does it reproduce? Is there a required condition? No response What is the expected behavior? Why is that the ex...

Open Graph Description: Version version 20.13.0 and higher Platform all Subsystem webstreams What steps will reproduce the bug? No response How often does it reproduce? Is there a required condition? No response What is t...

X Description: Version version 20.13.0 and higher Platform all Subsystem webstreams What steps will reproduce the bug? No response How often does it reproduce? Is there a required condition? No response What is t...

Opengraph URL: https://github.com/nodejs/node/issues/53143

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"possible mistaken commit in v20.x branch webstreams","articleBody":"### Version\n\nversion 20.13.0 and higher\n\n### Platform\n\nall\n\n### Subsystem\n\nwebstreams\n\n### What steps will reproduce the bug?\n\n_No response_\n\n### How often does it reproduce? Is there a required condition?\n\n_No response_\n\n### What is the expected behavior? Why is that the expected behavior?\n\n_No response_\n\n### What do you see instead?\n\nI was curious about the freshness of the webstreams code in v20 versus main, so I looked at the commit history of the following folder:\r\n\r\nhttps://github.com/nodejs/node/tree/main/lib/internal/webstreams\r\n\r\nI noticed something odd about the following commits:\r\n\r\nhttps://github.com/nodejs/node/commit/4d3923aabaa6d57dc9dc3c554434fa69410c3d55\r\nhttps://github.com/nodejs/node/commit/8e8245196af17b32ae417f3d3eb72ed6527c6872\r\nhttps://github.com/nodejs/node/commit/66556f53a7b36384bce305865c30ca43eaa0874b\r\n\r\nIt appears there was an initial fix attempt that had some problem, then a revert, and finally a correct fix. These three commits seem identical in main branch and v22.x branch, while v21.x branch includes three equivalent commits in the same chronological order on slightly different dates. However v20.x branch looks different.\r\n\r\nhttps://github.com/nodejs/node/tree/v20.x/lib/internal/webstreams\r\n\r\nIt appears the broken initial fix attempt never made it into v20.x branch in the first place. The first relevant commit seems to be the final correct fix. However a little over a month later, the older revert commit seems to have been applied over top of the correct fix. I'm guessing this was an accidental mistake?\r\n\r\nIf so, it looks like the mistaken revert modified a couple of test files, and also incorrectly removed a couple of \"port.unref();\" lines from the \"transfer.js\" file. If the commit notes listed in CHANGELOG_V20.md are correct, this presumably broken transfer.js file shipped in Node version 20.13.0, and is still broken in the current v20.14.0-proposal branch scheduled to ship this coming Tuesday 2024-05-28.\r\n\r\nhttps://github.com/nodejs/node/tree/v20.14.0-proposal/lib/internal/webstreams\r\n\r\nI don't know anything about the specifics of any of this stuff, so hopefully I'm not wasting someone's time by writing this. However it looks fishy enough to me that I thought it was worth reporting.\r\n\r\nThanks for your time.\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/Waldenesque","@type":"Person","name":"Waldenesque"},"datePublished":"2024-05-24T20:00:44Z","url":"https://github.com/nodejs/node/issues/53143"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:326bab1e-1aa5-9c57-2125-d98f19e89c37
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8E46:126B05:670C65:826ACD:6B03542B
html-safe-nonce7e04abbeea2ea8ddb6dd825f79de51816ac8f4f922f8b7e0dc01a00ac2abd972
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTQ2OjEyNkIwNTo2NzBDNjU6ODI2QUNEOjZCMDM1NDJCIiwidmlzaXRvcl9pZCI6Ijg0MjY1MTk2NzgxMTcxNzIyNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace7532b1d2138943b8a922c2471465f55aac5d68dd6166f41987cc9909f66da5a
hovercard-subject-tagissue:2316173314
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/53143/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e74c5b3bb416cc8aac77623e343d5279e1888c4fe4c49e4f611712d0fab7307d/nodejs/node/issues/53143
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e74c5b3bb416cc8aac77623e343d5279e1888c4fe4c49e4f611712d0fab7307d/nodejs/node/issues/53143
og:image:altVersion version 20.13.0 and higher Platform all Subsystem webstreams What steps will reproduce the bug? No response How often does it reproduce? Is there a required condition? No response What is t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameWaldenesque
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/53143#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F53143
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F53143
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/53143
Reloadhttps://github.com/nodejs/node/issues/53143
Reloadhttps://github.com/nodejs/node/issues/53143
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/53143
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/53143
possible mistaken commit in v20.x branch webstreamshttps://github.com/nodejs/node/issues/53143#top
web streamsIssues and PRs related to the Web Streams API.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22web%20streams%22
https://github.com/Waldenesque
Waldenesquehttps://github.com/Waldenesque
on May 24, 2024https://github.com/nodejs/node/issues/53143#issue-2316173314
https://github.com/nodejs/node/tree/main/lib/internal/webstreamshttps://github.com/nodejs/node/tree/main/lib/internal/webstreams
4d3923ahttps://github.com/nodejs/node/commit/4d3923aabaa6d57dc9dc3c554434fa69410c3d55
8e82451https://github.com/nodejs/node/commit/8e8245196af17b32ae417f3d3eb72ed6527c6872
66556f5https://github.com/nodejs/node/commit/66556f53a7b36384bce305865c30ca43eaa0874b
https://github.com/nodejs/node/tree/v20.x/lib/internal/webstreamshttps://github.com/nodejs/node/tree/v20.x/lib/internal/webstreams
https://github.com/nodejs/node/tree/v20.14.0-proposal/lib/internal/webstreamshttps://github.com/nodejs/node/tree/v20.14.0-proposal/lib/internal/webstreams
avivkellerhttps://github.com/avivkeller
web streamsIssues and PRs related to the Web Streams API.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22web%20streams%22
on May 24, 2024https://github.com/nodejs/node/issues/53143#event-12930029787
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
on May 24, 2024https://github.com/nodejs/node/issues/53143#issuecomment-2130432369
@tsctxhttps://github.com/tsctx
@mcollinahttps://github.com/mcollina
@jasnellhttps://github.com/jasnell
https://github.com/climba03003
climba03003https://github.com/climba03003
on May 25, 2024https://github.com/nodejs/node/issues/53143#issuecomment-2130751283
f2dfe0fa80https://github.com/nodejs/node/commit/f2dfe0fa80
8d20b641a2https://github.com/nodejs/node/commit/8d20b641a2
d0a6f35https://github.com/nodejs/node/commit/d0a6f3515d6c7d5163f01ae86eb99c294dca5853
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
on May 25, 2024https://github.com/nodejs/node/issues/53143#issuecomment-2130830765
8d20b641a2https://github.com/nodejs/node/commit/8d20b641a2
#53144https://github.com/nodejs/node/pull/53144
marco-ippolitohttps://github.com/marco-ippolito
on May 27, 2024https://github.com/nodejs/node/issues/53143#event-12949390011
Revert "stream: revert fix cloned webstreams not being unref'd"https://github.com/nodejs/node/commit/cffd2cc0c9ed7fbdb335d576c660316176511f4e
cffd2cchttps://github.com/nodejs/node/commit/cffd2cc0c9ed7fbdb335d576c660316176511f4e
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
on May 29, 2024https://github.com/nodejs/node/issues/53143#issuecomment-2137196724
marco-ippolitohttps://github.com/marco-ippolito
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 29, 2024https://github.com/nodejs/node/issues/53143#event-12970411358
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/53143
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/53143
web streamsIssues and PRs related to the Web Streams API.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22web%20streams%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.