René's URL Explorer Experiment


Title: cpu-prof doesn't propagate to workers when env is set · Issue #52825 · nodejs/node · GitHub

Open Graph Title: cpu-prof doesn't propagate to workers when env is set · Issue #52825 · nodejs/node

X Title: cpu-prof doesn't propagate to workers when env is set · Issue #52825 · nodejs/node

Description: Version 20.8.1 Platform Linux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr 3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Subsystem cpu-prof What steps will reproduce the bug? You can reproduce this by modify...

Open Graph Description: Version 20.8.1 Platform Linux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr 3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Subsystem cpu-prof What steps will reproduce t...

X Description: Version 20.8.1 Platform Linux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr 3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Subsystem cpu-prof What steps will reproduce t...

Opengraph URL: https://github.com/nodejs/node/issues/52825

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"cpu-prof doesn't propagate to workers when env is set ","articleBody":"### Version\n\n20.8.1\n\n### Platform\n\nLinux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr  3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux\n\n### Subsystem\n\ncpu-prof\n\n### What steps will reproduce the bug?\n\nYou can reproduce this by modifying one of the existent node tests. \r\n\r\nIf you edit `tests/fixtures/workload/fibonacci-worker.js` in this repo with\r\n\r\n```diff\r\n-new Worker(path.join(__dirname, 'fibonacci.js'));\r\n+new Worker(path.join(__dirname, 'fibonacci.js'), {env: process.env});\r\n```\r\n\r\nand then run \r\n```\r\nnode ./test/sequential/test-cpu-prof-dir-worker.js\r\n```\r\n\r\nthe new test will fail\n\n### How often does it reproduce? Is there a required condition?\n\nThis should reproduce 100% of the time -- you don't need to do anything special\n\n### What is the expected behavior? Why is that the expected behavior?\n\nAccording to https://nodejs.org/docs/latest-v20.x/api/worker_threads.html#new-workerfilename-options, the default value for a worker thread's env is process.env. Thus, not passing an environment and passing process.env as the environment should always produce the same behavior. \n\n### What do you see instead?\n\nWhen running in its original form, the test produces two profile files, as intended. When passing `{env: process.env}` into the worker invocation, however, it only produces one profile file. \n\n### Additional information\n\nIf I print the environment in the worker thread, it appears to be identical in both cases. It doesn't seem like the problem is that part of the environment is getting lost, but rather there's some hidden variable that isn't getting propagated","author":{"url":"https://github.com/orinatic","@type":"Person","name":"orinatic"},"datePublished":"2024-05-03T16:05:43Z","url":"https://github.com/nodejs/node/issues/52825"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:79472fda-aa58-976b-9871-b0710095f8d1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB994:20C6D9:8668D9:B2C445:6AED29E8
html-safe-noncebd66174142c21846a3b74922b5d83568c9113d6b578901e9a8685c507cfd127c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTk0OjIwQzZEOTo4NjY4RDk6QjJDNDQ1OjZBRUQyOUU4IiwidmlzaXRvcl9pZCI6IjM4MjA4MTE1NzEyNjQ1NjM2ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace98783cfe22d914ffcbe9744b53ee1fd8a4c30707390ba8f7d2f030f04d850f8
hovercard-subject-tagissue:2277987191
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/52825/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ac6a680df945e38ce9b750a00bfadca051bd5b4080a212623d7f7b09d195469b/nodejs/node/issues/52825
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ac6a680df945e38ce9b750a00bfadca051bd5b4080a212623d7f7b09d195469b/nodejs/node/issues/52825
og:image:altVersion 20.8.1 Platform Linux ushanka-housing 6.5.0-1020-oem #21-Ubuntu SMP PREEMPT_DYNAMIC Wed Apr 3 14:54:32 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Subsystem cpu-prof What steps will reproduce t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameorinatic
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/52825#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F52825
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F52825
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/52825
Reloadhttps://github.com/nodejs/node/issues/52825
Reloadhttps://github.com/nodejs/node/issues/52825
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/52825
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/52825
#52827https://github.com/nodejs/node/pull/52827
cpu-prof doesn't propagate to workers when env is set https://github.com/nodejs/node/issues/52825#top
#52827https://github.com/nodejs/node/pull/52827
confirmed-bugIssues and PRs for confirmed bugs.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22confirmed-bug%22
lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
workerIssues and PRs related to the worker_threads module and Worker API.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22worker%22
https://github.com/orinatic
orinatichttps://github.com/orinatic
on May 3, 2024https://github.com/nodejs/node/issues/52825#issue-2277987191
#21https://github.com/nodejs/node/pull/21
https://nodejs.org/docs/latest-v20.x/api/worker_threads.html#new-workerfilename-optionshttps://nodejs.org/docs/latest-v20.x/api/worker_threads.html#new-workerfilename-options
avivkellerhttps://github.com/avivkeller
workerIssues and PRs related to the worker_threads module and Worker API.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22worker%22
confirmed-bugIssues and PRs for confirmed bugs.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22confirmed-bug%22
on May 3, 2024https://github.com/nodejs/node/issues/52825#event-12702196159
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
on May 4, 2024https://github.com/nodejs/node/issues/52825#issuecomment-2093898804
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
on May 4, 2024https://github.com/nodejs/node/issues/52825#issuecomment-2093901706
avivkellerhttps://github.com/avivkeller
lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
on May 4, 2024https://github.com/nodejs/node/issues/52825#event-12702511336
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
on May 4, 2024https://github.com/nodejs/node/issues/52825#issuecomment-2093934153
https://github.com/nodejs/node/blob/71a1fa3043d495dfaa2105d07cd090c51bcd8eed/src/node_worker.cchttps://github.com/nodejs/node/blob/71a1fa3043d495dfaa2105d07cd090c51bcd8eed/src/node_worker.cc
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
on May 4, 2024https://github.com/nodejs/node/issues/52825#issuecomment-2093934249
https://github.com/theanarkh
theanarkhhttps://github.com/theanarkh
on May 4, 2024https://github.com/nodejs/node/issues/52825#issuecomment-2094011175
herehttps://github.com/nodejs/node/blob/71a1fa3043d495dfaa2105d07cd090c51bcd8eed/src/node_worker.cc#L536
aduh95https://github.com/aduh95
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#52827https://github.com/nodejs/node/pull/52827
on May 12, 2024https://github.com/nodejs/node/issues/52825#event-12777936426
aduh95https://github.com/aduh95
on May 12, 2024https://github.com/nodejs/node/issues/52825#event-12777936447
src: make sure pass the `argv` to worker threadshttps://github.com/nodejs/node/commit/aba4a00c8d20135ad8d071991bd8bff06d4e136c
aba4a00https://github.com/nodejs/node/commit/aba4a00c8d20135ad8d071991bd8bff06d4e136c
targoshttps://github.com/targos
on May 12, 2024https://github.com/nodejs/node/issues/52825#event-12779258156
src: make sure pass the `argv` to worker threadshttps://github.com/nodejs/node/commit/ace65a9aac508aa34f76ea21b8f551a62738034c
ace65a9https://github.com/nodejs/node/commit/ace65a9aac508aa34f76ea21b8f551a62738034c
soophoohttps://github.com/soophoo
on Jun 20, 2024https://github.com/nodejs/node/issues/52825#event-13234957013
src: make sure pass the `argv` to worker threadshttps://github.com/soophoo/node/commit/ec14ab5cc6b5b589394dabe51b263fec01dd225c
ec14ab5https://github.com/soophoo/node/commit/ec14ab5cc6b5b589394dabe51b263fec01dd225c
targoshttps://github.com/targos
on Sep 21, 2024https://github.com/nodejs/node/issues/52825#event-14349101806
src: make sure pass the `argv` to worker threadshttps://github.com/nodejs/node/commit/21776a34b5b6c2b88fade401d86c32ffb90f7332
21776a3https://github.com/nodejs/node/commit/21776a34b5b6c2b88fade401d86c32ffb90f7332
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/52825
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/52825
confirmed-bugIssues and PRs for confirmed bugs.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22confirmed-bug%22
lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
workerIssues and PRs related to the worker_threads module and Worker API.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22worker%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.