René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ContextifyContext::PropertyDefinerCallback() never intercepts the request","articleBody":"### Version\r\n\r\nv22.0.0-pre\r\n\r\n### Platform\r\n\r\n_No response_\r\n\r\n### Subsystem\r\n\r\n_No response_\r\n\r\n### What steps will reproduce the bug?\r\n\r\nWhile migrating Node-ci to a new V8 interceptors Api (https://crrev.com/c/5353146, https://github.com/v8/node/pull/180) I noticed that `ContextifyContext::PropertyDefinerCallback()` never reports that it has intercepted the request.\r\nIt should have called `args.GetReturnValue()-\u003eSetUndefined();` in `define_prop_on_sandbox` instead.\r\n\r\nFixing this issue exposes another one - `ContextifyContext::PropertyEnumeratorCallback()` never returns symbol properties because `ctx-\u003esandbox()-\u003eGetPropertyNames(ctx-\u003econtext())` skips symbols. There's a `GetPropertyNames()` overload with a `PropertyFilter` parameter which can be configured to not skip symbols.\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\n_No response_\r\n\r\n### What is the expected behavior? Why is that the expected behavior?\r\n\r\n_No response_\r\n\r\n### What do you see instead?\r\n\r\nn/a\r\n\r\n### Additional information\r\n\r\n_No response_","author":{"url":"https://github.com/isheludko","@type":"Person","name":"isheludko"},"datePublished":"2024-04-22T11:03:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/52634/node/issues/52634"}