René's URL Explorer Experiment


Title: Misplaced/dead Windows code in `node.cc`? · Issue #52404 · nodejs/node · GitHub

Open Graph Title: Misplaced/dead Windows code in `node.cc`? · Issue #52404 · nodejs/node

X Title: Misplaced/dead Windows code in `node.cc`? · Issue #52404 · nodejs/node

Description: In node/src/node.cc Lines 633 to 640 in 756acd0 #if NODE_USE_V8_WASM_TRAP_HANDLER #if defined(_WIN32) { constexpr ULONG first = TRUE; per_process::old_vectored_exception_handler = AddVectoredExceptionHandler(first, TrapWebAssemblyOrConti...

Open Graph Description: In node/src/node.cc Lines 633 to 640 in 756acd0 #if NODE_USE_V8_WASM_TRAP_HANDLER #if defined(_WIN32) { constexpr ULONG first = TRUE; per_process::old_vectored_exception_handler = AddVectoredExcept...

X Description: In node/src/node.cc Lines 633 to 640 in 756acd0 #if NODE_USE_V8_WASM_TRAP_HANDLER #if defined(_WIN32) { constexpr ULONG first = TRUE; per_process::old_vectored_exception_handler = AddVectoredExcept...

Opengraph URL: https://github.com/nodejs/node/issues/52404

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.3


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Misplaced/dead Windows code in `node.cc`?","articleBody":"In https://github.com/nodejs/node/blob/756acd087742939873555ca397f7b33e0db8a9ae/src/node.cc#L633-L640, we have Windows-specific code.\r\nThe problem is that this code is inside a `#ifdef __POSIX__` section: \r\nhttps://github.com/nodejs/node/blob/756acd087742939873555ca397f7b33e0db8a9ae/src/node.cc#L553\r\n\r\nThis seems to be unexpected dead code for Windows.\r\nI found this from a compiler warning: `src\\node.cc(428,13): warning : unused function 'TrapWebAssemblyOrContinue' [-Wunused-function] [D:\\Git\\nodejs\\node\\libnode.vcxproj]`","author":{"url":"https://github.com/targos","@type":"Person","name":"targos"},"datePublished":"2024-04-07T12:11:43Z","url":"https://github.com/nodejs/node/issues/52404"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ab130f9c-0067-45ae-9894-0d62cabd8666
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCBD0:122379:508C75:65D078:6B034D60
html-safe-noncee78927faeb7ac599539e5e349ff20396933dbbd7db13e2bed78a8c5da8e490b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkQwOjEyMjM3OTo1MDhDNzU6NjVEMDc4OjZCMDM0RDYwIiwidmlzaXRvcl9pZCI6IjczNjI1MzMxNDIxODU1OTQyMDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6744092e21fd742e9c5aefac72c85faf41fbdd4135757c2b463f5a1b71eb869d
hovercard-subject-tagissue:2229739326
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/52404/issue_layout
twitter:imagehttps://opengraph.githubassets.com/cacb61c0329e2f59c30a8e8a39be31293702baf738734ddef53f80a80365a3fc/nodejs/node/issues/52404
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cacb61c0329e2f59c30a8e8a39be31293702baf738734ddef53f80a80365a3fc/nodejs/node/issues/52404
og:image:altIn node/src/node.cc Lines 633 to 640 in 756acd0 #if NODE_USE_V8_WASM_TRAP_HANDLER #if defined(_WIN32) { constexpr ULONG first = TRUE; per_process::old_vectored_exception_handler = AddVectoredExcept...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametargos
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/52404#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F52404
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F52404
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/52404
Reloadhttps://github.com/nodejs/node/issues/52404
Reloadhttps://github.com/nodejs/node/issues/52404
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/52404
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/52404
Misplaced/dead Windows code in node.cc?https://github.com/nodejs/node/issues/52404#top
buildIssues and PRs related to Node.js builds or CI infrastructure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22build%22
good first issueIssues that are suitable for first-time contributors.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22good%20first%20issue%22
windowsIssues and PRs related to the Windows platform.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22windows%22
https://github.com/targos
targoshttps://github.com/targos
on Apr 7, 2024https://github.com/nodejs/node/issues/52404#issue-2229739326
node/src/node.cchttps://github.com/nodejs/node/blob/756acd087742939873555ca397f7b33e0db8a9ae/src/node.cc#L633-L640
756acd0https://github.com/nodejs/node/commit/756acd087742939873555ca397f7b33e0db8a9ae
node/src/node.cchttps://github.com/nodejs/node/blob/756acd087742939873555ca397f7b33e0db8a9ae/src/node.cc#L553
756acd0https://github.com/nodejs/node/commit/756acd087742939873555ca397f7b33e0db8a9ae
targoshttps://github.com/targos
windowsIssues and PRs related to the Windows platform.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22windows%22
buildIssues and PRs related to Node.js builds or CI infrastructure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22build%22
on Apr 7, 2024https://github.com/nodejs/node/issues/52404#event-12384008438
https://github.com/targos
targoshttps://github.com/targos
on Apr 8, 2024https://github.com/nodejs/node/issues/52404#issuecomment-2042028135
0577127https://github.com/nodejs/node/commit/05771279affce857e9b4d684f9afe77606b30f35
https://github.com/targos
targoshttps://github.com/targos
on Apr 11, 2024https://github.com/nodejs/node/issues/52404#issuecomment-2049050617
https://github.com/tniessen
tniessenhttps://github.com/tniessen
on Apr 11, 2024https://github.com/nodejs/node/issues/52404#issuecomment-2049154555
@devsnekhttps://github.com/devsnek
https://github.com/devsnek
devsnekhttps://github.com/devsnek
on Apr 11, 2024https://github.com/nodejs/node/issues/52404#issuecomment-2049167116
joyeecheunghttps://github.com/joyeecheung
good first issueIssues that are suitable for first-time contributors.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22good%20first%20issue%22
on Apr 13, 2024https://github.com/nodejs/node/issues/52404#event-12459060006
https://github.com/thisalihassan
thisalihassanhttps://github.com/thisalihassan
on Apr 15, 2024https://github.com/nodejs/node/issues/52404#issuecomment-2057535387
joyeecheunghttps://github.com/joyeecheung
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
5976985https://github.com/nodejs/node/commit/5976985a58a8635b8f1272519020c817f4ccdd1b
on Apr 30, 2024https://github.com/nodejs/node/issues/52404#event-12661409024
joyeecheunghttps://github.com/joyeecheung
on Apr 30, 2024https://github.com/nodejs/node/issues/52404#event-12661481234
src: remove misplaced windows code under posix guard in node.cchttps://github.com/joyeecheung/node/commit/5976985a58a8635b8f1272519020c817f4ccdd1b
5976985https://github.com/joyeecheung/node/commit/5976985a58a8635b8f1272519020c817f4ccdd1b
aduh95https://github.com/aduh95
on Apr 30, 2024https://github.com/nodejs/node/issues/52404#event-12664924779
src: remove misplaced windows code under posix guard in node.cchttps://github.com/nodejs/node/commit/0c58d0319b7e67c6e977a41fc5deef6371c4358e
0c58d03https://github.com/nodejs/node/commit/0c58d0319b7e67c6e977a41fc5deef6371c4358e
marco-ippolitohttps://github.com/marco-ippolito
on May 23, 2024https://github.com/nodejs/node/issues/52404#event-12907954729
src: remove misplaced windows code under posix guard in node.cchttps://github.com/nodejs/node/commit/07c45ba389a916569758e89cec8c7744fd24a1c8
07c45bahttps://github.com/nodejs/node/commit/07c45ba389a916569758e89cec8c7744fd24a1c8
joyeecheunghttps://github.com/joyeecheung
on May 28, 2024https://github.com/nodejs/node/issues/52404#event-12957289883
src: remove misplaced windows code under posix guard in node.cchttps://github.com/joyeecheung/node/commit/98606b2bccb4870f483554d978afa894276b1418
98606b2https://github.com/joyeecheung/node/commit/98606b2bccb4870f483554d978afa894276b1418
marco-ippolitohttps://github.com/marco-ippolito
on Jun 17, 2024https://github.com/nodejs/node/issues/52404#event-13184884599
src: remove misplaced windows code under posix guard in node.cchttps://github.com/nodejs/node/commit/d02907ecc4f108eaad89e9a2a92629fde0af3058
d02907ehttps://github.com/nodejs/node/commit/d02907ecc4f108eaad89e9a2a92629fde0af3058
eliphazbouyehttps://github.com/eliphazbouye
on Jun 20, 2024https://github.com/nodejs/node/issues/52404#event-13234954967
src: remove misplaced windows code under posix guard in node.cchttps://github.com/eliphazbouye/node/commit/92b30e54304c68d83d4178f3c2ff3469ace533fa
92b30e5https://github.com/eliphazbouye/node/commit/92b30e54304c68d83d4178f3c2ff3469ace533fa
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/52404
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/52404
buildIssues and PRs related to Node.js builds or CI infrastructure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22build%22
good first issueIssues that are suitable for first-time contributors.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22good%20first%20issue%22
windowsIssues and PRs related to the Windows platform.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22windows%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.