Title: Misplaced/dead Windows code in `node.cc`? · Issue #52404 · nodejs/node · GitHub
Open Graph Title: Misplaced/dead Windows code in `node.cc`? · Issue #52404 · nodejs/node
X Title: Misplaced/dead Windows code in `node.cc`? · Issue #52404 · nodejs/node
Description: In node/src/node.cc Lines 633 to 640 in 756acd0 #if NODE_USE_V8_WASM_TRAP_HANDLER #if defined(_WIN32) { constexpr ULONG first = TRUE; per_process::old_vectored_exception_handler = AddVectoredExceptionHandler(first, TrapWebAssemblyOrConti...
Open Graph Description: In node/src/node.cc Lines 633 to 640 in 756acd0 #if NODE_USE_V8_WASM_TRAP_HANDLER #if defined(_WIN32) { constexpr ULONG first = TRUE; per_process::old_vectored_exception_handler = AddVectoredExcept...
X Description: In node/src/node.cc Lines 633 to 640 in 756acd0 #if NODE_USE_V8_WASM_TRAP_HANDLER #if defined(_WIN32) { constexpr ULONG first = TRUE; per_process::old_vectored_exception_handler = AddVectoredExcept...
Opengraph URL: https://github.com/nodejs/node/issues/52404
X: @github
Domain: github.com
IPv4 address: 140.82.112.3
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Misplaced/dead Windows code in `node.cc`?","articleBody":"In https://github.com/nodejs/node/blob/756acd087742939873555ca397f7b33e0db8a9ae/src/node.cc#L633-L640, we have Windows-specific code.\r\nThe problem is that this code is inside a `#ifdef __POSIX__` section: \r\nhttps://github.com/nodejs/node/blob/756acd087742939873555ca397f7b33e0db8a9ae/src/node.cc#L553\r\n\r\nThis seems to be unexpected dead code for Windows.\r\nI found this from a compiler warning: `src\\node.cc(428,13): warning : unused function 'TrapWebAssemblyOrContinue' [-Wunused-function] [D:\\Git\\nodejs\\node\\libnode.vcxproj]`","author":{"url":"https://github.com/targos","@type":"Person","name":"targos"},"datePublished":"2024-04-07T12:11:43Z","url":"https://github.com/nodejs/node/issues/52404"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ab130f9c-0067-45ae-9894-0d62cabd8666 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CBD0:122379:508C75:65D078:6B034D60 |
| html-safe-nonce | e78927faeb7ac599539e5e349ff20396933dbbd7db13e2bed78a8c5da8e490b1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkQwOjEyMjM3OTo1MDhDNzU6NjVEMDc4OjZCMDM0RDYwIiwidmlzaXRvcl9pZCI6IjczNjI1MzMxNDIxODU1OTQyMDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6744092e21fd742e9c5aefac72c85faf41fbdd4135757c2b463f5a1b71eb869d |
| hovercard-subject-tag | issue:2229739326 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/52404/issue_layout |
| twitter:image | https://opengraph.githubassets.com/cacb61c0329e2f59c30a8e8a39be31293702baf738734ddef53f80a80365a3fc/nodejs/node/issues/52404 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cacb61c0329e2f59c30a8e8a39be31293702baf738734ddef53f80a80365a3fc/nodejs/node/issues/52404 |
| og:image:alt | In node/src/node.cc Lines 633 to 640 in 756acd0 #if NODE_USE_V8_WASM_TRAP_HANDLER #if defined(_WIN32) { constexpr ULONG first = TRUE; per_process::old_vectored_exception_handler = AddVectoredExcept... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | max-age=0, private, must-revalidate |
Viewport: width=device-width