Title: Avoid calling curl from tests · Issue #5174 · nodejs/node · GitHub
Open Graph Title: Avoid calling curl from tests · Issue #5174 · nodejs/node
X Title: Avoid calling curl from tests · Issue #5174 · nodejs/node
Description: Adding so I don't forget -- we currently invoke curl in two tests which implicitly pulls it as a dependency: $ ag "curl " test test/parallel/test-http-304.js 13: childProcess.exec('curl -i http://127.0.0.1:' + common.PORT + '/', test/par...
Open Graph Description: Adding so I don't forget -- we currently invoke curl in two tests which implicitly pulls it as a dependency: $ ag "curl " test test/parallel/test-http-304.js 13: childProcess.exec('curl -i http://1...
X Description: Adding so I don't forget -- we currently invoke curl in two tests which implicitly pulls it as a dependency: $ ag "curl " test test/parallel/test-http-304.js 13: childProcess.exec(...
Opengraph URL: https://github.com/nodejs/node/issues/5174
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Avoid calling curl from tests","articleBody":"Adding so I don't forget -- we currently invoke curl in two tests which implicitly pulls it as a dependency:\n\n``` bash\n$ ag \"curl \" test\ntest/parallel/test-http-304.js\n13: childProcess.exec('curl -i http://127.0.0.1:' + common.PORT + '/',\n\ntest/parallel/test-http-curl-chunk-problem.js\n19: console.log('making curl request');\n20: var cmd = 'curl http://127.0.0.1:' + common.PORT + '/ | ' +\n```\n\nSuggesting we replace this with.. javascript?\n","author":{"url":"https://github.com/jbergstroem","@type":"Person","name":"jbergstroem"},"datePublished":"2016-02-10T11:14:25.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/5174/node/issues/5174"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9a38a8b9-f848-0d2a-3891-db2b490437a5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8464:A6D52:19B6968:2347FAA:6A4F1652 |
| html-safe-nonce | 7755fe9eb7f7c6f8aeb22014ab87c3a0c903410c51be74b1f5ef2cf7ece64365 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDY0OkE2RDUyOjE5QjY5Njg6MjM0N0ZBQTo2QTRGMTY1MiIsInZpc2l0b3JfaWQiOiIxMDcwOTg3NDMzMTkxODcyMDgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9186f3a6cbc834cb617ff28d5d41bb7f70ab08b08baf8fe0248b525282961a24 |
| hovercard-subject-tag | issue:132671193 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/5174/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0af24b2e2d1c9883fd6c36292e3168739c7da30b70dff17f2815ff1772f0edd1/nodejs/node/issues/5174 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0af24b2e2d1c9883fd6c36292e3168739c7da30b70dff17f2815ff1772f0edd1/nodejs/node/issues/5174 |
| og:image:alt | Adding so I don't forget -- we currently invoke curl in two tests which implicitly pulls it as a dependency: $ ag "curl " test test/parallel/test-http-304.js 13: childProcess.exec('curl -i http://1... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jbergstroem |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width