Title: test_runner: always use paths to identify files · Issue #51610 · nodejs/node · GitHub
Open Graph Title: test_runner: always use paths to identify files · Issue #51610 · nodejs/node
X Title: test_runner: always use paths to identify files · Issue #51610 · nodejs/node
Description: Currently the file property emitted by different events in the test runner can be file URLs or paths. {"type":"test:enqueue","data":{"nesting":0,"name":"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js","line":1,"co...
Open Graph Description: Currently the file property emitted by different events in the test runner can be file URLs or paths. {"type":"test:enqueue","data":{"nesting":0,"name":"/Users/matteo/Repositories/borp/fixtures/ts-...
X Description: Currently the file property emitted by different events in the test runner can be file URLs or paths. {"type":"test:enqueue","data":{"nesting":0,"name&q...
Opengraph URL: https://github.com/nodejs/node/issues/51610
X: @github
Domain: github.com
IPv4 address: 140.82.114.4
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_runner: always use paths to identify files","articleBody":"Currently the `file` property emitted by different events in the test runner can be file URLs or paths.\r\n\r\n```\r\n{\"type\":\"test:enqueue\",\"data\":{\"nesting\":0,\"name\":\"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js\",\"line\":1,\"column\":1,\"file\":\"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js\"}}\r\n{\"type\":\"test:dequeue\",\"data\":{\"nesting\":0,\"name\":\"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js\",\"line\":1,\"column\":1,\"file\":\"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js\"}}\r\n{\"type\":\"test:enqueue\",\"data\":{\"nesting\":0,\"name\":\"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js\",\"line\":1,\"column\":1,\"file\":\"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js\"}}\r\n{\"type\":\"test:enqueue\",\"data\":{\"nesting\":0,\"name\":\"add2\",\"line\":4,\"column\":1,\"file\":\"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js\"}}\r\n{\"type\":\"test:dequeue\",\"data\":{\"nesting\":0,\"name\":\"add2\",\"line\":4,\"column\":1,\"file\":\"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js\"}}\r\n{\"type\":\"test:start\",\"data\":{\"nesting\":0,\"name\":\"add2\",\"line\":4,\"column\":1,\"file\":\"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js\"}}\r\n{\"type\":\"test:pass\",\"data\":{\"name\":\"add2\",\"nesting\":0,\"testNumber\":1,\"details\":{\"duration_ms\":0.477958},\"line\":4,\"column\":1,\"file\":\"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js\"}}\r\n{\"type\":\"test:dequeue\",\"data\":{\"nesting\":0,\"name\":\"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js\",\"line\":1,\"column\":1,\"file\":\"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js\"}}\r\n{\"type\":\"test:enqueue\",\"data\":{\"nesting\":0,\"name\":\"add\",\"line\":4,\"column\":1,\"file\":\"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js\"}}\r\n{\"type\":\"test:dequeue\",\"data\":{\"nesting\":0,\"name\":\"add\",\"line\":4,\"column\":1,\"file\":\"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js\"}}\r\n{\"type\":\"test:start\",\"data\":{\"nesting\":0,\"name\":\"add\",\"line\":4,\"column\":1,\"file\":\"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js\"}}\r\n{\"type\":\"test:pass\",\"data\":{\"name\":\"add\",\"nesting\":0,\"testNumber\":2,\"details\":{\"duration_ms\":0.424333},\"line\":4,\"column\":1,\"file\":\"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js\"}}\r\n```\r\n\r\nMy take on those is that they should be paths and not file URLs, or in any case they should be consistent.\r\n\r\n---\r\n\r\nOn a side note, the file URLs generated by this are unparsable on windows, because there is an additional `/`, e.g. `file:///C:\\\\`. ","author":{"url":"https://github.com/mcollina","@type":"Person","name":"mcollina"},"datePublished":"2024-01-30T18:46:37Z","url":"https://github.com/nodejs/node/issues/51610"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4c196b82-4908-28dd-1724-699541b6d043 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B8D4:16DC03:2F51185:3EAC5DD:6B035424 |
| html-safe-nonce | e5ecf16a5ab6bb0622123fec83d1c6b314f2392b8d983e221eb76bcf1b7bf70c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEQ0OjE2REMwMzoyRjUxMTg1OjNFQUM1REQ6NkIwMzU0MjQiLCJ2aXNpdG9yX2lkIjoiODgzMTM5NDA3NzQ2ODc0MjY5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5c6c52bdff7b8d5c84d9a3d5be9df7281d18c4c4a345983d29ef1b8accf02efd |
| hovercard-subject-tag | issue:2108532676 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/51610/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e34eabf2701b4ffa352e46628b5d6724ef2033ce831c1fb934dc56ae37078f2d/nodejs/node/issues/51610 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e34eabf2701b4ffa352e46628b5d6724ef2033ce831c1fb934dc56ae37078f2d/nodejs/node/issues/51610 |
| og:image:alt | Currently the file property emitted by different events in the test runner can be file URLs or paths. {"type":"test:enqueue","data":{"nesting":0,"name":"/Users/matteo/Repositories/borp/fixtures/ts-... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mcollina |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | max-age=0, private, must-revalidate |
Viewport: width=device-width