René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"custom Import attributes with esm hooks","articleBody":"### Version\r\n\r\n20.10\r\n\r\n### Platform\r\n\r\nLinux akala 6.2.16-19-pve #1 SMP PREEMPT_DYNAMIC PMX 6.2.16-19 (2023-10-24T12:07Z) x86_64 x86_64 x86_64 GNU/Linux\r\n\r\n### Subsystem\r\n\r\nesm hooks\r\n\r\n### What steps will reproduce the bug?\r\n\r\nSetup an ESM hook that handles a specific import attribute that relies on the builtin esm loader\r\n```js\r\nimport fs from 'fs/promise';\r\nimport { fileURLToPath } from 'url';\r\nexport async function load(url, context, nextLoad){\r\n    \r\nif(context.importAttributes.type!=='x')\r\nreturn nextLoad(url, context)\r\n\r\n    const source = await fs.readFile(fileURLToPath, 'utf8')\r\n\r\n        return ({\r\n            format: 'module',\r\n            shortCircuit: true,\r\n            source: source.replace(/import .*['\"][^'\"]+['\"]$/g, m=>m+'with {type:'x'}')\r\n        })\r\n}\r\n```\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nAlways\r\n\r\n### What is the expected behavior? Why is that the expected behavior?\r\n\r\nEither have a customAttribute hook to handle this validation or disable the validation when a custom hook is registered\r\n\r\n### What do you see instead?\r\n\r\nTypeError [ERR_IMPORT_ASSERTION_TYPE_UNSUPPORTED]: Import attribute type \"x\" is unsupported\r\n    at handleInvalidType (node:internal/modules/esm/assert:106:11)\r\n    at validateAttributes (node:internal/modules/esm/assert:78:14)\r\n    at defaultLoad (node:internal/modules/esm/load:150:3)\r\n    at async nextLoad (node:internal/modules/esm/hooks:865:22)\r\n    at async nextLoad (node:internal/modules/esm/hooks:865:22)\r\n    at async nextLoad (node:internal/modules/esm/hooks:865:22)\r\n    at async Hooks.load (node:internal/modules/esm/hooks:448:20)\r\n    at async handleMessage (node:internal/modules/esm/worker:196:18) {\r\n  code: 'ERR_IMPORT_ASSERTION_TYPE_UNSUPPORTED'\r\n}\r\n\r\n### Additional information\r\n\r\n_No response_","author":{"url":"https://github.com/npenin","@type":"Person","name":"npenin"},"datePublished":"2023-12-12T06:18:21Z","url":"https://github.com/nodejs/node/issues/51128"}