René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Dynamic `import` attributes broken with multiple attributes","articleBody":"I was trying to adapt a [V8 test](https://github.com/nodejs/node/blob/main/deps/v8/test/mjsunit/harmony/modules-import-assertions-dynamic-6.mjs) to run it in Node.js\r\n\r\nThe following version fails in a C++ CHECK (it doesn't matter if the json file exists or not):\r\n\r\n```js\r\nimport assert from 'assert';\r\n\r\nvar life;\r\nimport('./modules-skip-1.json', { with: { type: 'json', notARealAssertion: 'value' } }).then(\r\n    namespace =\u003e life = namespace.default.life).then(() =\u003e {\r\n      assert.strictEqual(life, 42);\r\n    });\r\n\r\nvar life2;\r\nimport('./modules-skip-1.json', { with: { 0: 'value', type: 'json' } }).then(\r\n    namespace =\u003e life2 = namespace.default.life).then(() =\u003e {\r\n      assert.strictEqual(life2, 42);\r\n    });\r\n```\r\n\r\n```\r\n#\r\n# Fatal error in , line 0\r\n# Check failed: i \u003c self-\u003elength().\r\n#\r\n#\r\n#\r\n#FailureMessage Object: 0x16d934a68\r\n 1: 0x1025fad74 node::NodePlatform::GetStackTracePrinter()::$_3::__invoke() [/Users/mzasso/.volta/tools/image/node/21.1.0/bin/node]\r\n 2: 0x1036dbcc4 V8_Fatal(char const*, ...) [/Users/mzasso/.volta/tools/image/node/21.1.0/bin/node]\r\n 3: 0x10273d8bc v8::FixedArray::Get(v8::Local\u003cv8::Context\u003e, int) const [/Users/mzasso/.volta/tools/image/node/21.1.0/bin/node]\r\n 4: 0x10255ad78 node::loader::createImportAttributesContainer(node::Environment*, v8::Isolate*, v8::Local\u003cv8::FixedArray\u003e) [/Users/mzasso/.volta/tools/image/node/21.1.0/bin/node]\r\n 5: 0x10255c3d8 node::loader::ImportModuleDynamically(v8::Local\u003cv8::Context\u003e, v8::Local\u003cv8::Data\u003e, v8::Local\u003cv8::Value\u003e, v8::Local\u003cv8::String\u003e, v8::Local\u003cv8::FixedArray\u003e) [/Users/mzasso/.volta/tools/image/node/21.1.0/bin/node]\r\n 6: 0x102895ab0 v8::internal::Isolate::RunHostImportModuleDynamicallyCallback(v8::internal::MaybeHandle\u003cv8::internal::Script\u003e, v8::internal::Handle\u003cv8::internal::Object\u003e, v8::internal::MaybeHandle\u003cv8::internal::Object\u003e) [/Users/mzasso/.volta/tools/image/node/21.1.0/bin/node]\r\n 7: 0x102cc3670 v8::internal::Runtime_DynamicImportCall(int, unsigned long*, v8::internal::Isolate*) [/Users/mzasso/.volta/tools/image/node/21.1.0/bin/node]\r\n 8: 0x103057768 Builtins_CEntry_Return1_ArgvInRegister_NoBuiltinExit [/Users/mzasso/.volta/tools/image/node/21.1.0/bin/node]\r\n```\r\n\r\nThis happens in Node.js 21 and v20.x-staging.","author":{"url":"https://github.com/targos","@type":"Person","name":"targos"},"datePublished":"2023-11-13T10:01:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/50700/node/issues/50700"}