René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_runner: mock setInterval uses wrong interval after first time","articleBody":"### Version\n\nmain\n\n### Platform\n\nLinux s7 5.15.0-69-generic #76-Ubuntu SMP Fri Mar 17 17:19:29 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux\n\n### Subsystem\n\ntest\n\n### What steps will reproduce the bug?\n\nWhen a mocked `setInterval` timer is triggered, the timers runAt time is updated for the next time it should run [here](https://github.com/nodejs/node/blob/4f5db8b26d906f1cbe9f6a9ac2028b0f7ad88c91/lib/internal/test_runner/mock/mock_timers.js#L625). However , the increment is actually always 1, since the boolean flag `isInterval` is stored in the timer [here](https://github.com/nodejs/node/blob/4f5db8b26d906f1cbe9f6a9ac2028b0f7ad88c91/lib/internal/test_runner/mock/mock_timers.js#L268)\r\n\r\nPull request incoming.\r\n\r\n```js\r\ntest(\"setInterval uses the wrong interval\", async (t) =\u003e {\r\n  t.mock.timers.enable({ apis: [\"setInterval\"] });\r\n  const fn = t.mock.fn();\r\n\r\n  setInterval(fn, 1000);\r\n\r\n  assert.strictEqual(fn.mock.callCount(), 0);\r\n\r\n  t.mock.timers.tick(1000);\r\n\r\n  assert.strictEqual(fn.mock.callCount(), 1);\r\n\r\n  for (let i = 0; i \u003c 999; ++i) {\r\n    t.mock.timers.tick(1);\r\n  }\r\n\r\n  assert.strictEqual(fn.mock.callCount(), 1);\r\n});\r\n```\r\n\r\nfails with:\r\n\r\n```\r\n❯ ~/src/libs/node/node index.mjs\r\n﹣ aborting setTimeout clears wrong timer (2.795504ms) # SKIP\r\n﹣ aborting setTimeout after timer is already triggered clear wrong timer (0.20311ms) # SKIP\r\n✖ setInterval uses the wrong interval (24.795796ms)\r\n  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:\r\n  \r\n  1000 !== 1\r\n  \r\n      at TestContext.\u003canonymous\u003e (file:///home/mfischer/src/tests/node-mock-timers/index.mjs:72:10)\r\n      at Test.runInAsyncScope (node:async_hooks:206:9)\r\n      at Test.run (node:internal/test_runner/test:631:25)\r\n      at Test.processPendingSubtests (node:internal/test_runner/test:374:18)\r\n      at Test.postRun (node:internal/test_runner/test:715:19)\r\n      at Test.run (node:internal/test_runner/test:673:12)\r\n      at async Test.processPendingSubtests (node:internal/test_runner/test:374:7) {\r\n    generatedMessage: true,\r\n    code: 'ERR_ASSERTION',\r\n    actual: 1000,\r\n    expected: 1,\r\n    operator: 'strictEqual'\r\n  }\r\n```\n\n### How often does it reproduce? Is there a required condition?\n\nAlways\n\n### What is the expected behavior? Why is that the expected behavior?\n\nsetInterval should use the correct interval\n\n### What do you see instead?\n\nsetInverval always uses interval 1 after first time\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/mika-fischer","@type":"Person","name":"mika-fischer"},"datePublished":"2023-10-25T08:04:45.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/50381/node/issues/50381"}