Title: Queued buffers not cleaned up in closed sockets · Issue #4779 · nodejs/node · GitHub
Open Graph Title: Queued buffers not cleaned up in closed sockets · Issue #4779 · nodejs/node
X Title: Queued buffers not cleaned up in closed sockets · Issue #4779 · nodejs/node
Description: I initially reported this issue on ws repo, however there might be a possibility that it is a node issue after testing it on both the official windows Nodejs and Chakra builds. Somehow it seems that the issue can be reproduced more quick...
Open Graph Description: I initially reported this issue on ws repo, however there might be a possibility that it is a node issue after testing it on both the official windows Nodejs and Chakra builds. Somehow it seems tha...
X Description: I initially reported this issue on ws repo, however there might be a possibility that it is a node issue after testing it on both the official windows Nodejs and Chakra builds. Somehow it seems tha...
Opengraph URL: https://github.com/nodejs/node/issues/4779
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Queued buffers not cleaned up in closed sockets","articleBody":"I initially reported this issue on [ws repo](https://github.com/websockets/ws/issues/667), however there might be a possibility that it is a node issue after testing it on both the official windows Nodejs and [Chakra](https://github.com/Microsoft/node/releases/tag/node-chakracore-6.0.0-pre2) builds. Somehow it seems that the issue can be reproduced more quickly on Linux/MacOS than on Windows.\n### Observations\n- Slow clients (clients receiving data slower than server sends it) causes socket to increase their bufferSize\n- This typically increases the RSS of the node process\n- Upon disconnections of clients, we expect RSS to fall\n- This is true for TCP test case but not for WS (Websockets)\n- Slower RSS recovery for TCP test can be triggered by disconnecting most but not all of the connected clients\n- Recovery of RSS can be sometimes triggered by connecting new clients and disconnecting them quickly\n### Reproduction Steps\n- Test cases are in https://github.com/zz85/node-ws-slow-client-buffer-leak repository\n- Run server on a separate machine over the network\n- Run 200 clients for 30 seconds\n- RSS builds up to approximately 700MB.\n- Disconnects clients.\n- RSS falls to about 300MB and stays there (RSS falls to 60MB for windows nodejs)\n","author":{"url":"https://github.com/zz85","@type":"Person","name":"zz85"},"datePublished":"2016-01-20T11:28:02.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":13},"url":"https://github.com/4779/node/issues/4779"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a0441ec2-dcc4-8f18-5e00-9575d0d8c171 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 900C:10E65B:565934:732D94:6A500766 |
| html-safe-nonce | dfc98dd3cbb34ef539d298632e571387cc929b17d2c513e39b14a3bad2de3321 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDBDOjEwRTY1Qjo1NjU5MzQ6NzMyRDk0OjZBNTAwNzY2IiwidmlzaXRvcl9pZCI6Ijc0MTcwODU3MjgyODYzMjkzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 16532930be8fcf4204ba4f5733df1a95b6bb24709854b572d2e1ed3db17f1223 |
| hovercard-subject-tag | issue:127662493 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/4779/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7691dc1da39154ba4de20401a80d0138cb847a7cdf8812f7fcf8716c0810cf39/nodejs/node/issues/4779 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7691dc1da39154ba4de20401a80d0138cb847a7cdf8812f7fcf8716c0810cf39/nodejs/node/issues/4779 |
| og:image:alt | I initially reported this issue on ws repo, however there might be a possibility that it is a node issue after testing it on both the official windows Nodejs and Chakra builds. Somehow it seems tha... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zz85 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56eec25a3430492dd6ec2a480eb33256a0da5192d5714b0db4f5ab5f33203d94 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 93a615b89b7dcbdb6b678f4772931ecc28ada82a |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width