René's URL Explorer Experiment


Title: Replacing benchmark/compare.R with a JavaScript implementation · Issue #45390 · nodejs/node · GitHub

Open Graph Title: Replacing benchmark/compare.R with a JavaScript implementation · Issue #45390 · nodejs/node

X Title: Replacing benchmark/compare.R with a JavaScript implementation · Issue #45390 · nodejs/node

Description: Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by compare.R. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @targos) and gave it a try, it worked very w...

Open Graph Description: Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by compare.R. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @tar...

X Description: Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by compare.R. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @tar...

Opengraph URL: https://github.com/nodejs/node/issues/45390

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Replacing benchmark/compare.R with a JavaScript implementation","articleBody":"Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by `compare.R`. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @targos) and gave it a try, it worked very well for me. I think in the past we had discussion about replacing this script with a JS implementation, it didn't end up fruitful because of the lack of implementation of the statistical distribution required by the script. Now that seems to be solved already by https://github.com/nearform/node-cephes  (see https://github.com/nodejs/node/pull/44974#issuecomment-1275661186). So I am wondering if it's time to reopen the discussion.\r\n\r\nI think we can basically just vendor in the node-benchmark-compare package into `tools/` or `benchmark/` and replace the command `cat results.csv | Rscript benchmark/compare.R` with `node-benchmark-compare results.csv` (both [the benchmark guide](https://github.com/nodejs/node/blob/main/doc/contributing/writing-and-running-benchmarks.md) and [the script used by the CI](https://github.com/nodejs/benchmarking/blob/master/experimental/benchmarks/community-benchmark/run.sh) need to be updated, though in the case of the latter we might have to un-archive the repo, or edit the CI config to point to somewhere else?)\r\n\r\n","author":{"url":"https://github.com/joyeecheung","@type":"Person","name":"joyeecheung"},"datePublished":"2022-11-09T16:37:23Z","url":"https://github.com/nodejs/node/issues/45390"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:54295480-a433-dc3e-abf5-fd78a674736f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE25A:1E2715:637581:80ADDD:6AED2B90
html-safe-nonce26e6c2d680b4995901a6fb04d134174bea7650ddd094649750440722ac4f87f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjVBOjFFMjcxNTo2Mzc1ODE6ODBBREREOjZBRUQyQjkwIiwidmlzaXRvcl9pZCI6IjM5MTcyNjA4MzQzMzIyODk5MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5f0bf32df2cc847762180a3aefc82e3790d87739aaf7a8e66df6faecf5e03615
hovercard-subject-tagissue:1442407022
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/45390/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9d653bdec0be1d85d306bc196e4a7e00aeb664eed14bc15bf6e4301060c00802/nodejs/node/issues/45390
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9d653bdec0be1d85d306bc196e4a7e00aeb664eed14bc15bf6e4301060c00802/nodejs/node/issues/45390
og:image:altSince I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by compare.R. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @tar...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/45390#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F45390
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F45390
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/45390
Reloadhttps://github.com/nodejs/node/issues/45390
Reloadhttps://github.com/nodejs/node/issues/45390
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/45390
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/45390
Replacing benchmark/compare.R with a JavaScript implementationhttps://github.com/nodejs/node/issues/45390#top
benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22benchmark%22
metaIssues and PRs related to the general management of the project.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22meta%22
staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stale%22
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
on Nov 9, 2022https://github.com/nodejs/node/issues/45390#issue-1442407022
https://github.com/targos/node-benchmark-comparehttps://github.com/targos/node-benchmark-compare
@targoshttps://github.com/targos
https://github.com/nearform/node-cepheshttps://github.com/nearform/node-cephes
#44974 (comment)https://github.com/nodejs/node/pull/44974#issuecomment-1275661186
the benchmark guidehttps://github.com/nodejs/node/blob/main/doc/contributing/writing-and-running-benchmarks.md
the script used by the CIhttps://github.com/nodejs/benchmarking/blob/master/experimental/benchmarks/community-benchmark/run.sh
joyeecheunghttps://github.com/joyeecheung
metaIssues and PRs related to the general management of the project.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22meta%22
benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22benchmark%22
on Nov 9, 2022https://github.com/nodejs/node/issues/45390#event-7775335682
https://github.com/Trott
Trotthttps://github.com/Trott
on Nov 10, 2022https://github.com/nodejs/node/issues/45390#issuecomment-1309631892
https://github.com/nodejs/node/blob/main/doc/contributing/writing-and-running-benchmarks.md#benchmark-analysis-requirementshttps://github.com/nodejs/node/blob/main/doc/contributing/writing-and-running-benchmarks.md#benchmark-analysis-requirements
https://github.com/nodejs/node/blob/main/doc/contributing/writing-and-running-benchmarks.md#filtering-benchmarkshttps://github.com/nodejs/node/blob/main/doc/contributing/writing-and-running-benchmarks.md#filtering-benchmarks
@addaleaxhttps://github.com/addaleax
https://user-images.githubusercontent.com/718899/200975919-79ae2d61-d172-42e5-aefd-d85391fd460d.png
scripthttps://github.com/addaleax/benchmarking/blob/generic-github/experimental/benchmarks/community-benchmark/run.sh
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
on Jun 23, 2026https://github.com/nodejs/node/issues/45390#issuecomment-4774886341
GitHub Actionshttps://help.github.com/en/actions
github-actionshttps://github.com/apps/github-actions
staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stale%22
on Jun 23, 2026https://github.com/nodejs/node/issues/45390#event-27071060930
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
on Jul 24, 2026https://github.com/nodejs/node/issues/45390#issuecomment-5065306661
GitHub Actionshttps://help.github.com/en/actions
github-actionshttps://github.com/apps/github-actions
not plannedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Jul 24, 2026https://github.com/nodejs/node/issues/45390#event-28413094818
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/45390
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/45390
benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22benchmark%22
metaIssues and PRs related to the general management of the project.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22meta%22
staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stale%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.