Title: Replacing benchmark/compare.R with a JavaScript implementation · Issue #45390 · nodejs/node · GitHub
Open Graph Title: Replacing benchmark/compare.R with a JavaScript implementation · Issue #45390 · nodejs/node
X Title: Replacing benchmark/compare.R with a JavaScript implementation · Issue #45390 · nodejs/node
Description: Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by compare.R. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @targos) and gave it a try, it worked very w...
Open Graph Description: Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by compare.R. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @tar...
X Description: Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by compare.R. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @tar...
Opengraph URL: https://github.com/nodejs/node/issues/45390
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Replacing benchmark/compare.R with a JavaScript implementation","articleBody":"Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by `compare.R`. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @targos) and gave it a try, it worked very well for me. I think in the past we had discussion about replacing this script with a JS implementation, it didn't end up fruitful because of the lack of implementation of the statistical distribution required by the script. Now that seems to be solved already by https://github.com/nearform/node-cephes (see https://github.com/nodejs/node/pull/44974#issuecomment-1275661186). So I am wondering if it's time to reopen the discussion.\r\n\r\nI think we can basically just vendor in the node-benchmark-compare package into `tools/` or `benchmark/` and replace the command `cat results.csv | Rscript benchmark/compare.R` with `node-benchmark-compare results.csv` (both [the benchmark guide](https://github.com/nodejs/node/blob/main/doc/contributing/writing-and-running-benchmarks.md) and [the script used by the CI](https://github.com/nodejs/benchmarking/blob/master/experimental/benchmarks/community-benchmark/run.sh) need to be updated, though in the case of the latter we might have to un-archive the repo, or edit the CI config to point to somewhere else?)\r\n\r\n","author":{"url":"https://github.com/joyeecheung","@type":"Person","name":"joyeecheung"},"datePublished":"2022-11-09T16:37:23Z","url":"https://github.com/nodejs/node/issues/45390"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:54295480-a433-dc3e-abf5-fd78a674736f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E25A:1E2715:637581:80ADDD:6AED2B90 |
| html-safe-nonce | 26e6c2d680b4995901a6fb04d134174bea7650ddd094649750440722ac4f87f2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjVBOjFFMjcxNTo2Mzc1ODE6ODBBREREOjZBRUQyQjkwIiwidmlzaXRvcl9pZCI6IjM5MTcyNjA4MzQzMzIyODk5MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5f0bf32df2cc847762180a3aefc82e3790d87739aaf7a8e66df6faecf5e03615 |
| hovercard-subject-tag | issue:1442407022 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/45390/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9d653bdec0be1d85d306bc196e4a7e00aeb664eed14bc15bf6e4301060c00802/nodejs/node/issues/45390 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9d653bdec0be1d85d306bc196e4a7e00aeb664eed14bc15bf6e4301060c00802/nodejs/node/issues/45390 |
| og:image:alt | Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by compare.R. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @tar... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | e51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ebb7b901cc154ecc179a44f266fcf69f343b30 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width