René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Crash if wrong hex string is written to http.ClientRequest","articleBody":"### Version\r\n\r\n19.0.0 (but happens also on older versions, last retest with 21.4.0)\r\n\r\n### Platform\r\n\r\nall\r\n\r\n### Subsystem\r\n\r\nhttp, maybe streams\r\n\r\n### What steps will reproduce the bug?\r\n\r\nif an invalid hex encoded string is written to a `http.ClientRequest` node crashes/asserts.\r\n\r\n```js\r\nconst http = require(\"http\");\r\n\r\nconst request = http.request(\"http://example.org\", {method: \"POST\"});\r\nrequest.write(\"1\", \"hex\");\r\n```\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nalways\r\n\r\n### What is the expected behavior?\r\n\r\nMore graceful error handling like a JS exception.\r\n\r\n### What do you see instead?\r\n\r\nassert/crash\r\n\r\n```\r\nnode[360]: ../src/string_bytes.cc:420:static v8::Maybe\u003clong unsigned int> node::StringBytes::StorageSize(v8::Isolate*, v8::Local\u003cv8::Value>, node::encoding): Assertion `str->Length() % 2 == 0 && \"invalid hex string length\"' failed.\r\n 1: 0xbbf330 node::Abort() [node]\r\n 2: 0xbbf3ae  [node]\r\n 3: 0xcaf8ba node::StringBytes::StorageSize(v8::Isolate*, v8::Local\u003cv8::Value>, node::encoding) [node]\r\n 4: 0xca562a node::StreamBase::Writev(v8::FunctionCallbackInfo\u003cv8::Value> const&) [node]\r\n 5: 0xca7876 void node::StreamBase::JSMethod\u003c&node::StreamBase::Writev>(v8::FunctionCallbackInfo\u003cv8::Value> const&) [node]\r\n 6: 0xe03f00  [node]\r\n 7: 0xe05356 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]\r\n 8: 0x17fb3f9  [node]\r\nAborted (core dumped)\r\n```\r\n\r\n### Additional information\r\n\r\nThis seems to be not limited to http, net shows same problem with following code:\r\n```js\r\nconst net = require(\"node:net\");\r\nconst s = net.createConnection(8000);\r\ns.on(\"connect\", () => {\r\n    s.cork()\r\n    s.write(\"a\")\r\n    s.write(\"1\", \"hex\");\r\n    s.uncork()\r\n});\r\n```\r\nInteresting is that following net sample doesn't crash:\r\n```js\r\nconst net = require(\"node:net\");\r\nconst s = net.createConnection(8000);\r\ns.on(\"connect\", () => {\r\n    s.write(\"1\", \"hex\");\r\n});\r\n```\r\nSeems in this case the single, invalid hex encoded byte is silently discarded.","author":{"url":"https://github.com/Flarna","@type":"Person","name":"Flarna"},"datePublished":"2022-10-24T13:50:21Z","url":"https://github.com/nodejs/node/issues/45150"}