René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"assert.deepStrictEqual() and the `vm` module are incompatible","articleBody":"### Version\r\n\r\nv18.8.0\r\n\r\n### Platform\r\n\r\nLinux DESKTOP-TBGODF1 4.4.0-19041-Microsoft #1237-Microsoft Sat Sep 11 14:32:00 PST 2021 x86_64 x86_64 x86_64 GNU/Linux\r\n\r\n### Subsystem\r\n\r\n_No response_\r\n\r\n### What steps will reproduce the bug?\r\n\r\n```javascript\r\nimport vm from 'node:vm';\r\nimport assert from 'node:assert/strict';\r\nconst g = {exports: {}};\r\nconst result = vm.runInNewContext(`exports.result = {foo:'bar'};`, g);\r\nassert.deepStrictEqual(g.exports.result, {foo: 'bar'});\r\n```\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\n_No response_\r\n\r\n### What is the expected behavior?\r\n\r\nThese two objects are structurally identical and have the `Object` prototype. The `assert` library should accept them as deep-equal.\r\n\r\n### What do you see instead?\r\n\r\nSince the VM script's context creates its own `Object` for use in prototypes, therefore the prototype check introduced to the `assert` library in 02b66b5b866bd8398e7d815d3715ba3f94a5cf65 (#24974, ref #24917) fails since they're not equal (even though they represent the same underlying 'facility' in Javascript).\r\n\r\nThis caused some confusing output:\r\n\r\n```\r\nAssertionError [ERR_ASSERTION]: Values have same structure but are not reference-equal:\r\n\r\n{\r\n  foo: 'bar'\r\n}\r\n```\r\n\r\nFurther, of course they're not reference equal - that would defeat the entire purpose of a `deepEqual` check, would it not? 🙃 I had to google to figure out it was referring to prototype checking. Perhaps the error message could be improved here?\r\n\r\n### Additional information\r\n\r\nIt'd be great if we could get a variant of the `node:assert` library that is 1) strict and 2) ignores prototypes for cases like this. I don't see how this could be fixed otherwise, given how v8's contexts work.","author":{"url":"https://github.com/Qix-","@type":"Person","name":"Qix-"},"datePublished":"2022-08-31T01:41:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/44462/node/issues/44462"}