René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"AsyncLocalStore looses context in MakeCallback","articleBody":"### Version\r\n\r\n18.1.0, 14.19.1 (and most likely a lot others)\r\n\r\n### Platform\r\n\r\nTested on `Microsoft Windows NT 10.0.22000.0 x64` but very likely platform independent.\r\n\r\n### Subsystem\r\n\r\nasync_hooks\r\n\r\n### What steps will reproduce the bug?\r\n\r\nUse `node::MakeCallback()` with a receiver different to the `AsyncResource`.\r\n\r\nSee e.g. [snappy 6.x](https://github.com/kesla/node-snappy/blob/53bdf54e6e84e3d898b2f6cd00baeb9f16e9fb43/src/binding.cc#L13-L43) which uses [`Nan::AsyncWorker`](https://github.com/nodejs/nan/blob/16fa32231e2ccd89d2804b3f765319128b20c4ac/nan.h#L1909-L2026).\r\n\r\nIn this setup the complete callback is not called with the `AsyncResource` as target and this results in setting the wrong object as current resource in [`MakeCallback`](https://github.com/nodejs/node/blob/76499898763102272a47d642f905e47c0cc41df0/src/api/callback.cc#L282).\r\n\r\nCalling callbacks with undefined/null/global as target is not that uncommon.\r\n\r\nThe before/after callbacks are called with the correct asyncId but `AsyncLocalStore` relies on the current resource.\r\n\r\n```js\r\nconst { executionAsyncId, AsyncLocalStorage } = require(\"async_hooks\")\r\nconst snappy = require(\"snappy\")\r\nconst als = new AsyncLocalStorage()\r\n\r\nals.run(15, () => {\r\n  snappy.compress(\"Hello World!\", () => {\r\n    const cbId = executionAsyncId()\r\n    console.log(`compressed: ${cbId}, als: ${als.getStore()}`)\r\n  })\r\n})\r\n```\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nAlways if `MakeCallback` is used with a receiver different then the `AsyncResource` object.\r\n\r\n### What is the expected behavior?\r\n\r\nno context loss\r\n\r\n### What do you see instead?\r\n\r\ncontext loss \r\n\r\n### Additional information\r\n\r\n_No response_","author":{"url":"https://github.com/Flarna","@type":"Person","name":"Flarna"},"datePublished":"2022-05-10T14:19:27Z","url":"https://github.com/nodejs/node/issues/43038"}