René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"short body race condition in http parsing","articleBody":"### Version\n\nv16.14.0\n\n### Platform\n\nLinux chad1 5.4.0-99-generic #112~18.04.1-Ubuntu SMP Thu Feb 3 14:09:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux\n\n### Subsystem\n\nhttp net.Socket streams\n\n### What steps will reproduce the bug?\n\nIn this gist: https://gist.github.com/chad3814/b1f927c5cabae86fb2733f1ab37d6bfd\r\nthere are two files, `listener.mjs` and `putter.mjs`. If you run `listener.mjs` and then in another shell run `putter.mjs` you'll see that it saves an empty, zero byte file. Then if you remark the `await sleep(10);` on line 12 on `listener.mjs` and run them again, you'll see that it writes out the file on the first pass through the loop, but on the next pass an `ECONNRESET` is thrown.\n\n### How often does it reproduce? Is there a required condition?\n\nHappens every time as discussed above\n\n### What is the expected behavior?\n\nWhat it looks like to me is when the body of an http message is short, the header and body don't break the high water mark, so it's all read in at once and saved in the buffer list. The problem is triggered by the remote end not waiting for a response from the server and just closing the connection (which is allowed afaik by the http spec). I can understand an `ECONNRESET` being thrown, but we should be able to read the data from the body. Or maybe the error should be thrown if we/when we write to the response object? Either way, we need to reliably read the data using node 16 like we did with node 14.\n\n### What do you see instead?\n\nI see this problem in our production code because `ffmpeg` does the same sort of http call as in `putter.mjs`, where it pushes all the data and then closes the connection without waiting for a response. This all worked in node 14 using `.pipe()`s but with node 16 and pipes we're seeing the two issues above at different times.\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/chad3814","@type":"Person","name":"chad3814"},"datePublished":"2022-03-10T00:40:32.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":13},"url":"https://github.com/42276/node/issues/42276"}