René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`AsyncResource.bind` always alters the value of `this` unexpectedly","articleBody":"### Version\r\n\r\n17.6.0\r\n\r\n### Platform\r\n\r\n_No response_\r\n\r\n### Subsystem\r\n\r\n_No response_\r\n\r\n### What steps will reproduce the bug?\r\n\r\n```js\r\nconst fn = AsyncResource.bind(function () {\r\n  console.log(this)\r\n})\r\n\r\nfn.apply('foo') // will log the AsyncResource instead of 'foo'\r\n\r\nconst obj = { fn }\r\n\r\nobj.fn() // will log the AsyncResource instead of `obj`\r\n```\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nAlways as the code is explicitly binding `thisArg` even when not provided.\r\n\r\n### What is the expected behavior?\r\n\r\n`AsyncResource.bind` should use the `this` value provided by the caller by default and only bind `this` when a `thisArg` is passed explicitly.\r\n\r\n### What do you see instead?\r\n\r\n`AsyncResource.bind` defaults to setting `this` to itself, which is not only unexpected in pretty much all cases, but also makes it impossible to use the `this` provided by the caller without an explicit reference to the caller at bind time. This means that in all situations right now it would make more sense to use `runInAsyncScope` instead of `bind` making it effectively unusable.\r\n\r\n### Additional information\r\n\r\nAs an APM vendor, we're making heavy use of this API and there is not a single occurrence in our code where the default works.\r\n\r\nThe feature was originally implemented in #36782","author":{"url":"https://github.com/rochdev","@type":"Person","name":"rochdev"},"datePublished":"2022-03-01T02:08:15Z","url":"https://github.com/nodejs/node/issues/42158"}