René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"util.inherits does not establish prototype chain","articleBody":"In inherits.js Object.setPrototypeOf is being called with the wrong parameters.\n\nThe reason for me assuming that the wrong parameters are being used is\n\n(REPL)\n\n```\n\u003e function MyError() {}\n\u003e util.inherits(MyError, Error);\n\u003e MyError\n{ [Function: MyError]\n  super_: \n   { [Function: Error]\n     captureStackTrace: [Function: captureStackTrace],\n     stackTraceLimit: 10 } }\n\u003e Error.isPrototypeOf(MyError);\nfalse\n```\n\nWhile inheritance sort of works, the prototype chain is actually never established.\n\n```\n\u003e myerr = new MyError()\n[Error]\n\u003e myerr instanceof MyError\ntrue\n\u003e myerr instanceof Error\ntrue\n```\n\nReplacing the existing call to Object.setPrototypeOf() by\n\n```\nObject.setPrototypeOf(ctor, superCtor);\n```\n\nSee https://github.com/nodejs/node/blob/master/lib/util.js#L805.\n\n(REPL)\n\n```\n\u003e function MyError() {}\n\u003e util.inherits(MyError, Error);\n\u003e MyError\n[Function: OError]\n\u003e Error.isPrototypeOf(MyError);\ntrue\n```\n\nYet, instanceof will now fail\n\n```\n\u003e myerr = new MyError()\n[Error]\n\u003e myerr instanceof MyError\ntrue\n\u003e myerr instanceof Error\nfalse\n```\n\nWhen using the new class feature, everything works as expected, though\n\n(REPL)\n\n```\n\u003e class MyError extends Error {}\n[Function: MyError]\n\u003e Error.isPrototypeOf(MyError)\ntrue\n\u003e myerr = new MyError()\n[Error]\n\u003e myerr instanceof MyError\ntrue\n\u003e myerr instanceof Error\ntrue\n```\n","author":{"url":"https://github.com/silkentrance","@type":"Person","name":"silkentrance"},"datePublished":"2015-12-07T22:13:03.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":17},"url":"https://github.com/4179/node/issues/4179"}