René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"perf_hooks.performance.timerify() with histogram: RangeError [ERR_OUT_OF_RANGE] on arm64","articleBody":"### Version\n\nv14, v16, v17, v18, v26\n\n### Platform\n\nmacOS v12.4 (21F79).\n\nDarwin 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:37 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T6000 arm64\n\n### Subsystem\n\nperf_hooks\n\n### What steps will reproduce the bug?\n\nRun this snippet:\n\n```js\nimport {createHistogram, performance} from 'node:perf_hooks';\n\nconst fn = () => {};\n\nconst timerified = performance.timerify(fn, {histogram: createHistogram()});\n\nfor (let i = 0; i \u003c 100_000; i++) {\n\ttry {\n\t\ttimerified();\n\t} catch (error) {\n\t\tconsole.error('Crashed on iteration', i);\n\n\t\tthrow error;\n\t}\n}\n```\n\n### How often does it reproduce? Is there a required condition?\n\n100% consistent reproduction, requires arm64, maybe requires macOS.\n\n### What is the expected behavior?\n\nCalling the timerified function returned from `perf_hooks.performance.timerify()` should successfully record to the histogram.\n\n### What do you see instead?\n\n```\nnode:internal/errors:466\n    ErrorCaptureStackTrace(err);\n    ^\n\nRangeError [ERR_OUT_OF_RANGE]: The value of \"val\" is out of range. It must be a safe integer greater than 0. Received 0\n    at new NodeError (node:internal/errors:377:5)\n    at RecordableHistogram.record (node:internal/histogram:290:13)\n    at processComplete (node:internal/perf/timerify:40:15)\n    at timerified fn (node:internal/perf/timerify:88:5)\n    at file:///Users/jonah/programming/benchmark/index.mjs:9:3\n    at ModuleJob.run (node:internal/modules/esm/module_job:198:25)\n    at async Promise.all (index 0)\n    at async ESMLoader.import (node:internal/modules/esm/loader:409:24)\n    at async loadESM (node:internal/process/esm_loader:85:5)\n    at async handleMainPromise (node:internal/modules/run_main:61:12) {\n  code: 'ERR_OUT_OF_RANGE'\n}\n\nNode.js v18.1.0\n```\n\n### Additional information\n\nOriginally reported here: https://github.com/sindresorhus/yoctocolors/pull/9#issuecomment-1019033882\n\n---\n\nThe bug appears to be from the implementation of `perf_hooks.performance.timerify()` with a histogram, when calling the returned timerified function. The error comes from the input validation of `RecordableHistogram#record()`, attempting to record a value `x \u003c 1` will throw. For whatever reason `timerify()` seems to be recording an execution duration of 0 and trying to record that. See the error stacktrace for more info.","author":{"url":"https://github.com/jonahsnider","@type":"Person","name":"jonahsnider"},"datePublished":"2022-01-22T07:10:51Z","url":"https://github.com/nodejs/node/issues/41641"}