René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Missing 'aborted' on IncomingMessage (v16 regression)","articleBody":"### Version\r\n\r\nv16.13.0 / v17.1.0\r\n\r\n### Platform\r\n\r\nDarwin Silmaril.local 21.1.0 Darwin Kernel Version 21.1.0: Wed Oct 13 17:33:24 PDT 2021; root:xnu-8019.41.5~1/RELEASE_ARM64_T8101 arm64\r\n\r\n### Subsystem\r\n\r\nhttp\r\n\r\n### What steps will reproduce the bug?\r\n\r\n```js\r\n'use strict';\r\n\r\nconst http = require('http');\r\n\r\nlet clientReq;\r\nconst server = http.createServer(function (req, res) {\r\n    req.on('aborted', function () {\r\n        console.log('ABORTED');\r\n        server.close();\r\n    });\r\n\r\n    req.on('end', () => {\r\n        console.log('DESTROY');\r\n        clientReq.destroy();\r\n    });\r\n\r\n    req.resume(); // read all client data\r\n});\r\n\r\nserver.listen(0, () => {\r\n    clientReq = http.request({\r\n        method: 'POST',\r\n        port: server.address().port,\r\n        headers: { connection: 'keep-alive' }\r\n    }, (res) => {\r\n    });\r\n\r\n    clientReq.on('error', (err) => console.log('CLIENT ERROR', err));\r\n\r\n    clientReq.end();\r\n});\r\n```\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\n100%\r\n\r\n### What is the expected behavior?\r\n\r\nScript exits and logs the following (node v14.18.1):\r\n\r\n```\r\nDESTROY\r\nCLIENT ERROR Error: socket hang up\r\n    at connResetException (internal/errors.js:639:14)\r\n    at Socket.socketCloseListener (_http_client.js:449:25)\r\n    at Socket.emit (events.js:412:35)\r\n    at TCP.\u003canonymous> (net.js:686:12) {\r\n  code: 'ECONNRESET'\r\n}\r\nABORTED\r\n```\r\n\r\n### What do you see instead?\r\n\r\nScript *never* exits and misses the last `ABORTED` line from the log:\r\n\r\n```\r\nDESTROY\r\nCLIENT ERROR Error: socket hang up\r\n    at connResetException (node:internal/errors:691:14)\r\n    at Socket.socketCloseListener (node:_http_client:420:25)\r\n    at Socket.emit (node:events:402:35)\r\n    at TCP.\u003canonymous> (node:net:687:12) {\r\n  code: 'ECONNRESET'\r\n}\r\n```\r\n\r\n### Additional information\r\n\r\nThis seems to be a fallout for #33035, which had to be reverted in the v15 release line, but now included in v16+. I discovered it while investigating https://github.com/hapijs/hapi/issues/4315.\r\n\r\nEssentially `'close'` is now emitted on `IncomingMessage` as soon as all data has been consumed, regardless of whether the underlying stream is still open (ie. the response is still being delivered). Thus node is clearly violating its own streaming API, since the underlying socket is still very much active, and will occasionally need to signal `'aborted'` on the `req` object.\r\n\r\nI expect the proper solution is to delay the `'close'` event until `res` has also finished. This should also fix related issues, like #38924.\r\n\r\n/cc @dnlup","author":{"url":"https://github.com/kanongil","@type":"Person","name":"kanongil"},"datePublished":"2021-11-10T15:32:11Z","url":"https://github.com/nodejs/node/issues/40775"}