René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Decrypting a zero-length array with SubtleCrypto triggers Assertion failures","articleBody":"\u003c!--\r\nThank you for reporting an issue.\r\n\r\nThis issue tracker is for bugs and issues found within Node.js core.\r\nIf you require more general support please file an issue on our help\r\nrepo. https://github.com/nodejs/help\r\n\r\n\r\nPlease fill in as much of the template below as you're able.\r\n\r\nVersion: output of `node -v`\r\nPlatform: output of `uname -a` (UNIX), or output of `\"$([Environment]::OSVersion | ForEach-Object VersionString) $(if ([Environment]::Is64BitOperatingSystem) { \"x64\" } else { \"x86\" })\"` in PowerShell console (Windows)\r\nSubsystem: if known, please specify affected core module name\r\n--\u003e\r\n\r\n* **Version**: v16.2.0\r\n* **Platform**: `Darwin shinji 20.6.0 Darwin Kernel Version 20.6.0: Mon May 10 03:15:35 PDT 2021; root:xnu-7195.140.13.0.1~20/RELEASE_X86_64 x86_64 i386 MacBookPro16,2 Darwin`\r\n* **Subsystem**: webcrypto (specifically SubtleCrypto)\r\n\r\n### What steps will reproduce the bug?\r\n\r\nAttempting to decrypt a zero-length array crashes node completely. There are two ways to trigger this.\r\n\r\nThe first encrypts a zero length array and then attempts to decrypt that same data:\r\n```\r\nconst crypto = require('crypto').webcrypto;\r\ncrypto.subtle.importKey('raw', new Uint8Array(32), {name: 'AES-GCM'}, false, ['encrypt','decrypt'])\r\n  .then(k =\u003e\r\n    crypto.subtle.encrypt({name: 'AES-GCM', iv: new Uint8Array(12)}, k, new Uint8Array(0))\r\n    .then(e =\u003e\r\n      crypto.subtle.decrypt({name: 'AES-GCM', iv: new Uint8Array(12)}, k, e)\r\n    )\r\n  )\r\n  .then(v =\u003e console.log(v));\r\n```\r\n\r\nThe second simply decrypts a zero length data array:\r\n```\r\nconst crypto = require('crypto').webcrypto;\r\ncrypto.subtle.importKey('raw', new Uint8Array(32), {name: 'AES-GCM'}, false, ['encrypt','decrypt'])\r\n  .then(k =\u003e crypto.subtle.decrypt({name: 'AES-GCM', iv: new Uint8Array(12)}, k, new Uint8Array(0)))\r\n  .then(v =\u003e console.log(v));\r\n```\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nEvery time.\r\n\r\n### What is the expected behavior?\r\n\r\nThe `decrypt` call should produce a zero-length array in the first case, and fail in the second (chrome rejects with `The provided data is too small`).\r\n\r\n### What do you see instead?\r\n\r\nNode crashes. The two snippets trigger different errors.\r\n\r\nFirst:\r\n```\r\nnode[51088]: ../src/crypto/crypto_cipher.h:261:virtual v8::Maybe\u003cbool\u003e node::crypto::CipherJob\u003cnode::crypto::AESCipherTraits\u003e::ToResult(v8::Local\u003cv8::Value\u003e *, v8::Local\u003cv8::Value\u003e *) [CipherTraits = node::crypto::AESCipherTraits]: Assertion `!errors-\u003eEmpty()' failed.\r\n 1: 0x105ac3832 node::Abort() [/usr/local/bin/node]\r\n 2: 0x105ac36be node::AppendExceptionLine(node::Environment*, v8::Local\u003cv8::Value\u003e, v8::Local\u003cv8::Message\u003e, node::ErrorHandlingMode) [/usr/local/bin/node]\r\n 3: 0x105b93582 node::crypto::CipherJob\u003cnode::crypto::AESCipherTraits\u003e::DoThreadPoolWork() [/usr/local/bin/node]\r\n 4: 0x105b93309 node::crypto::CryptoJob\u003cnode::crypto::AESCipherTraits\u003e::AfterThreadPoolWork(int) [/usr/local/bin/node]\r\n 5: 0x106345d74 uv__work_done [/usr/local/bin/node]\r\n 6: 0x106349528 uv__async_io [/usr/local/bin/node]\r\n 7: 0x106359662 uv__io_poll [/usr/local/bin/node]\r\n 8: 0x10634995e uv_run [/usr/local/bin/node]\r\n 9: 0x105a12624 node::SpinEventLoop(node::Environment*) [/usr/local/bin/node]\r\n10: 0x105afbd35 node::NodeMainInstance::Run(node::EnvSerializeInfo const*) [/usr/local/bin/node]\r\n11: 0x105a9ab72 node::Start(int, char**) [/usr/local/bin/node]\r\n12: 0x7fff20348f5d start [/usr/lib/system/libdyld.dylib]\r\n13: 0x1\r\nAbort trap: 6\r\n```\r\n\r\nSecond:\r\n```\r\nnode[51123]: ../src/crypto/crypto_aes.cc:92:node::crypto::WebCryptoCipherStatus node::crypto::(anonymous namespace)::AES_Cipher(node::Environment *, node::crypto::KeyObjectData *, node::crypto::WebCryptoCipherMode, const node::crypto::AESCipherConfig \u0026, const node::crypto::ByteSource \u0026, node::crypto::ByteSource *): Assertion `params.tag' failed.\r\n 1: 0x10d74e832 node::Abort() [/usr/local/bin/node]\r\n 2: 0x10d74e6be node::AppendExceptionLine(node::Environment*, v8::Local\u003cv8::Value\u003e, v8::Local\u003cv8::Message\u003e, node::ErrorHandlingMode) [/usr/local/bin/node]\r\n 3: 0x10d81ccf3 node::crypto::AES::Initialize(node::Environment*, v8::Local\u003cv8::Object\u003e) [/usr/local/bin/node]\r\n 4: 0x10d81e5d6 node::crypto::CipherJob\u003cnode::crypto::AESCipherTraits\u003e::DoThreadPoolWork() [/usr/local/bin/node]\r\n 5: 0x10dfd1128 worker [/usr/local/bin/node]\r\n 6: 0x7fff2032d8fc _pthread_start [/usr/lib/system/libsystem_pthread.dylib]\r\n 7: 0x7fff20329443 thread_start [/usr/lib/system/libsystem_pthread.dylib]\r\nAbort trap: 6\r\n```\r\n### Additional information\r\n\r\nThese inputs are far from normal, but I figure node should never _crash_.\r\n\r\nThe project I work on has property tests involving webcrypto. We've been using `node-webcrypto-ossl` to run these tests for months; we thought it might be nice to switch to the new built-in webcrypto instead. Our property tests are designed to throw all sorts of invalid values at our own code - but it turns out they throw invalid values at the webcrypto API as well.","author":{"url":"https://github.com/TheSpyder","@type":"Person","name":"TheSpyder"},"datePublished":"2021-06-01T07:00:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/38883/node/issues/38883"}