René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Accidental breaking change on v15.7.0","articleBody":"\u003c!--\r\nThank you for reporting an issue.\r\n\r\nThis issue tracker is for bugs and issues found within Node.js core.\r\nIf you require more general support please file an issue on our help\r\nrepo. https://github.com/nodejs/help\r\n\r\n\r\nPlease fill in as much of the template below as you're able.\r\n\r\nVersion: output of `node -v`\r\nPlatform: output of `uname -a` (UNIX), or output of `\"$([Environment]::OSVersion | ForEach-Object VersionString) $(if ([Environment]::Is64BitOperatingSystem) { \"x64\" } else { \"x86\" })\"` in PowerShell console (Windows)\r\nSubsystem: if known, please specify affected core module name\r\n--\u003e\r\n\r\n* **Version**: v15.7.0\r\n* **Platform**: OS X (should be reproducible on any OS)\r\n* **Subsystem**: http2\r\n\r\n### What steps will reproduce the bug?\r\n\r\nThis issue was introduced on https://github.com/nodejs/node/pull/36505\r\n\r\nTry to assign something to `req` on an instance of `Http2ServerResponse`.\r\nExample error: https://github.com/restify/node-restify/runs/2081960519?check_suite_focus=true#step:5:242\r\n\r\n```\r\nTypeError: Cannot set property req of [object Object] which has only a getter\r\n    at Server._setupRequest (/home/runner/work/node-restify/node-restify/lib/server.js:1282:13)\r\n    at Server._onRequest (/home/runner/work/node-restify/node-restify/lib/server.js:967:10)\r\n    at Http2SecureServer.emit (node:events:378:20)\r\n    at Http2SecureServer.EventEmitter.emit (node:domain:532:15)\r\n    at Http2SecureServer.onServerStream (node:internal/http2/compat:870:10)\r\n    at Http2SecureServer.emit (node:events:378:20)\r\n    at Http2SecureServer.EventEmitter.emit (node:domain:532:15)\r\n    at ServerHttp2Session.sessionOnStream (node:internal/http2/core:2930:19)\r\n    at ServerHttp2Session.emit (node:events:378:20)\r\n    at ServerHttp2Session.EventEmitter.emit (node:domain:532:15)\r\n```\r\n\r\nExample code: https://github.com/restify/node-restify/blob/master/lib/server.js#L1282\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nEvery time\r\n\r\n### What is the expected behavior?\r\n\r\nThe code should not break on a `semver-minor`\r\n\r\n### What do you see instead?\r\n\r\nAn error is thrown\r\n\r\n### Additional information\r\n\r\nThis happens because getters are not assignable on strict mode. We can't revert the change because that would also be a breaking change, so we have two options:\r\n\r\n- Change it from a `getter` to a normal property, so that user code doesn't break. We can go back to a getter on `v16`\r\n- Leave as is, assuming that users shouldn't be assigning to the response object anyway and because v15 is not an LTS version, and then add a note to the changelogs that this was an accidental breaking change that won't be reverted\r\n\r\nIf we go with the latter we might want to discuss making all properties on req/res non-assignable (which IMO is not desirable).\r\n\r\ncc @nodejs/tsc @nodejs/http2 @nodejs/releasers","author":{"url":"https://github.com/mmarchini","@type":"Person","name":"mmarchini"},"datePublished":"2021-03-11T00:50:19.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/37705/node/issues/37705"}