Title: Crash on node api add-on finalization · Issue #37236 · nodejs/node · GitHub
Open Graph Title: Crash on node api add-on finalization · Issue #37236 · nodejs/node
X Title: Crash on node api add-on finalization · Issue #37236 · nodejs/node
Description: Version: v10.23.2, v12.20.1, v14.15.4, v15.8.0 (all latest lts and current version) Platform: all Subsystem: node-api What steps will reproduce the bug? Repo to re-produce: https://github.com/legendecas/repro-napi-v8impl-refbase-double-f...
Open Graph Description: Version: v10.23.2, v12.20.1, v14.15.4, v15.8.0 (all latest lts and current version) Platform: all Subsystem: node-api What steps will reproduce the bug? Repo to re-produce: https://github.com/legen...
X Description: Version: v10.23.2, v12.20.1, v14.15.4, v15.8.0 (all latest lts and current version) Platform: all Subsystem: node-api What steps will reproduce the bug? Repo to re-produce: https://github.com/legen...
Opengraph URL: https://github.com/nodejs/node/issues/37236
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Crash on node api add-on finalization","articleBody":"* **Version**: v10.23.2, v12.20.1, v14.15.4, v15.8.0 (all latest lts and current version)\r\n* **Platform**: all\r\n* **Subsystem**: node-api\r\n\r\n### What steps will reproduce the bug?\r\n\r\nRepo to re-produce: https://github.com/legendecas/repro-napi-v8impl-refbase-double-free\r\n\r\n```\r\n$ make\r\nv14.15.4\r\nforce gc\r\nfish: 'node --expose_gc index.js' terminated by signal SIGSEGV (Address boundary error)\r\n```\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nAlways.\r\n\r\n### What is the expected behavior?\r\n\r\nNo segment faults.\r\n\r\n### What do you see instead?\r\n\r\nSegment faults on double free of `v8impl::\u003canonymous\u003e::RefBase`. The `RefBase`s were deleted once one module's napi_env was going to destroy, and the installed weak `v8impl::Persistent`s of `v8impl::\u003canonymous\u003eReference` was not destroyed and these `RefBase` will be deleted again on finalization callbacks.\r\n","author":{"url":"https://github.com/legendecas","@type":"Person","name":"legendecas"},"datePublished":"2021-02-05T08:40:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":20},"url":"https://github.com/37236/node/issues/37236"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:060dcd1d-1daf-3eba-26fe-f88f6b3101e3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AA04:35FB06:13C524:1AE0B6:6A4D9516 |
| html-safe-nonce | 704add16fe1cc6e66621ed89acf38d0807ddb5efce1e5af623a9e7dc57cb0bd0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTA0OjM1RkIwNjoxM0M1MjQ6MUFFMEI2OjZBNEQ5NTE2IiwidmlzaXRvcl9pZCI6IjQ1ODk5NTAwNDg1OTA2MTUyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 692472a5c84b587989afc59456772c62ee7553d12ae82ad68489b6a8dd383f25 |
| hovercard-subject-tag | issue:801970073 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/37236/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c103ee55f0b9d44233251dcda5df5a9826c63802018d3d7c0da32b959580734c/nodejs/node/issues/37236 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c103ee55f0b9d44233251dcda5df5a9826c63802018d3d7c0da32b959580734c/nodejs/node/issues/37236 |
| og:image:alt | Version: v10.23.2, v12.20.1, v14.15.4, v15.8.0 (all latest lts and current version) Platform: all Subsystem: node-api What steps will reproduce the bug? Repo to re-produce: https://github.com/legen... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | legendecas |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 74e2a9c78f1e38588de4f25885878349d721eedf |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width