René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"investigate flaky test/node-api/test_worker_terminate_finalization/test.js","articleBody":"\u003c!--\r\nThank you for reporting a flaky test.\r\n\r\nFlaky tests are tests that fail occasionally in the Node.js CI, but not\r\nconsistently enough to block PRs from landing, or that are failing in CI jobs or\r\ntest modes that are not run for every PR.\r\n\r\nPlease fill in as much of the template below as you're able.\r\n\r\nTest: The test that is flaky - e.g. `test-fs-stat-bigint`\r\nPlatform: The platform the test is flaky on - e.g. `macos` or `linux`\r\nConsole Output: A pasted console output from a failed CI job showing the whole\r\nfailure of the test\r\nBuild Links: Links to builds affected by the flaky test\r\n\r\nIf any investigation has been done, please include any information found, such\r\nas how consistently the test fails, whether the failure could be reproduced\r\nlocally, when the test started failing, or anything else you think is relevant.\r\n--\u003e\r\n\r\n* **Test**: test/node-api/test_worker_terminate_finalization/test.js\r\n* **Platform**: linux\r\n* **Console Output:**\r\n```\r\n=== release test ===\r\nPath: node-api/test_worker_terminate_finalization/test\r\nError: --- stderr ---\r\n=================================================================\r\n==14596==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700000cc70 at pc 0x000000be11c4 bp 0x7f273ef6cda0 sp 0x7f273ef6cd98\r\nREAD of size 8 at 0x60700000cc70 thread T7\r\n    #0 0xbe11c3 in v8impl::(anonymous namespace)::Reference::SecondPassCallback(v8::WeakCallbackInfo\u003cv8impl::(anonymous namespace)::Reference\u003e const\u0026) (/home/runner/work/node/node/out/Release/node+0xbe11c3)\r\n    #1 0x1706808 in v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacksFromTask() (/home/runner/work/node/node/out/Release/node+0x1706808)\r\n    #2 0xe2b26f in node::PerIsolatePlatformData::RunForegroundTask(std::unique_ptr\u003cv8::Task, std::default_delete\u003cv8::Task\u003e \u003e) (/home/runner/work/node/node/out/Release/node+0xe2b26f)\r\n    #3 0xe26300 in node::PerIsolatePlatformData::FlushForegroundTasksInternal() (/home/runner/work/node/node/out/Release/node+0xe26300)\r\n    #4 0xe2ba45 in node::NodePlatform::DrainTasks(v8::Isolate*) (/home/runner/work/node/node/out/Release/node+0xe2ba45)\r\n    #5 0xa8a5db in node::FreeEnvironment(node::Environment*) (/home/runner/work/node/node/out/Release/node+0xa8a5db)\r\n    #6 0xf28d41 in node::worker::Worker::Run() (/home/runner/work/node/node/out/Release/node+0xf28d41)\r\n    #7 0xf33fe0 in node::worker::Worker::StartThread(v8::FunctionCallbackInfo\u003cv8::Value\u003e const\u0026)::$_3::__invoke(void*) (/home/runner/work/node/node/out/Release/node+0xf33fe0)\r\n    #8 0x7f27453b96da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)\r\n    #9 0x7f2744cc271e in clone (/lib/x86_64-linux-gnu/libc.so.6+0x12171e)\r\n\r\n0x60700000cc70 is located 0 bytes inside of 80-byte region [0x60700000cc70,0x60700000ccc0)\r\nfreed by thread T7 here:\r\n    #0 0xa769bd in operator delete(void*) (/home/runner/work/node/node/out/Release/node+0xa769bd)\r\n    #1 0xc1622d in node_napi_env__::~node_napi_env__() (/home/runner/work/node/node/out/Release/node+0xc1622d)\r\n    #2 0xc12f53 in node::CallbackQueue\u003cvoid, node::Environment*\u003e::CallbackImpl\u003cv8impl::(anonymous namespace)::BufferFinalizer::FinalizeBufferCallback(char*, void*)::'lambda'(node::Environment*)\u003e::~CallbackImpl() (/home/runner/work/node/node/out/Release/node+0xc12f53)\r\n    #3 0xb72a20 in node::Environment::RunAndClearNativeImmediates(bool)::$_5::operator()(node::CallbackQueue\u003cvoid, node::Environment*\u003e*) const (/home/runner/work/node/node/out/Release/node+0xb72a20)\r\n    #4 0xb7070a in node::Environment::RunAndClearNativeImmediates(bool) (/home/runner/work/node/node/out/Release/node+0xb7070a)\r\n    #5 0xb6ffb3 in node::Environment::CleanupHandles() (/home/runner/work/node/node/out/Release/node+0xb6ffb3)\r\n    #6 0xb71177 in node::Environment::RunCleanup() (/home/runner/work/node/node/out/Release/node+0xb71177)\r\n    #7 0xa8a514 in node::FreeEnvironment(node::Environment*) (/home/runner/work/node/node/out/Release/node+0xa8a514)\r\n    #8 0xf28d41 in node::worker::Worker::Run() (/home/runner/work/node/node/out/Release/node+0xf28d41)\r\n    #9 0xf33fe0 in node::worker::Worker::StartThread(v8::FunctionCallbackInfo\u003cv8::Value\u003e const\u0026)::$_3::__invoke(void*) (/home/runner/work/node/node/out/Release/node+0xf33fe0)\r\n    #10 0x7f27453b96da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)\r\n\r\npreviously allocated by thread T7 here:\r\n    #0 0xa7615d in operator new(unsigned long) (/home/runner/work/node/node/out/Release/node+0xa7615d)\r\n    #1 0xbd4473 in napi_wrap (/home/runner/work/node/node/out/Release/node+0xbd4473)\r\n    #2 0x7f273e71a925 in Test (/home/runner/work/node/node/test/node-api/test_worker_terminate_finalization/build/Release/test_worker_terminate_finalization.node+0x1925)\r\n    #3 0xbdfcf2 in v8impl::(anonymous namespace)::FunctionCallbackWrapper::Invoke(v8::FunctionCallbackInfo\u003cv8::Value\u003e const\u0026) (/home/runner/work/node/node/out/Release/node+0xbdfcf2)\r\n    #4 0x138b2e3 in v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) (/home/runner/work/node/node/out/Release/node+0x138b2e3)\r\n    #5 0x1389114 in v8::internal::MaybeHandle\u003cv8::internal::Object\u003e v8::internal::(anonymous namespace)::HandleApiCallHelper\u003cfalse\u003e(v8::internal::Isolate*, v8::internal::Handle\u003cv8::internal::HeapObject\u003e, v8::internal::Handle\u003cv8::internal::HeapObject\u003e, v8::internal::Handle\u003cv8::internal::FunctionTemplateInfo\u003e, v8::internal::Handle\u003cv8::internal::Object\u003e, v8::internal::BuiltinArguments) (/home/runner/work/node/node/out/Release/node+0x1389114)\r\n    #6 0x1387192 in v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) (/home/runner/work/node/node/out/Release/node+0x1387192)\r\n    #7 0x2ca6678 in Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit (/home/runner/work/node/node/out/Release/node+0x2ca6678)\r\n    #8 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #9 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #10 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #11 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #12 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #13 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #14 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #15 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #16 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #17 0x2c3afb9 in Builtins_JSEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3afb9)\r\n    #18 0x2c3ad97 in Builtins_JSEntry (/home/runner/work/node/node/out/Release/node+0x2c3ad97)\r\n    #19 0x16575ef in v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const\u0026) (/home/runner/work/node/node/out/Release/node+0x16575ef)\r\n    #20 0x1655374 in v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle\u003cv8::internal::Object\u003e, v8::internal::Handle\u003cv8::internal::Object\u003e, int, v8::internal::Handle\u003cv8::internal::Object\u003e*) (/home/runner/work/node/node/out/Release/node+0x1655374)\r\n    #21 0x124af20 in v8::Function::Call(v8::Local\u003cv8::Context\u003e, v8::Local\u003cv8::Value\u003e, int, v8::Local\u003cv8::Value\u003e*) (/home/runner/work/node/node/out/Release/node+0x124af20)\r\n    #22 0xa7cbb2 in node::InternalMakeCallback(node::Environment*, v8::Local\u003cv8::Object\u003e, v8::Local\u003cv8::Object\u003e, v8::Local\u003cv8::Function\u003e, int, v8::Local\u003cv8::Value\u003e*, node::async_context) (/home/runner/work/node/node/out/Release/node+0xa7cbb2)\r\n    #23 0xad0b07 in node::AsyncWrap::MakeCallback(v8::Local\u003cv8::Function\u003e, int, v8::Local\u003cv8::Value\u003e*) (/home/runner/work/node/node/out/Release/node+0xad0b07)\r\n    #24 0xd8dfbc in node::worker::MessagePort::OnMessage() (/home/runner/work/node/node/out/Release/node+0xd8dfbc)\r\n    #25 0x2bf8c58 in uv__async_io /home/runner/work/node/node/out/../deps/uv/src/unix/async.c:163:5\r\n    #26 0x2c2cf30 in uv__io_poll /home/runner/work/node/node/out/../deps/uv/src/unix/linux-core.c:462:11\r\n    #27 0x2bf9c67 in uv_run /home/runner/work/node/node/out/../deps/uv/src/unix/core.c:385:5\r\n    #28 0xa7f094 in node::SpinEventLoop(node::Environment*) (/home/runner/work/node/node/out/Release/node+0xa7f094)\r\n    #29 0xf28bf4 in node::worker::Worker::Run() (/home/runner/work/node/node/out/Release/node+0xf28bf4)\r\n\r\nThread T7 created by T0 here:\r\n    #0 0xa311aa in pthread_create (/home/runner/work/node/node/out/Release/node+0xa311aa)\r\n    #1 0x2c2253a in uv_thread_create_ex /home/runner/work/node/node/out/../deps/uv/src/unix/thread.c:259:9\r\n    #2 0xf313d4 in node::worker::Worker::StartThread(v8::FunctionCallbackInfo\u003cv8::Value\u003e const\u0026) (/home/runner/work/node/node/out/Release/node+0xf313d4)\r\n    #3 0x138b2e3 in v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) (/home/runner/work/node/node/out/Release/node+0x138b2e3)\r\n    #4 0x1389114 in v8::internal::MaybeHandle\u003cv8::internal::Object\u003e v8::internal::(anonymous namespace)::HandleApiCallHelper\u003cfalse\u003e(v8::internal::Isolate*, v8::internal::Handle\u003cv8::internal::HeapObject\u003e, v8::internal::Handle\u003cv8::internal::HeapObject\u003e, v8::internal::Handle\u003cv8::internal::FunctionTemplateInfo\u003e, v8::internal::Handle\u003cv8::internal::Object\u003e, v8::internal::BuiltinArguments) (/home/runner/work/node/node/out/Release/node+0x1389114)\r\n    #5 0x1387192 in v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) (/home/runner/work/node/node/out/Release/node+0x1387192)\r\n    #6 0x2ca6678 in Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit (/home/runner/work/node/node/out/Release/node+0x2ca6678)\r\n    #7 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #8 0x2c35d98 in Builtins_ArgumentsAdaptorTrampoline (/home/runner/work/node/node/out/Release/node+0x2c35d98)\r\n    #9 0x2c3a3c0 in Builtins_JSConstructStubGeneric (/home/runner/work/node/node/out/Release/node+0x2c3a3c0)\r\n    #10 0x2d31480 in Builtins_ConstructHandler (/home/runner/work/node/node/out/Release/node+0x2d31480)\r\n    #11 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #12 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #13 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #14 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #15 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #16 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #17 0x2c3d283 in Builtins_InterpreterEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3d283)\r\n    #18 0x2c3afb9 in Builtins_JSEntryTrampoline (/home/runner/work/node/node/out/Release/node+0x2c3afb9)\r\n    #19 0x2c3ad97 in Builtins_JSEntry (/home/runner/work/node/node/out/Release/node+0x2c3ad97)\r\n    #20 0x16575ef in v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const\u0026) (/home/runner/work/node/node/out/Release/node+0x16575ef)\r\n    #21 0x1655374 in v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle\u003cv8::internal::Object\u003e, v8::internal::Handle\u003cv8::internal::Object\u003e, int, v8::internal::Handle\u003cv8::internal::Object\u003e*) (/home/runner/work/node/node/out/Release/node+0x1655374)\r\n    #22 0x124af20 in v8::Function::Call(v8::Local\u003cv8::Context\u003e, v8::Local\u003cv8::Value\u003e, int, v8::Local\u003cv8::Value\u003e*) (/home/runner/work/node/node/out/Release/node+0x124af20)\r\n    #23 0xbfc638 in node::ExecuteBootstrapper(node::Environment*, char const*, std::vector\u003cv8::Local\u003cv8::String\u003e, std::allocator\u003cv8::Local\u003cv8::String\u003e \u003e \u003e*, std::vector\u003cv8::Local\u003cv8::Value\u003e, std::allocator\u003cv8::Local\u003cv8::Value\u003e \u003e \u003e*) (/home/runner/work/node/node/out/Release/node+0xbfc638)\r\n    #24 0xc01001 in node::StartExecution(node::Environment*, char const*) (/home/runner/work/node/node/out/Release/node+0xc01001)\r\n    #25 0xbff7ca in node::StartExecution(node::Environment*, std::function\u003cv8::MaybeLocal\u003cv8::Value\u003e (node::StartExecutionCallbackInfo const\u0026)\u003e) (/home/runner/work/node/node/out/Release/node+0xbff7ca)\r\n    #26 0xa8ad1b in node::LoadEnvironment(node::Environment*, std::function\u003cv8::MaybeLocal\u003cv8::Value\u003e (node::StartExecutionCallbackInfo const\u0026)\u003e) (/home/runner/work/node/node/out/Release/node+0xa8ad1b)\r\n    #27 0xd81832 in node::NodeMainInstance::Run(node::EnvSerializeInfo const*) (/home/runner/work/node/node/out/Release/node+0xd81832)\r\n    #28 0xc054af in node::Start(int, char**) (/home/runner/work/node/node/out/Release/node+0xc054af)\r\n    #29 0x7f2744bc2bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6)\r\n\r\nSUMMARY: AddressSanitizer: heap-use-after-free (/home/runner/work/node/node/out/Release/node+0xbe11c3) in v8impl::(anonymous namespace)::Reference::SecondPassCallback(v8::WeakCallbackInfo\u003cv8impl::(anonymous namespace)::Reference\u003e const\u0026)\r\nShadow bytes around the buggy address:\r\n  0x0c0e7fff9930: fd fd fd fd fd fd fa fa fa fa fd fd fd fd fd fd\r\n  0x0c0e7fff9940: fd fd fd fa fa fa fa fa fd fd fd fd fd fd fd fd\r\n  0x0c0e7fff9950: fd fd fa fa fa fa 00 00 00 00 00 00 00 00 00 fa\r\n  0x0c0e7fff9960: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fa fa\r\n  0x0c0e7fff9970: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa\r\n=\u003e0x0c0e7fff9980: fd fd fd fd fd fd fd fd fd fd fa fa fa fa[fd]fd\r\n  0x0c0e7fff9990: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd\r\n  0x0c0e7fff99a0: fd fd fd fd fd fa fa fa fa fa fd fd fd fd fd fd\r\n  0x0c0e7fff99b0: fd fd fd fa fa fa fa fa fd fd fd fd fd fd fd fd\r\n  0x0c0e7fff99c0: fd fa fa fa fa fa 00 00 00 00 00 00 00 00 00 fa\r\n  0x0c0e7fff99d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa\r\nShadow byte legend (one shadow byte represents 8 application bytes):\r\n  Addressable:           00\r\n  Partially addressable: 01 02 03 04 05 06 07 \r\n  Heap left redzone:       fa\r\n  Freed heap region:       fd\r\n  Stack left redzone:      f1\r\n  Stack mid redzone:       f2\r\n  Stack right redzone:     f3\r\n  Stack after return:      f5\r\n  Stack use after scope:   f8\r\n  Global redzone:          f9\r\n  Global init order:       f6\r\n  Poisoned by user:        f7\r\n  Container overflow:      fc\r\n  Array cookie:            ac\r\n  Intra object redzone:    bb\r\n  ASan internal:           fe\r\n  Left alloca redzone:     ca\r\n  Right alloca redzone:    cb\r\n  Shadow gap:              cc\r\n==14596==ABORTING\r\nCommand: out/Release/node /home/runner/work/node/node/test/node-api/test_worker_terminate_finalization/test.js\r\nmake[1]: *** [test-ci] Error 1\r\nmake: *** [run-ci] Error 2\r\n\r\n===\r\n=== 1 tests failed\r\n===\r\nMakefile:514: recipe for target 'test-ci' failed\r\nMakefile:544: recipe for target 'run-ci' failed\r\nError: Process completed with exit code 2.\r\n```\r\n```\r\n=== release test ===\r\nPath: node-api/test_worker_terminate_finalization/test\r\nError: Command: out/Release/node /home/runner/work/node/node/test/node-api/test_worker_terminate_finalization/test.js\r\n--- CRASHED (Signal: 11) ---\r\n\r\n===\r\n=== 1 tests failed\r\n=== 1 tests CRASHED\r\n===\r\nmake[1]: *** [test-ci] Error 1\r\nMakefile:514: recipe for target 'test-ci' failed\r\nmake: *** [run-ci] Error 2\r\nMakefile:544: recipe for target 'run-ci' failed\r\nError: Process completed with exit code 2.\r\n```\r\n* **Build Links**:\r\n* https://github.com/nodejs/node/pull/36853/checks?check_run_id=1676654688\r\n* https://github.com/nodejs/node/pull/36853/checks?check_run_id=1676654768\r\n\r\nRefs: https://github.com/nodejs/node/issues/34731","author":{"url":"https://github.com/RaisinTen","@type":"Person","name":"RaisinTen"},"datePublished":"2021-01-10T15:57:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":26},"url":"https://github.com/36868/node/issues/36868"}