René's URL Explorer Experiment


Title: `vm.Script`'s `importModuleDynamically` should get a reference to the `context` used to run it · Issue #35714 · nodejs/node · GitHub

Open Graph Title: `vm.Script`'s `importModuleDynamically` should get a reference to the `context` used to run it · Issue #35714 · nodejs/node

X Title: `vm.Script`'s `importModuleDynamically` should get a reference to the `context` used to run it · Issue #35714 · nodejs/node

Description: Is your feature request related to a problem? Please describe. When implementing importModuleDynamically you don't have access to what context the script is executed with, meaning you can't pass the correct context when constructing a Mo...

Open Graph Description: Is your feature request related to a problem? Please describe. When implementing importModuleDynamically you don't have access to what context the script is executed with, meaning you can't pass th...

X Description: Is your feature request related to a problem? Please describe. When implementing importModuleDynamically you don't have access to what context the script is executed with, meaning you can't...

Opengraph URL: https://github.com/nodejs/node/issues/35714

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`vm.Script`'s `importModuleDynamically` should get a reference to the `context` used to run it","articleBody":"\u003c!--\r\nThank you for suggesting an idea to make Node.js better.\r\n\r\nPlease fill in as much of the template below as you're able.\r\n--\u003e\r\n\r\n**Is your feature request related to a problem? Please describe.**\r\n\r\nWhen implementing `importModuleDynamically` you don't have access to what context the script is executed with, meaning you can't pass the correct context when constructing a `Module`. We're also missing the `filename` of the `Script`, so resolving to the specifier passed is also not straightforward since it can be changed by `.runIn*Context()` calls from what I passed in to the constructor.\r\n\r\n**Describe the solution you'd like**\r\n\r\nI think adding `context` and `filename` as accessible properties on the `Script` instance passed to the function should work fine - it would mirror what you get when using `SourceTextModule` where I have access to `context` and `identifier`. It could also be passed as a third argument to the function passed in `importModuleDynamically` if you don't wanna change the `Script` instance itself.\r\n\r\n**Describe alternatives you've considered**\r\n\r\nThe [implementation](https://github.com/facebook/jest/blob/30e802036291f4c9c9fd4feef6faba485df54dd2/packages/jest-runtime/src/index.ts#L1128-L1134) I've gone with in the absence of such an API is to get the context again and re-use the filename passed in the constructor. This works since I also have control over how the script is executed, but that might not always be the case. Mirroring the capability of `SourceTextModule` would be nice, though - where in the context of the callback in `importModuleDynamically` there's enough information to know how to resolve the specifier being requested and in what context it should run.","author":{"url":"https://github.com/SimenB","@type":"Person","name":"SimenB"},"datePublished":"2020-10-20T07:16:58.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/35714/node/issues/35714"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:78a7980b-ffa9-8665-a0f8-61042ef16515
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idABDA:2B8B4B:8F9663:C3CA66:6A4DD93F
html-safe-nonceb83dcd6291126885645c82722cd22654dcc18a99118e63e57a0d5991be3bbf11
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkRBOjJCOEI0Qjo4Rjk2NjM6QzNDQTY2OjZBNEREOTNGIiwidmlzaXRvcl9pZCI6IjI2NTM2MzkzMzA3OTk0MDk0NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9e27784507b1e66b1340e5be31559ddf7e13bd28b0245570a020c9cff7adc273
hovercard-subject-tagissue:725280963
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/35714/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4983002f1747b1980c10909f4a7bc7a721430266ef841c7e6c44e51137b6c288/nodejs/node/issues/35714
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4983002f1747b1980c10909f4a7bc7a721430266ef841c7e6c44e51137b6c288/nodejs/node/issues/35714
og:image:altIs your feature request related to a problem? Please describe. When implementing importModuleDynamically you don't have access to what context the script is executed with, meaning you can't pass th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSimenB
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/issues/35714#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F35714
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F35714
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/35714
Reloadhttps://github.com/nodejs/node/issues/35714
Reloadhttps://github.com/nodejs/node/issues/35714
Please reload this pagehttps://github.com/nodejs/node/issues/35714
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/issues/35714
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
vm.Script's importModuleDynamically should get a reference to the context used to run ithttps://github.com/nodejs/node/issues/35714#top
moduleIssues and PRs related to the module subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22module%22
stalehttps://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stale%22
vmIssues and PRs related to the vm subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22vm%22
https://github.com/SimenB
SimenBhttps://github.com/SimenB
on Oct 20, 2020https://github.com/nodejs/node/issues/35714#issue-725280963
implementationhttps://github.com/facebook/jest/blob/30e802036291f4c9c9fd4feef6faba485df54dd2/packages/jest-runtime/src/index.ts#L1128-L1134
moduleIssues and PRs related to the module subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22module%22
stalehttps://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22stale%22
vmIssues and PRs related to the vm subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22vm%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.