Title: `vm.Script`'s `importModuleDynamically` should get a reference to the `context` used to run it · Issue #35714 · nodejs/node · GitHub
Open Graph Title: `vm.Script`'s `importModuleDynamically` should get a reference to the `context` used to run it · Issue #35714 · nodejs/node
X Title: `vm.Script`'s `importModuleDynamically` should get a reference to the `context` used to run it · Issue #35714 · nodejs/node
Description: Is your feature request related to a problem? Please describe. When implementing importModuleDynamically you don't have access to what context the script is executed with, meaning you can't pass the correct context when constructing a Mo...
Open Graph Description: Is your feature request related to a problem? Please describe. When implementing importModuleDynamically you don't have access to what context the script is executed with, meaning you can't pass th...
X Description: Is your feature request related to a problem? Please describe. When implementing importModuleDynamically you don't have access to what context the script is executed with, meaning you can't...
Opengraph URL: https://github.com/nodejs/node/issues/35714
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`vm.Script`'s `importModuleDynamically` should get a reference to the `context` used to run it","articleBody":"\u003c!--\r\nThank you for suggesting an idea to make Node.js better.\r\n\r\nPlease fill in as much of the template below as you're able.\r\n--\u003e\r\n\r\n**Is your feature request related to a problem? Please describe.**\r\n\r\nWhen implementing `importModuleDynamically` you don't have access to what context the script is executed with, meaning you can't pass the correct context when constructing a `Module`. We're also missing the `filename` of the `Script`, so resolving to the specifier passed is also not straightforward since it can be changed by `.runIn*Context()` calls from what I passed in to the constructor.\r\n\r\n**Describe the solution you'd like**\r\n\r\nI think adding `context` and `filename` as accessible properties on the `Script` instance passed to the function should work fine - it would mirror what you get when using `SourceTextModule` where I have access to `context` and `identifier`. It could also be passed as a third argument to the function passed in `importModuleDynamically` if you don't wanna change the `Script` instance itself.\r\n\r\n**Describe alternatives you've considered**\r\n\r\nThe [implementation](https://github.com/facebook/jest/blob/30e802036291f4c9c9fd4feef6faba485df54dd2/packages/jest-runtime/src/index.ts#L1128-L1134) I've gone with in the absence of such an API is to get the context again and re-use the filename passed in the constructor. This works since I also have control over how the script is executed, but that might not always be the case. Mirroring the capability of `SourceTextModule` would be nice, though - where in the context of the callback in `importModuleDynamically` there's enough information to know how to resolve the specifier being requested and in what context it should run.","author":{"url":"https://github.com/SimenB","@type":"Person","name":"SimenB"},"datePublished":"2020-10-20T07:16:58.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/35714/node/issues/35714"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:78a7980b-ffa9-8665-a0f8-61042ef16515 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ABDA:2B8B4B:8F9663:C3CA66:6A4DD93F |
| html-safe-nonce | b83dcd6291126885645c82722cd22654dcc18a99118e63e57a0d5991be3bbf11 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkRBOjJCOEI0Qjo4Rjk2NjM6QzNDQTY2OjZBNEREOTNGIiwidmlzaXRvcl9pZCI6IjI2NTM2MzkzMzA3OTk0MDk0NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9e27784507b1e66b1340e5be31559ddf7e13bd28b0245570a020c9cff7adc273 |
| hovercard-subject-tag | issue:725280963 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/35714/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4983002f1747b1980c10909f4a7bc7a721430266ef841c7e6c44e51137b6c288/nodejs/node/issues/35714 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4983002f1747b1980c10909f4a7bc7a721430266ef841c7e6c44e51137b6c288/nodejs/node/issues/35714 |
| og:image:alt | Is your feature request related to a problem? Please describe. When implementing importModuleDynamically you don't have access to what context the script is executed with, meaning you can't pass th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | SimenB |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width