Title: meta: callback checking is inconsistent across lib · Issue #3536 · nodejs/node · GitHub
Open Graph Title: meta: callback checking is inconsistent across lib · Issue #3536 · nodejs/node
X Title: meta: callback checking is inconsistent across lib · Issue #3536 · nodejs/node
Description: Throughout the codebase there are two altering ways that callbacks are checked. In some instances it is checked for truthyness if (callback) process.nextTick(callback) Where in others it is explicitly checked if (typeof callback === 'fun...
Open Graph Description: Throughout the codebase there are two altering ways that callbacks are checked. In some instances it is checked for truthyness if (callback) process.nextTick(callback) Where in others it is explici...
X Description: Throughout the codebase there are two altering ways that callbacks are checked. In some instances it is checked for truthyness if (callback) process.nextTick(callback) Where in others it is explici...
Opengraph URL: https://github.com/nodejs/node/issues/3536
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"meta: callback checking is inconsistent across lib","articleBody":"Throughout the codebase there are two altering ways that callbacks are checked.\n\nIn some instances it is checked for truthyness\n\n``` js\nif (callback)\n process.nextTick(callback)\n```\n\nWhere in others it is explicitly checked\n\n``` js\nif (typeof callback === 'function')\n process.nextTick(callback)\n```\n\nHopefully this is not opening too large a bike shed, but I was curious if their is a legitimate benefit to using both.\n","author":{"url":"https://github.com/MylesBorins","@type":"Person","name":"MylesBorins"},"datePublished":"2015-10-26T21:58:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/3536/node/issues/3536"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6e726050-01d5-2809-4237-c3b8cfb3e542 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8E46:1EEE:376CB8:50849D:6A4F6C2E |
| html-safe-nonce | 01dd8fa49e8174e8bd4ec5ee2510fa1403ddbe338a5e5d55a7573f28e6e14aaf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTQ2OjFFRUU6Mzc2Q0I4OjUwODQ5RDo2QTRGNkMyRSIsInZpc2l0b3JfaWQiOiIzMzQ5NTM0NzY5ODkzMzA1MzkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 214b512eda6694e76e7895a45ad76814694d72a31810fa6b9a517b48a8902b93 |
| hovercard-subject-tag | issue:113460141 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/3536/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3712c8910d3e9aabfd4bb37f04fd7d084c26a2617bc1a924167b457519ee9b2a/nodejs/node/issues/3536 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3712c8910d3e9aabfd4bb37f04fd7d084c26a2617bc1a924167b457519ee9b2a/nodejs/node/issues/3536 |
| og:image:alt | Throughout the codebase there are two altering ways that callbacks are checked. In some instances it is checked for truthyness if (callback) process.nextTick(callback) Where in others it is explici... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MylesBorins |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width