René's URL Explorer Experiment


Title: Legacy stream throws unhandled stream error when it is handled · Issue #35237 · nodejs/node · GitHub

Open Graph Title: Legacy stream throws unhandled stream error when it is handled · Issue #35237 · nodejs/node

X Title: Legacy stream throws unhandled stream error when it is handled · Issue #35237 · nodejs/node

Description: Version: 14.11.0 Platform: Linux solus 5.6.19-158.current #1 SMP PREEMPT Sun Jul 26 14:17:01 UTC 2020 x86_64 GNU/Linux Subsystem: stream What steps will reproduce the bug? const {Stream: LegacyStream, PassThrough} = require('stream'); co...

Open Graph Description: Version: 14.11.0 Platform: Linux solus 5.6.19-158.current #1 SMP PREEMPT Sun Jul 26 14:17:01 UTC 2020 x86_64 GNU/Linux Subsystem: stream What steps will reproduce the bug? const {Stream: LegacyStre...

X Description: Version: 14.11.0 Platform: Linux solus 5.6.19-158.current #1 SMP PREEMPT Sun Jul 26 14:17:01 UTC 2020 x86_64 GNU/Linux Subsystem: stream What steps will reproduce the bug? const {Stream: LegacyStre...

Opengraph URL: https://github.com/nodejs/node/issues/35237

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Legacy stream throws unhandled stream error when it is handled","articleBody":"* **Version**: `14.11.0`\r\n* **Platform**: `Linux solus 5.6.19-158.current #1 SMP PREEMPT Sun Jul 26 14:17:01 UTC 2020 x86_64 GNU/Linux`\r\n* **Subsystem**: `stream`\r\n\r\n### What steps will reproduce the bug?\r\n\r\n```js\r\nconst {Stream: LegacyStream, PassThrough} = require('stream');\r\n\r\nconst destination = new PassThrough();\r\ndestination.once('error', () => {});\r\n\r\nconst stream = new LegacyStream();\r\nstream.pipe(destination);\r\n\r\ndestination.destroy(new Error('this should be handled'));\r\n```\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nAlways.\r\n\r\n### What is the expected behavior?\r\n\r\nNo error.\r\n\r\n### What do you see instead?\r\n\r\n```\r\ninternal/streams/legacy.js:61\r\n      throw er; // Unhandled stream error in pipe.\r\n      ^\r\n\r\nError: this should be handled\r\n    at Object.\u003canonymous> (/home/szm/Desktop/got/demo.js:9:21)\r\n    at Module._compile (internal/modules/cjs/loader.js:1076:30)\r\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)\r\n    at Module.load (internal/modules/cjs/loader.js:941:32)\r\n    at Function.Module._load (internal/modules/cjs/loader.js:782:14)\r\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\r\n    at internal/main/run_main_module.js:17:47\r\n```\r\n\r\n### Additional information\r\n\r\nhttps://github.com/sindresorhus/got/issues/887\r\n","author":{"url":"https://github.com/szmarczak","@type":"Person","name":"szmarczak"},"datePublished":"2020-09-17T01:11:09Z","url":"https://github.com/nodejs/node/issues/35237"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2022826b-c9b2-eccc-594f-7dc39bda9023
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAB5C:39A2F9:1AA1F98:23B70CB:6AED899A
html-safe-nonce7d73a2662e64dae4455bc5613c9179133c52248af816bf686f3bcb0311dbfedc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjVDOjM5QTJGOToxQUExRjk4OjIzQjcwQ0I6NkFFRDg5OUEiLCJ2aXNpdG9yX2lkIjoiMjM1MDM3NjYyOTI1MTcwNTI0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6ed3920348a2f346e4239df4a54b8eef11ba7aa029973aba2e183ee53e1b11a0
hovercard-subject-tagissue:703190024
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/35237/issue_layout
twitter:imagehttps://opengraph.githubassets.com/1b02d40990c96f7e32990a6f78decf130699e8f630a9596aa0436db8b23037eb/nodejs/node/issues/35237
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1b02d40990c96f7e32990a6f78decf130699e8f630a9596aa0436db8b23037eb/nodejs/node/issues/35237
og:image:altVersion: 14.11.0 Platform: Linux solus 5.6.19-158.current #1 SMP PREEMPT Sun Jul 26 14:17:01 UTC 2020 x86_64 GNU/Linux Subsystem: stream What steps will reproduce the bug? const {Stream: LegacyStre...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameszmarczak
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/35237#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F35237
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F35237
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/35237
Reloadhttps://github.com/nodejs/node/issues/35237
Reloadhttps://github.com/nodejs/node/issues/35237
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/35237
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/35237
Legacy stream throws unhandled stream error when it is handledhttps://github.com/nodejs/node/issues/35237#top
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
on Sep 17, 2020https://github.com/nodejs/node/issues/35237#issue-703190024
sindresorhus/got#887https://github.com/sindresorhus/got/issues/887
https://github.com/targos
targoshttps://github.com/targos
on Sep 18, 2020https://github.com/nodejs/node/issues/35237#issuecomment-694842619
https://github.com/ronag
ronaghttps://github.com/ronag
on Sep 18, 2020https://github.com/nodejs/node/issues/35237#issuecomment-694867167
https://github.com/ronag
ronaghttps://github.com/ronag
on Sep 18, 2020https://github.com/nodejs/node/issues/35237#issuecomment-694869345
Trotthttps://github.com/Trott
on Sep 23, 2020https://github.com/nodejs/node/issues/35237#event-3797629766
stream: fix legacy pipe error handlinghttps://github.com/Trott/io.js/commit/6be80e1893679cffcb00c27b0b9df2606c4e4b3b
6be80e1https://github.com/Trott/io.js/commit/6be80e1893679cffcb00c27b0b9df2606c4e4b3b
Trotthttps://github.com/Trott
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
6be80e1https://github.com/nodejs/node/commit/6be80e1893679cffcb00c27b0b9df2606c4e4b3b
on Sep 23, 2020https://github.com/nodejs/node/issues/35237#event-3797630139
joesepihttps://github.com/joesepi
on Jan 8, 2021https://github.com/nodejs/node/issues/35237#event-4185390327
stream: fix legacy pipe error handlinghttps://github.com/joesepi/node/commit/4c279b49e68bc6dcdc56be0b5df72d80f477cfcc
4c279b4https://github.com/joesepi/node/commit/4c279b49e68bc6dcdc56be0b5df72d80f477cfcc
targoshttps://github.com/targos
on May 16, 2021https://github.com/nodejs/node/issues/35237#event-4751025100
stream: fix legacy pipe error handlinghttps://github.com/nodejs/node/commit/22bf488435978177c5ff28ed4a5373c4ae880896
22bf488https://github.com/nodejs/node/commit/22bf488435978177c5ff28ed4a5373c4ae880896
targoshttps://github.com/targos
on Jun 11, 2021https://github.com/nodejs/node/issues/35237#event-4876230330
stream: fix legacy pipe error handlinghttps://github.com/nodejs/node/commit/c31e2f6b0fcdc8e24a845028202c82fee885d4d0
c31e2f6https://github.com/nodejs/node/commit/c31e2f6b0fcdc8e24a845028202c82fee885d4d0
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/35237
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/35237
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.