René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"MacOS build fails","articleBody":"MacOS builds fail on CI\r\n\r\nExamples:\r\nhttps://github.com/nodejs/node/pull/33395/checks?check_run_id=673915168\r\nhttps://github.com/nodejs/node/pull/33396/checks?check_run_id=673650394\r\nhttps://github.com/nodejs/node/pull/33399/checks?check_run_id=674009996\r\n\r\n```\r\nmake[2]: *** [/Users/runner/runners/2.169.1/work/node/node/out/Release/obj.target/libnode/src/api/environment.o] Error 1\r\nIn file included from ../src/async_wrap.cc:23:\r\nIn file included from ../src/async_wrap-inl.h:29:\r\n../src/node_internals.h:115:17: error: 'Reallocate' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]\r\n  virtual void* Reallocate(void* data, size_t old_size, size_t size);\r\n                ^\r\n../deps/v8/include/v8.h:5064:19: note: overridden virtual function is here\r\n    virtual void* Reallocate(void* data, size_t old_length, size_t new_length);\r\n                  ^\r\n1 error generated.\r\nmake[2]: *** [/Users/runner/runners/2.169.1/work/node/node/out/Release/obj.target/libnode/src/async_wrap.o] Error 1\r\nrm 901e15e3bfa09076435ef2c6529c32d9b1b08dee.intermediate 4932d3b9aac55583abc688388403c323f0ca30f4.intermediate\r\nmake[1]: *** [node] Error 2\r\nmake: *** [build-ci] Error 2\r\n```\r\n\r\nThe failure might be caused by this commit fcc183c99413750b1b965e45cb42a1af73da47ab. @richardlau is it OK that builds fail?","author":{"url":"https://github.com/shackijj","@type":"Person","name":"shackijj"},"datePublished":"2020-05-14T10:28:09Z","url":"https://github.com/nodejs/node/issues/33401"}