René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"New build warnings","articleBody":"\u003c!--\r\nThank you for reporting an issue.\r\n\r\nThis issue tracker is for bugs and issues found within Node.js core.\r\nIf you require more general support please file an issue on our help\r\nrepo. https://github.com/nodejs/help\r\n\r\n\r\nPlease fill in as much of the template below as you're able.\r\n\r\nVersion: output of `node -v`\r\nPlatform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)\r\nSubsystem: if known, please specify affected core module name\r\n-->\r\n\r\n* **Version**: master\r\n* **Platform**: macOS/Linux\r\n* **Subsystem**:\r\n\r\n### What steps will reproduce the bug?\r\n\r\nBuild with the `--error-on-warn` configure option.\r\n\u003c!--\r\nEnter details about your bug, preferably a simple code snippet that can be\r\nrun using `node` directly without installing third-party dependencies.\r\n-->\r\n\r\n### How often does it reproduce? Is there a required condition?\r\n\r\nAlways.\r\n\r\n### What is the expected behavior?\r\n\r\nBuild succeeds.\r\n\u003c!--\r\nIf possible please provide textual output instead of screenshots.\r\n-->\r\n\r\n### What do you see instead?\r\n\r\nBuild errors on warning:\r\n```\r\n../src/api/environment.cc: In function 'void node::SetIsolateMiscHandlers(v8::Isolate*, const node::IsolateSettings&)':\r\n../src/api/environment.cc:265:67: error: 'void v8::Isolate::SetHostCleanupFinalizationGroupCallback(v8::HostCleanupFinalizationGroupCallback)' is deprecated: FinalizationRegistry cleanup is automatic if HostCleanupFinalizationGroupCallback is not set [-Werror=deprecated-declarations]\r\n   isolate->SetHostCleanupFinalizationGroupCallback(host_cleanup_cb);\r\n                                                                   ^\r\nIn file included from ../src/node.h:67,\r\n                 from ../src/api/environment.cc:1:\r\n../deps/v8/include/v8.h:8560:8: note: declared here\r\n   void SetHostCleanupFinalizationGroupCallback(\r\n        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\ncc1plus: all warnings being treated as errors\r\nmake[2]: *** [libnode.target.mk:343: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode/src/api/environment.o] Error 1\r\nmake[2]: *** Waiting for unfinished jobs....\r\n../src/env.cc: In member function 'void node::Environment::CleanupFinalizationGroups()':\r\n../src/env.cc:1170:29: error: 'static v8::Maybe\u003cbool> v8::FinalizationGroup::Cleanup(v8::Local\u003cv8::FinalizationGroup>)' is deprecated: FinalizationGroup cleanup is automatic if HostCleanupFinalizationGroupCallback is not set [-Werror=deprecated-declarations]\r\n     if (!FinalizationGroup::Cleanup(fg).FromMaybe(false)) {\r\n                             ^~~~~~~\r\nIn file included from ../src/util.h:31,\r\n                 from ../src/util-inl.h:29,\r\n                 from ../src/aliased_buffer.h:7,\r\n                 from ../src/env.h:27,\r\n                 from ../src/env.cc:1:\r\n../deps/v8/include/v8.h:5965:44: note: declared here\r\n   static V8_WARN_UNUSED_RESULT Maybe\u003cbool> Cleanup(\r\n                                            ^~~~~~~\r\n../src/env.cc:1170:39: error: 'static v8::Maybe\u003cbool> v8::FinalizationGroup::Cleanup(v8::Local\u003cv8::FinalizationGroup>)' is deprecated: FinalizationGroup cleanup is automatic if HostCleanupFinalizationGroupCallback is not set [-Werror=deprecated-declarations]\r\n     if (!FinalizationGroup::Cleanup(fg).FromMaybe(false)) {\r\n                                       ^\r\nIn file included from ../src/util.h:31,\r\n                 from ../src/util-inl.h:29,\r\n                 from ../src/aliased_buffer.h:7,\r\n                 from ../src/env.h:27,\r\n                 from ../src/env.cc:1:\r\n../deps/v8/include/v8.h:5965:44: note: declared here\r\n   static V8_WARN_UNUSED_RESULT Maybe\u003cbool> Cleanup(\r\n                                            ^~~~~~~\r\n../src/env.cc:1170:39: error: 'static v8::Maybe\u003cbool> v8::FinalizationGroup::Cleanup(v8::Local\u003cv8::FinalizationGroup>)' is deprecated: FinalizationGroup cleanup is automatic if HostCleanupFinalizationGroupCallback is not set [-Werror=deprecated-declarations]\r\n     if (!FinalizationGroup::Cleanup(fg).FromMaybe(false)) {\r\n                                       ^\r\nIn file included from ../src/util.h:31,\r\n                 from ../src/util-inl.h:29,\r\n                 from ../src/aliased_buffer.h:7,\r\n                 from ../src/env.h:27,\r\n                 from ../src/env.cc:1:\r\n../deps/v8/include/v8.h:5965:44: note: declared here\r\n   static V8_WARN_UNUSED_RESULT Maybe\u003cbool> Cleanup(\r\n                                            ^~~~~~~\r\ncc1plus: all warnings being treated as errors\r\n```\r\n\u003c!--\r\nIf possible please provide textual output instead of screenshots.\r\n-->\r\n\r\n### Additional information\r\n\r\n\u003c!--\r\nTell us anything else you think we should know.\r\n-->\r\nSomething has landed within the last day or so that has introduced some new warnings which is failing the builds that have the `--error-on-warn` configure flag on. e.g. GitHub actions (after https://github.com/nodejs/node/pull/33357 landed) and the UBI 8.1 containered build, e.g. from today's daily: https://ci.nodejs.org/job/node-test-commit-linux-containered/20158/nodes=ubi81_sharedlibs_openssl111fips_x64/console\r\n\r\nI'd guess it might be the V8 8.3 update (https://github.com/nodejs/node/pull/32831) whose CI runs were from before we enabled the flag.","author":{"url":"https://github.com/richardlau","@type":"Person","name":"richardlau"},"datePublished":"2020-05-13T16:40:53Z","url":"https://github.com/nodejs/node/issues/33389"}