Title: Resource is optional in `napi_async_init` · Issue #33153 · nodejs/node · GitHub
Open Graph Title: Resource is optional in `napi_async_init` · Issue #33153 · nodejs/node
X Title: Resource is optional in `napi_async_init` · Issue #33153 · nodejs/node
Description: Maybe we should also think about adapting napi_async_init as it states that the resource is optional. As Node is meanwhile built to require an async resource it seems to be strange that we create an object on the fly if user doesn't prov...
Open Graph Description: Maybe we should also think about adapting napi_async_init as it states that the resource is optional. As Node is meanwhile built to require an async resource it seems to be strange that we create a...
X Description: Maybe we should also think about adapting napi_async_init as it states that the resource is optional. As Node is meanwhile built to require an async resource it seems to be strange that we create a...
Opengraph URL: https://github.com/nodejs/node/issues/33153
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Resource is optional in `napi_async_init`","articleBody":"Maybe we should also think about adapting `napi_async_init` as it states that the resource is optional. As Node is meanwhile built to require an async resource it seems to be strange that we create an object on the fly if user doesn't provide one.\r\nRemoving the null check in `napi_async_init` would be no issue from ABI point of view but breaking from behavior. Not sure if this should be included in this PR.\r\n\r\n_Originally posted by @Flarna in https://github.com/nodejs/node/pull/32930_","author":{"url":"https://github.com/legendecas","@type":"Person","name":"legendecas"},"datePublished":"2020-04-30T03:04:12Z","url":"https://github.com/nodejs/node/issues/33153"}| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1d7e3d4d-5d7a-de04-d00a-7a5bc96da94f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DDFE:12AE65:472383:5C0A30:6AED238A |
| html-safe-nonce | 9713e6ba0f138b303d6cca3272e352f331e6d0326ad15d46162e736fc1feaa65 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREZFOjEyQUU2NTo0NzIzODM6NUMwQTMwOjZBRUQyMzhBIiwidmlzaXRvcl9pZCI6IjEzNTU1MTc1NTMyOTQ1MTcxMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 370323fc346b82ffb235904386bdf2a424cdd1ed9ad1eb95966a40f24d8a1622 |
| hovercard-subject-tag | issue:609530695 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/33153/issue_layout |
| twitter:image | https://opengraph.githubassets.com/82dd014c1e25ae9da68aa7af5d78b8ed21592894a385ae7a19ca80c64fa4995b/nodejs/node/issues/33153 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/82dd014c1e25ae9da68aa7af5d78b8ed21592894a385ae7a19ca80c64fa4995b/nodejs/node/issues/33153 |
| og:image:alt | Maybe we should also think about adapting napi_async_init as it states that the resource is optional. As Node is meanwhile built to require an async resource it seems to be strange that we create a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | legendecas |
| hostname | github.com |
| expected-hostname | github.com |
| None | e3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 707a24b346ac8a82878b9c084efaa38a997660cb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width