René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"napi_get_value_uint32 difference between Node 14 and previous","articleBody":"Hi,\r\n\r\nIn sodium-native we have a special malloc that allows you to allocated a mmap'ed buffer with special flags that provide extra protection. The signature is `sodium_malloc(bytes)` where `bytes` can be up to `0xffffffff`. Until Node 14 `napi_get_value_uint32` would fail for numbers outside this range (eg. `-1` or `Number.MAX_SAFE_INTEGER`) but for Node 14 our tests now fail with varying errors on different operating system. My guess is that in Node 14, this wraps around, but it is unspecified by the napi docs whether wrap around does happen, so we might have relied on undefined behaviour.\r\n\r\nHere is our failing tests:\r\nhttps://github.com/sodium-friends/sodium-native/blob/91e28b44648164ba8054f22e9a96c826329462bd/test/memory.js#L117-L125\r\n\r\nHere is the macro we use to read a `uint32_t` from a `Number`:\r\nhttps://github.com/sodium-friends/sodium-native/blob/91e28b44648164ba8054f22e9a96c826329462bd/macros.h#L157-L161","author":{"url":"https://github.com/emilbayes","@type":"Person","name":"emilbayes"},"datePublished":"2020-04-28T07:00:06Z","url":"https://github.com/nodejs/node/issues/33117"}